Skip to contentSkip to conversation

rt2x00: Fix chipset detection for rt73usb

PATCH Ivo van Doorn 1 participant 1 message May 8, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

The lower 4 bytes of the chipset revision must contain a non-zero value. This bug was introduced by

commit: fbebe7c588a341d7a39ce0b0ea5bd5c58f906b07
rt2x00: Simplify rt2x00_check_rev

rt2x00_check_rev() was too specific for rt2500usb and rt73usb, by adding the mask argument (instead of hardcoding it into the function itself) we can use the function in rt2800usb as well.

v2: Fix revision mask for rt2800usb

---
 drivers/net/wireless/rt2x00/rt73usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/rt2x00/rt73usb.c +1 -1
index 4f94a61..dc2ad94 100644
@@ -1847,7 +1847,7 @@ static int rt73usb_init_eeprom(struct rt2x00_dev *rt2x00dev)
 	rt2x00_set_chip(rt2x00dev, RT2571, value, reg);
 
 	if (!rt2x00_check_rev(&rt2x00dev->chip, 0x000ffff0, 0x25730) ||
-	    !rt2x00_check_rev(&rt2x00dev->chip, 0x0000000f, 0)) {
+	    rt2x00_check_rev(&rt2x00dev->chip, 0x0000000f, 0)) {
 		ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
 		return -ENODEV;
 	}
Signature · 1 line
1.6.2.3