Skip to contentSkip to conversation

pcf50633: Fix unsafe disable_irq

PATCH New Nelson Castillo 1 participant 1 message May 9, 2009 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcf50633: Fix unsafe disable_irq

Without this change Openmoko Freerunner (GTA02) bootstrap will deadlock. As pointed out in other patches this issue is in the wild since the merge of:

commit 3aa551c9b4c40018f0e261a178e3d25478dc04a9

Author: Thomas Gleixner <[email protected]>
Date:   Mon Mar 23 18:28:15 2009 +0100

genirq: add threaded interrupt handler support

Add support for threaded interrupt handlers

---

 drivers/mfd/pcf50633-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/pcf50633-core.c +1 -1
index 7793932..11a6248 100644
@@ -443,7 +443,7 @@ static irqreturn_t pcf50633_irq(int irq, void *data)
 	dev_dbg(pcf->dev, "pcf50633_irq\n");
 
 	get_device(pcf->dev);
-	disable_irq(pcf->irq);
+	disable_irq_nosync(pcf->irq);
 	schedule_work(&pcf->irq_work);
 
 	return IRQ_HANDLED;