Skip to contentSkip to conversation

Leadtek WinFast DTV-1800H support

PATCH In review Miroslav Šustek 2 participants 3 messages May 10, 2009 – May 28, 2009 3 messages not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#3 lore raw

PATCH 1/1 Leadtek WinFast DTV-1800H support

In reply to a message not in the archive

Hello,
this patch adds support for Leadtek WinFast DTV-1800H hybrid card. It enables analog/digital tv, radio and remote control trough GPIO.

Input GPIO values are extracted from INF file which is included in winxp driver. Analog audio works both through cx88-alsa and through internal cable from tv-card to sound card.

Tested by me and the people listed in patch (works well).

- Miroslav

Adds support for Leadtek WinFast DTV-1800H

From: Miroslav Sustek <[email protected]>

Enables analog/digital tv, radio and remote control (gpio).

linux/Documentation/video4linux/CARDLIST.cx88 +1 -0
diff -r ee3b79edde3f linux/Documentation/video4linux/CARDLIST.cx88
@@ -79,3 +79,4 @@
  78 -> Prof 6200 DVB-S                                     [b022:3022]
  79 -> Terratec Cinergy HT PCI MKII                        [153b:1177]
  80 -> Hauppauge WinTV-IR Only                             [0070:9290]
+ 81 -> Leadtek WinFast DTV1800 Hybrid                      [107d:6654]
linux/drivers/media/video/cx88/cx88-cards.c +75 -0

111 lines not on this page · raw message

linux/drivers/media/video/cx88/cx88-dvb.c +1 -0
diff -r ee3b79edde3f linux/drivers/media/video/cx88/cx88-dvb.c
@@ -1021,6 +1021,7 @@
 		}
 		break;
 	 case CX88_BOARD_PINNACLE_HYBRID_PCTV:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		fe0->dvb.frontend = dvb_attach(zl10353_attach,
 					       &cx88_pinnacle_hybrid_pctv,
 					       &core->i2c_adap);
linux/drivers/media/video/cx88/cx88-input.c +2 -0
diff -r ee3b79edde3f linux/drivers/media/video/cx88/cx88-input.c
@@ -92,6 +92,7 @@
 		gpio=(gpio & 0x7fd) + (auxgpio & 0xef);
 		break;
 	case CX88_BOARD_WINFAST_DTV1000:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		gpio = (gpio & 0x6ff) | ((cx_read(MO_GP1_IO) << 8) & 0x900);
 		auxgpio = gpio;
 		break;
@@ -236,6 +237,7 @@
 		ir->sampling = 1;
 		break;
 	case CX88_BOARD_WINFAST_DTV2000H:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		ir_codes = ir_codes_winfast;
 		ir->gpio_addr = MO_GP0_IO;
 		ir->mask_keycode = 0x8f8;
linux/drivers/media/video/cx88/cx88.h +1 -0
diff -r ee3b79edde3f linux/drivers/media/video/cx88/cx88.h
@@ -237,6 +237,7 @@
 #define CX88_BOARD_PROF_6200               78
 #define CX88_BOARD_TERRATEC_CINERGY_HT_PCI_MKII 79
 #define CX88_BOARD_HAUPPAUGE_IRONLY        80
+#define CX88_BOARD_WINFAST_DTV1800H        81
 
 enum cx88_itype {
 	CX88_VMUX_COMPOSITE1 = 1,
#5 lore raw

Hi Miroslav,

Am Donnerstag, den 28.05.2009, 18:44 +0000 schrieb Miroslav Šustek:

Quoted 6 lines

Any problem with this patch?
I'm trying to get WinFast DTV-1800H support into repository for seven months. (see:
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/1125/match=1800h
)

just saw this patch on another machine and it reminded me also on your patch to select different frontends on multiple multi frontends card at insmod, which can be quite useful and was tested by me.

They must pass the checks "patchwork" does, this includes to run "make checkpatch" on them previously and then you will see them very soon in

http://patchwork.kernel.org/project/linux-media/list

They seem not to be there, also not with filters "any" set, and you should have seen an automated commit message, if they should have made it into v4l-dvb.

Please resend and check short time later, if they are at patchwork linux-media.

Some sort of reject message would of course be fine on such and make life easier, but does not happen yet.

Cheers,
Hermann