Skip to contentSkip to conversation

bug fix: Null pointer may be used

PATCH In review Andy Yan 1 participant 1 message May 11, 2009 SCSI

lore
Share & tools
lore

Andy Yan

author
#0 lore raw

PATCH 3/5 bug fix: Null pointer may be used

Quoted 1 line

From d4529158b4e32d68b41a052c9b66de7243e0c4ce Mon Sep 17 00:00:00 2001

From: Andy Yan <[email protected]>
Date: Mon, 11 May 2009 21:49:52 +0800
Subject: [PATCH 3/5] bug fix: Null pointer may be used

Null pointer check to avoid corruption.

Signed-off-by Ying Chu <[email protected]>
Signed-off-by Andy Yan <[email protected]>
Signed-off-by Ke Wei <[email protected]>
---
 drivers/scsi/mvsas/mv_sas.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/mvsas/mv_sas.c +4 -4
index 4279b5e..3fc396f 100644
@@ -1873,11 +1873,11 @@ int mvs_slot_complete(struct mvs_info *mvi, u32 rx_desc, u32 flags)
 	}
 
 out:
-	if (mvi_dev)
+	if (mvi_dev) {
 		mvi_dev->runing_req--;
-	if (sas_protocol_ata(task->task_proto))
-		mvs_free_reg_set(mvi, mvi_dev);
-
+		if (sas_protocol_ata(task->task_proto))
+			mvs_free_reg_set(mvi, mvi_dev);
+	}
 	mvs_slot_task_free(mvi, task, slot, slot_idx);
 	sts = tstat->stat;
Signature · 1 line
1.6.2.1