scsi tape: fix gcc 4.4 warning

PATCH In review [email protected] 1 participant 1 message May 12, 2009

Subsystems (2)

SCSI SCSI tape driver

lore

Share & tools

lore

[email protected]

author

2009-05-12 21:40 UTC #0 lore raw

PATCH 9/9 scsi tape: fix gcc 4.4 warning

From: Kai Makisara <[email protected]>

This patch fixes the GCC 4.4 warning reported by David Binderman and Sergey Senozhatsky. The old version was working correctly but was not easy to read.

Signed-off-by Kai Makisara <[email protected]>

Cc Sergey Senozhatsky <[email protected]>

Cc James Bottomley <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/st.c renamed from drivers/scsi/st.c~scsi-tape-fix-gcc-44-warning +1 -1

diff -puN drivers/scsi/st.c~scsi-tape-fix-gcc-44-warning drivers/scsi/st.c
@@ -2964,7 +2964,7 @@ static int st_int_ioctl(struct scsi_tape
 			    !(STp->use_pf & PF_TESTED)) {
 				/* Try the other possible state of Page Format if not
 				   already tried */
-				STp->use_pf = !STp->use_pf | PF_TESTED;
+				STp->use_pf = (STp->use_pf ^ USE_PF) | PF_TESTED;
 				st_release_request(SRpnt);
 				SRpnt = NULL;
 				return st_int_ioctl(STp, cmd_in, arg);