Skip to contentSkip to conversation

PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()

PATCH Applied Alex Chiang 2 participants 2 messages May 19, 2009 – Jun 11, 2009 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()

We always call pci_stop_bus_device before calling pci_destroy_dev.

Since pci_stop_bus_device calls pci_stop_dev, there is no need for pci_destroy_dev to repeat the call.

---

 drivers/pci/remove.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/pci/remove.c +0 -2
index 86503c1..176615e 100644
@@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
 
 static void pci_destroy_dev(struct pci_dev *dev)
 {
-	pci_stop_dev(dev);
-
 	/* Remove the device from the device lists, and prevent any further
 	 * list accesses from this device */
 	down_write(&pci_bus_sem);
Applied
#1 lore raw
Quoted 23 lines · On Mon, 18 May 2009 19:02:38 -0600 Alex Chiang <[email protected]> wrote:

We always call pci_stop_bus_device before calling pci_destroy_dev.

Since pci_stop_bus_device calls pci_stop_dev, there is no need for pci_destroy_dev to repeat the call.

---

 drivers/pci/remove.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/pci/remove.c +0 -2
index 86503c1..176615e 100644
@@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
 
 static void pci_destroy_dev(struct pci_dev *dev)
 {
-	pci_stop_dev(dev);
-
 	/* Remove the device from the device lists, and prevent any

further

drivers/pci/remove.c static void pci_stop_dev(struct pci_dev *dev) · line 37

Quoted 2 lines
drivers/pci/remove.c +0 -0
 	 * list accesses from this device */
 	down_write(&pci_bus_sem);

Applied to linux-next, thanks.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center