Skip to contentSkip to conversation

tcp vegas ssthresh bugfix

DISCUSSION David Miller 1 participant 1 message May 19, 2009 1 message not in the archive

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20090519092207.GA31493@scriptng

David Miller

author maintainer
#1 lore raw

From: Douglas Leith <[email protected]>
Date: Tue, 19 May 2009 10:22:07 +0100

Quoted 4 lines

This patch fixes a minor bug in tcp_vegas.c which affects ssthresh accounting when vegas congestion control decreases snd_cwnd.

Signed-off-by Doug Leith <[email protected]>

This patch has several problems:

ipv4/tcp_vegas.c

Quoted 2 lines
ipv4/tcp_vegas.c renamed from ipv4/tcp_vegas.c.orig +0 -0

The patch should be "-p1" based, one directory higher up. You have it "-p0" based.

ipv4/tcp_vegas.c

Quoted 2 lines
ipv4/tcp_vegas.c renamed from ipv4/tcp_vegas.c.orig +2 -0
+					/* Update ssthresh to reflect
+					 * decreased cwnd */

This is not the correct way to format a comment in the Linux kernel, the correct layout is:

/* Update ssthresh to reflect
* decreased cwnd.
*/

Please fix these problems up and resubmit.