Skip to contentSkip to conversation

xentrace: install formats file

PATCH In review Christoph Egger 2 participants 3 messages May 19, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xentrace: install formats file

Hi,

Attached patch installs the formats file needed for xentrace_format.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
tools/xentrace/Makefile +1 -0
diff -r 780041c4a96d tools/xentrace/Makefile
@@ -43,6 +43,7 @@ install: build
 	[ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(PRIVATE_BINDIR)
 	$(INSTALL_DATA) $(MAN1) $(DESTDIR)$(MAN1DIR)
 	$(INSTALL_DATA) $(MAN8) $(DESTDIR)$(MAN8DIR)
+	$(INSTALL_DATA) formats $(DESTDIR)$(XEN_CONFIG_DIR)
 
 .PHONY: clean
 clean:

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

Should be installed to a better filename (e.g., xentrace_formats) -- the name of the file in the source tree doesn't have to change though -- and also xentrace_format should go look in the default place if it is not passed a def_files argument on the command line. Perhaps you can use/extend auxbin.py to avoid hardcoding the config-dir path into xentrace_formats.

-- Keir

Quoted 7 lines · Christoph Egger

Hi,

Attached patch installs the formats file needed for xentrace_format.

#2 lore raw

I have a patch almost ready to get rid of hardcoded config dir paths in general. It removes the script_dir in osdep.py completely.
I am about doing the interaction with ioemu, so that qemu-ifup is installed properly.
I will submit the patch when this is done.

Christoph

Quoted 15 lines · On Tuesday 19 May 2009 14:43:16 Keir Fraser wrote:

Should be installed to a better filename (e.g., xentrace_formats) -- the name of the file in the source tree doesn't have to change though -- and also xentrace_format should go look in the default place if it is not passed a def_files argument on the command line. Perhaps you can use/extend auxbin.py to avoid hardcoding the config-dir path into xentrace_formats.

-- Keir

Quoted 6 lines · Christoph Egger

Hi,

Attached patch installs the formats file needed for xentrace_format.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632