Skip to contentSkip to conversation

mpt fusion: [2.6.30-rc6] Deleted functions for Firmware event implementation using seperate WQ

PATCH In review Kashyap, Desai 2 participants 2 messages May 22, 2009 – May 27, 2009

Subsystems (2)
SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Kashyap, Desai

author
#0 lore raw

PATCH 14/24 mpt fusion: [2.6.30-rc6] Deleted functions for Firmware event implementation using seperate WQ

Fuctions which are not used are removed by this patch.
---

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/message/fusion/mptsas.c +0 -24
index 10abd62..29a8fe2 100644
@@ -3035,30 +3035,6 @@ mptsas_find_phyinfo_by_sas_address(MPT_ADAPTER *ioc, u64 sas_address)
 	return phy_info;
 }
 
-static struct mptsas_phyinfo *
-mptsas_find_phyinfo_by_target(MPT_ADAPTER *ioc, u8 channel, u8 id)
-{
-	struct mptsas_portinfo *port_info;
-	struct mptsas_phyinfo *phy_info = NULL;
-	int i;
-
-	mutex_lock(&ioc->sas_topology_mutex);
-	list_for_each_entry(port_info, &ioc->sas_topology, list) {
-		for (i = 0; i < port_info->num_phys; i++) {
-			if (!mptsas_is_end_device(
-				&port_info->phy_info[i].attached))
-				continue;
-			if (port_info->phy_info[i].attached.id != id)
-				continue;
-			if (port_info->phy_info[i].attached.channel != channel)
-				continue;
-			phy_info = &port_info->phy_info[i];
-			break;
-		}
-	}
-	mutex_unlock(&ioc->sas_topology_mutex);
-	return phy_info;
-}
 
 static struct mptsas_phyinfo *
 mptsas_find_phyinfo_by_phys_disk_num(MPT_ADAPTER *ioc, u8 channel, u8 id)
maintainer
#1 lore raw
Quoted 10 lines · Desai

Fuctions which are not used are removed by this patch.
---

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/message/fusion/mptsas.c +0 -0
index 10abd62..29a8fe2 100644

drivers/message/fusion/mptsas.c mptsas_find_phyinfo_by_sas_address(MPT_ADAPTER *ioc, u64 sas_address) · line 3039

Quoted 5 lines
drivers/message/fusion/mptsas.c +0 -2
@@ -3035,30 +3035,6 @@ mptsas_find_phyinfo_by_sas_address(MPT_ADAPTER *ioc, u64 sas_address)
 	return phy_info;
 }
 
-static struct mptsas_phyinfo *
-mptsas_find_phyinfo_by_target(MPT_ADAPTER *ioc, u8 channel, u8 id)

Please combine this with the patch that actually removes the last use otherwise, for all static functions, gcc is going to warn about defined but unused functions.

The 10 lines you save by separating this aren't really significant given that some of the other patches are up to a thousand lines.

James