Skip to contentSkip to conversation

scheduler: introduce SCHED_RESET_ON_FORK scheduling policy flag

PATCH In review Lennart Poettering 1 participant 2 messages May 28, 2009 Scheduler

lore
Share & tools
lore
#1 lore raw
In reply to Lennart Poettering

On Thu, 28.05.09 16:09, Lennart Poettering ([email protected]) wrote:

Please ignore the 3/3 in the subject of the original patch. It's just this one patch. Sorry for the confusion.

Quoted 5 lines

This patch introduces a new flag SCHED_RESET_ON_FORK which can be passed to the kernel via sched_setscheduler(), ORed in the policy parameter. If set this will make sure that when the process forks a) the scheduling priority is reset to DEFAULT_PRIO if it was higher and b) the scheduling policy is reset to SCHED_NORMAL if it was either SCHED_FIFO or SCHED_RR.

Lennart

Signature · 3 lines
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4
#0 lore raw

PATCH 3/3 scheduler: introduce SCHED_RESET_ON_FORK scheduling policy flag

This patch introduces a new flag SCHED_RESET_ON_FORK which can be passed to the kernel via sched_setscheduler(), ORed in the policy parameter. If set this will make sure that when the process forks a) the scheduling priority is reset to DEFAULT_PRIO if it was higher and b) the scheduling policy is reset to SCHED_NORMAL if it was either SCHED_FIFO or SCHED_RR.

Why have this?

Currently, if a process is real-time scheduled this will 'leak' to all its child processes. For security reasons it is often (always?) a good idea to make sure that if a process acquires RT scheduling this is confined to this process and only this process. More specifically this makes the per-process resource limit RLIMIT_RTTIME useful for security purposes, because it makes it impossible to use a fork bomb to circumvent the per-process RLIMIT_RTTIME accounting.

This feature is also useful for tools like 'renice' which can then change the nice level of a process without having this spill to all its child processes.

Why expose this via sched_setscheduler() and not other syscalls such as prctl() or sched_setparam()?

prctl() does not take a pid parameter. Due to that it would be impossible to modify this flag for other processes than the current one.

The struct passed to sched_setparam() can unfortunately not be extended without breaking compatibility, since sched_setparam() lacks a size parameter.

How to use this from userspace? In your RT program simply replace this:

  sched_setscheduler(pid, SCHED_FIFO, &param);

by this:

  sched_setscheduler(pid, SCHED_FIFO|SCHED_RESET_ON_FORK, &param);

This current patch compiles but is not otherwise tested. For now, I am sending this primarily as a request for comments. So please, I'd love to hear your comments!

Lennart

---
 include/linux/sched.h |    4 ++++
 kernel/sched.c        |   43 ++++++++++++++++++++++++++++++++++---------
 2 files changed, 38 insertions(+), 9 deletions(-)
include/linux/sched.h +4 -0
index b4c38bc..c28c81b 100644
@@ -38,6 +38,8 @@
 #define SCHED_BATCH		3
 /* SCHED_ISO: reserved but not implemented yet */
 #define SCHED_IDLE		5
+/* Can be ORed in to make sure the process is reverted back to SCHED_NORMAL on fork */
+#define SCHED_RESET_ON_FORK     0x40000000
 
 #ifdef __KERNEL__
 
@@ -1429,6 +1431,8 @@ struct task_struct {
 	/* state flags for use by tracers */
 	unsigned long trace;
 #endif
+	/* Revert to default priority/policy when forking */
+	int sched_reset_on_fork;
 };
 
 /* Future-safe accessor for struct task_struct's cpus_allowed. */
kernel/sched.c +34 -9

86 lines not on this page · raw message

Signature · 10 lines
1.6.2.2



Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4