Skip to contentSkip to conversation

xfstests: fix for bash 3.2

PATCH In review Christoph Hellwig 2 participants 2 messages Jun 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: fix for bash 3.2

Bash 3.2 wants a space before the closing "]" in a test:

check +1 -1
Index: xfstests-dev/check
===================================================================
@@ -160,7 +160,7 @@
 
 EOF
 
-if [ ! -z "$SCRATCH_DEV"]; then
+if [ ! -z "$SCRATCH_DEV" ]; then
   umount $SCRATCH_DEV 2>/dev/null
   # call the overridden mkfs - make sure the FS is built
   # the same as we'll create it later.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christoph Hellwig

Bash 3.2 wants a space before the closing "]" in a test:

Quoted 16 lines

Index: xfstests-dev/check
===================================================================

check +0 -0
@@ -160,7 +160,7 @@
 

EOF

check +1 -1
-if [ ! -z "$SCRATCH_DEV"]; then
+if [ ! -z "$SCRATCH_DEV" ]; then
  umount $SCRATCH_DEV 2>/dev/null
  # call the overridden mkfs - make sure the FS is built
  # the same as we'll create it later.
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs