Skip to contentSkip to conversation

Fix page_mkwrite() for blocksize < pagesize

Review request Jan Kara 2 participants 3 messages Jun 5, 2009 – Jun 15, 2009 VFS

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

Hi,

could someone have a look at a patch set I've posted a week or so ago
to LKML. It starts at:
http://lkml.org/lkml/2009/5/27/317
Mainly, what I'd like to get opinions on is the third patch implementing
VFS helpers for easier handling of page_mkwrite() when blocksize < pagesize. I'd like to get the patchset merged but before that I'd like to get an agreement of people here that this is the way we want to go... Thanks a lot for review in advance.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#1 lore raw
Quoted 10 lines · Jan Kara

Hi,

could someone have a look at a patch set I've posted a week or so ago
to LKML. It starts at:
http://lkml.org/lkml/2009/5/27/317
Mainly, what I'd like to get opinions on is the third patch implementing
VFS helpers for easier handling of page_mkwrite() when blocksize < pagesize. I'd like to get the patchset merged but before that I'd like to get an agreement of people here that this is the way we want to go... Thanks a lot for review in advance.

Maybe you should repost these patches in hopes of getting someone to review them?

We have a number of ext4 patches stack up behind this patchset, and these patches fix some filesystem corruption problems when the filesystem blocksize is less than the pagesize (which will be quite common on the ppc and ia64 platforms), so I'd very much like to get this patch series merged during the current merge window.

Thanks,

- Ted

author reviewer
#2 lore raw

Hi,

Quoted 12 lines · Theodore Tso
Quoted 10 lines · Jan Kara

Hi,

could someone have a look at a patch set I've posted a week or so ago
to LKML. It starts at:
http://lkml.org/lkml/2009/5/27/317
Mainly, what I'd like to get opinions on is the third patch implementing
VFS helpers for easier handling of page_mkwrite() when blocksize < pagesize. I'd like to get the patchset merged but before that I'd like to get an agreement of people here that this is the way we want to go... Thanks a lot for review in advance.

Quoted 8 lines

Maybe you should repost these patches in hopes of getting someone to review them?

We have a number of ext4 patches stack up behind this patchset, and these patches fix some filesystem corruption problems when the filesystem blocksize is less than the pagesize (which will be quite common on the ppc and ia64 platforms), so I'd very much like to get this patch series merged during the current merge window.

Yes, I've resent the series together with one fix in ext3 part of the
patchset. Hopefully someone responds.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR