x86/x86_64: warn of -EBUSY returns from __assign_irq_vector()
PATCH 1/1 x86/x86_64: warn of -EBUSY returns from __assign_irq_vector()
Impact: helps expose unexpected issues
Since we have seen one case where an unexpected -EBUSY return from __assign_irq_vector() was included in the series of events that caused a serious problem
re: http://lkml.org/lkml/2009/6/2/377
we should warn to help expose similar unexpected issues in the future.
--- arch/x86/kernel/apic/io_apic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +3 -1
@@ -1330,8 +1330,10 @@ __assign_irq_vector(int irq, struct irq_int cpu, err;cpumask_var_t tmp_mask; -if ((cfg->move_in_progress) || cfg->move_cleanup_count) +if ((cfg->move_in_progress) || cfg->move_cleanup_count) { +WARN_ON_ONCE (1 );return -EBUSY ; + }if (!alloc_cpumask_var (&tmp_mask,GFP_ATOMIC ))return -ENOMEM ;
Quoted 10 lines · Gary Hade
Impact: helps expose unexpected issues
Since we have seen one case where an unexpected
-EBUSYreturn from__assign_irq_vector()was included in the series of events that caused a serious problem
re: http://lkml.org/lkml/2009/6/2/377
we should warn to help expose similar unexpected issues in the future.Signed-off-by Gary Hade <[email protected]>
Gary again can you make the case that this is not a problem with fixup_irqs?
Changing the rest of the code to match the always broken assumptions in fixup_irqs is the tail wagging the dog.
Eric