dell-wmi: don't generate errors on empty messages

PATCH Applied [email protected] 1 participant 1 message Jun 10, 2009

Subsystems (2)

ACPI x86 platform drivers

lore

Share & tools

lore

[email protected]

author

2009-06-10 19:42 UTC #0 lore raw

PATCH 3/4 dell-wmi: don't generate errors on empty messages

From: Matthew Garrett <[email protected]>

There's no point in generating kernel messages if we didn't receive a parsable keyboard event - only do so if there appeared to be a scancode.

Signed-off-by Matthew Garrett <[email protected]>

Cc Len Brown <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/dell-wmi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/platform/x86/dell-wmi.c renamed from drivers/platform/x86/dell-wmi.c~dell-wmi-dont-generate-errors-on-empty-messages +2 -2

diff -puN drivers/platform/x86/dell-wmi.c~dell-wmi-dont-generate-errors-on-empty-messages drivers/platform/x86/dell-wmi.c
@@ -176,9 +176,9 @@ static void dell_wmi_notify(u32 value, v
 			input_sync(dell_wmi_input_dev);
 			input_report_key(dell_wmi_input_dev, key->keycode, 0);
 			input_sync(dell_wmi_input_dev);
-		} else
+		} else if (buffer[1] & 0xFFFF)
 			printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n",
-			       buffer[1]);
+			       buffer[1] & 0xFFFF);
 	}
 }