tvp514x: try_count off by one

PATCH In review [email protected] 1 participant 1 message Jun 10, 2009 Media (V4L/DVB)

lore

Share & tools

lore

[email protected]

author

2009-06-10 19:44 UTC #0 lore raw

PATCH 6/6 tvp514x: try_count off by one

From: Roel Kluin <[email protected]>

With `while (try_count-- > 0)' try_count reaches -1 after the loop.

Signed-off-by Roel Kluin <[email protected]>

Cc Mauro Carvalho Chehab <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/media/video/tvp514x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/video/tvp514x.c renamed from drivers/media/video/tvp514x.c~tvp514x-try_count-off-by-one +1 -1

diff -puN drivers/media/video/tvp514x.c~tvp514x-try_count-off-by-one drivers/media/video/tvp514x.c
@@ -692,7 +692,7 @@ static int ioctl_s_routing(struct v4l2_i
 			break;	/* Input detected */
 	}
 
-	if ((current_std == STD_INVALID) || (try_count <= 0))
+	if ((current_std == STD_INVALID) || (try_count < 0))
 		return -EINVAL;
 
 	decoder->current_std = current_std;