Skip to contentSkip to conversation

partitions: fix broken uevent_suppress conversion

PATCH In review Heiko Carstens 2 participants 2 messages Jun 11, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 partitions: fix broken uevent_suppress conversion

From: Heiko Carstens <[email protected]>

git commit f67f129e "Driver core: implement uevent suppress in kobject" contains this chunk for fs/partitions/check.c:

/* suppress uevent if the disk supresses it */
- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(pdev))
kobject_uevent(&pdev->kobj, KOBJ_ADD);

However that should have been

- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(ddev))

---
 fs/partitions/check.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/partitions/check.c +1 -1
Index: linux-2.6/fs/partitions/check.c
===================================================================
@@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
 	rcu_assign_pointer(ptbl->part[partno], p);
 
 	/* suppress uevent if the disk supresses it */
-	if (!dev_get_uevent_suppress(pdev))
+	if (!dev_get_uevent_suppress(ddev))
 		kobject_uevent(&pdev->kobj, KOBJ_ADD);
 
 	return p;
Acked-by on v1 1/1
#1 lore raw

2009/6/11 Heiko Carstens <[email protected]>:

Quoted 27 lines

From: Heiko Carstens <[email protected]>

git commit f67f129e "Driver core: implement uevent suppress in kobject" contains this chunk for fs/partitions/check.c:

       /* suppress uevent if the disk supresses it */
-       if (!ddev->uevent_suppress)
+       if (!dev_get_uevent_suppress(pdev)) kobject_uevent(&pdev->kobj, KOBJ_ADD);

However that should have been

-       if (!ddev->uevent_suppress)
+       if (!dev_get_uevent_suppress(ddev))

---
 fs/partitions/check.c |    2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/fs/partitions/check.c
===================================================================

fs/partitions/check.c struct hd_struct *add_partition(struct g · line 432

Quoted 8 lines
fs/partitions/check.c +1 -1
@@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
        rcu_assign_pointer(ptbl->part[partno], p);
 
        /* suppress uevent if the disk supresses it */
-       if (!dev_get_uevent_suppress(pdev))
+       if (!dev_get_uevent_suppress(ddev))
                kobject_uevent(&pdev->kobj, KOBJ_ADD);
 
        return p;

Thanks.

Signature · 1 line
Lei Ming