Skip to contentSkip to conversation

iwlwifi: show qos AC parameters

DISCUSSION Arjan van de Ven 3 participants 4 messages Jun 21, 2009 – Jun 22, 2009 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Review

Quoted 11 lines · On Mon, 15 Jun 2009 21:14:13 GMT Linux Kernel Mailing List…
(quoted diff) +2 -0
+static ssize_t show_qos(struct device *d,
+				struct device_attribute *attr, char

*buf) +{

(quoted diff) +8 -0
+	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
+	char *p = buf;
+	int   q;
+
+	for (q = 0; q < AC_NUM; q++) {
+		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
+		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
+

wonder what happened to the "one value per file" sysfs rule...

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#2 lore raw
Quoted 16 lines · Arjan van de Ven

Review

Quoted 11 lines · On Mon, 15 Jun 2009 21:14:13 GMT Linux Kernel Mailing List…
(quoted diff) +2 -0
+static ssize_t show_qos(struct device *d,
+				struct device_attribute *attr, char

*buf) +{

(quoted diff) +8 -0
+	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
+	char *p = buf;
+	int   q;
+
+	for (q = 0; q < AC_NUM; q++) {
+		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
+		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
+

wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h

#3 lore raw

Oh ok.
I will submit the patch to fix this.

Wey-Yi Guy
Intel Corporation
2111 N.E. 25th Avenue M/S JF3-308 Hillsboro OR 97124-5961
USA
Work Phone: 503-264-6023 (OR)
Cell Phone: 503-329-8410
Email: [email protected]

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Sunday, June 21, 2009 7:49 PM
To: Arjan van de Ven
Cc: Linux Kernel Mailing List; Guy, Wey-Yi W
Subject: Re: iwlwifi: show qos AC parameters

Quoted 16 lines · Arjan van de Ven

Review

Quoted 11 lines · On Mon, 15 Jun 2009 21:14:13 GMT Linux Kernel Mailing List…
(quoted diff) +2 -0
+static ssize_t show_qos(struct device *d,
+				struct device_attribute *attr, char

*buf) +{

(quoted diff) +8 -0
+	struct iwl_priv *priv = (struct iwl_priv *)d->driver_data;
+	char *p = buf;
+	int   q;
+
+	for (q = 0; q < AC_NUM; q++) {
+		p += sprintf(p, "\tcw_min\tcw_max\taifsn\ttxop\n");
+		p += sprintf(p, "AC[%d]\t%u\t%u\t%u\t%u\n", q,
+

wonder what happened to the "one value per file" sysfs rule...

Oh ick.

Thanks Arjan for the pointer.

Who's responsible for this file, and when is it going to be changed?

thanks,

greg k-h

#4 lore raw
Quoted 2 lines · Wey-Yi W

Oh ok.
I will submit the patch to fix this.

Also, all new sysfs files need an entry in Documentation/ABI/.

thanks,

greg k-h