fix Pstate growing in OSLEC
PATCH 1/1 fix Pstate growing in OSLEC
The following fix has been posted in the OSLEC mailing list by Ruslan Cray (and shortly afterwards acepted into the OSLEC SVN tree). Sadly it has not been forwarded the kernel.org tree until now.
See:
As a side note, the OSLEC code is gathering dust in the staging tree. As-is it is mostly useless without providing an interface for its code. I was hoping to see the mISDN code starting to use it but so far no change in that front.
--- drivers/staging/echo/echo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/echo/echo.c +1 -1
@@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx) old = (int )ec->fir_state.history[ec->fir_state.curr_pos] * (int )ec->fir_state.history[ec->fir_state.curr_pos]; ec->Pstates += - ((new - old) + (1 << ec->log2taps)) >> ec->log2taps; + ((new - old) + (1 << (ec->log2taps -1 ))) >> ec->log2taps;if (ec->Pstates <0 ) ec->Pstates =0 ; }
Signature · 8 lines
1.5.6.5
--
Tzafrir Cohen
icq#16849755 jabber:[email protected]
+972-50-7952406 mailto:[email protected]
http://www.xorcom.com iax:[email protected]/tzafrirHi Tzafrir,
I submitted the patch to Greg a few weeks ago (as well as checking it into Oslec SVN).
Re gathering dust, on the contrary I understand that many people are using Oslec from the kernel staging directory with the Asterisk DAHDI interface.
Cheers,
David
Quoted 34 lines · Tzafrir Cohen
The following fix has been posted in the OSLEC mailing list by Ruslan Cray (and shortly afterwards acepted into the OSLEC SVN tree). Sadly it has not been forwarded the kernel.org tree until now.
See:
As a side note, the OSLEC code is gathering dust in the staging tree. As-is it is mostly useless without providing an interface for its code. I was hoping to see the mISDN code starting to use it but so far no change in that front.
--- drivers/staging/echo/echo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/staging/echo/echo.c +1
-1@@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx) old = (int )ec->fir_state.history[ec->fir_state.curr_pos] * (int )ec->fir_state.history[ec->fir_state.curr_pos]; ec->Pstates += - ((new - old) + (1 << ec->log2taps)) >> ec->log2taps; + ((new - old) + (1 << (ec->log2taps -1 ))) >> ec->log2taps;if (ec->Pstates <0 ) ec->Pstates =0 ; }Signature · 1 line
1.5.6.5
Signature · 3 lines
Free Telephony Project open embedded IP-PBX hardware and software http://www.rowetel.com/ucasterisk
Quoted 3 lines · David Rowe
Re gathering dust, on the contrary I understand that many people are using Oslec from the kernel staging directory with the Asterisk DAHDI interface.
... and thus creating interesting artifacts such as:
http://svn.asterisk.org/svn/dahdi/linux/trunk/drivers/dahdi/dahdi_echocan_oslec.c
http://svn.asterisk.org/svn/dahdi/linux/trunk/drivers/dahdi/Kbuild
https://issues.asterisk.org/view.php?id=15251
Note the line '#include "../staging/echo/oslec.h"
Signature · 4 lines
Tzafrir Cohen icq#16849755 jabber:[email protected] +972-50-7952406 mailto:[email protected] http://www.xorcom.com iax:[email protected]/tzafrir