Skip to contentSkip to conversation

powerpc/85xx: Make eSDHC 1-bit only transfer mode default for MPC8569E-MDS

PATCH Applied Anton Vorontsov 2 participants 5 messages Jun 18, 2009 – Jun 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/85xx: Make eSDHC 1-bit only transfer mode default for MPC8569E-MDS

For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots.

---
 arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8569mds.dts +1 -0
index 39c2927..63e8109 100644
@@ -229,6 +229,7 @@
 			/* Filled in by U-Boot */
 			clock-frequency = <0>;
 			status = "disabled";
+			sdhci,1-bit-only;
 		};
 
 		crypto@30000 {
Signature · 1 line
1.6.3.1
#1 lore raw
Quoted 9 lines · Anton Vorontsov

For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots.

---
arch/powerpc/boot/dts/mpc8569mds.dts | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)

Did I miss the patch that adds this property defn. to our docs?

- k

#2 lore raw
Quoted 8 lines · Kumar Gala
Quoted 5 lines · Anton Vorontsov

For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots.

Quoted 6 lines
Quoted 4 lines

---
arch/powerpc/boot/dts/mpc8569mds.dts | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)

Did I miss the patch that adds this property defn. to our docs?

Yep. ;-)

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-June/073394.html

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
#3 lore raw
Quoted 14 lines · Anton Vorontsov
Quoted 13 lines · Kumar Gala
Quoted 9 lines · Anton Vorontsov

For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots.

---
arch/powerpc/boot/dts/mpc8569mds.dts | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 5 lines
Quoted 1 line

Did I miss the patch that adds this property defn. to our docs?

Yep. ;-)

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-June/073394.html

Ok. I'll wait for Pierre to ack or pick up that patch before pulling in the .dts change.

- k

Applied
#4 lore raw
In reply to Anton Vorontsov
Quoted 9 lines · Anton Vorontsov

For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards, so make 1-bit mode default. When we resolve the issue, u-boot will remove sdhci,1-bit-only property from the device tree, while SDHCI will still work with older u-boots.

---
arch/powerpc/boot/dts/mpc8569mds.dts | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)

applied to next

- k