Skip to contentSkip to conversation

usbnet cdc_subset: fix issues talking to PXA gadgets

PATCH Superseded David Brownell 2 participants 6 messages Jun 19, 2009 – Jun 20, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usbnet cdc_subset: fix issues talking to PXA gadgets

From: David Brownell <[email protected]>

The host-side CDC subset driver is binding more specifically than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Loosen that restriction to match the gadget driver itself. This helps various PXA 27x and PXA 3xx devices be happier when talking to Linux hosts; and a few other gadgets too.

---
Appropriate for -stable ... behaves like a protocol bug.

 drivers/net/usb/cdc_subset.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/usb/cdc_subset.c +4 -3
@@ -307,9 +307,10 @@ static const struct usb_device_id	produc
 	USB_DEVICE (0x1286, 0x8001),    // "blob" bootloader
 	.driver_info =  (unsigned long) &blob_info,
 }, {
-	// Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
-	// e.g. Gumstix, current OpenZaurus, ...
-	USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
+	// Linux Ethernet/RNDIS gadget, mostly on PXA, second config
+	// e.g. Gumstix, current OpenZaurus, ... or anything else
+	// that just enables this gadget option.
+	USB_DEVICE_VER (0x0525, 0xa4a2),
 	.driver_info =	(unsigned long) &linuxdev_info,
 },
 #endif
maintainer
#1 lore raw

From: David Brownell <[email protected]>
Date: Fri, 19 Jun 2009 00:11:28 -0700

Quoted 5 lines

From: David Brownell <[email protected]>

The host-side CDC subset driver is binding more specifically than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Quoted 8 lines

Loosen that restriction to match the gadget driver itself. This helps various PXA 27x and PXA 3xx devices be happier when talking to Linux hosts; and a few other gadgets too.

---
Appropriate for -stable ... behaves like a protocol bug.

Applied and queued up for -stable.

maintainer
#2 lore raw

From: David Miller <[email protected]>
Date: Fri, 19 Jun 2009 00:24:03 -0700 (PDT)

Quoted 12 lines

From: David Brownell <[email protected]>
Date: Fri, 19 Jun 2009 00:11:28 -0700

Quoted 9 lines

From: David Brownell <[email protected]>

The host-side CDC subset driver is binding more specifically than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Loosen that restriction to match the gadget driver itself. This helps various PXA 27x and PXA 3xx devices be happier when talking to Linux hosts; and a few other gadgets too.

Quoted 6 lines
Quoted 4 lines

---
Appropriate for -stable ... behaves like a protocol bug.

Applied and queued up for -stable.

David this doesn't even compile:

CC [M] drivers/net/usb/cdc_subset.o
drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function)

There is absolutely no excuse for this, really.

#4 lore raw

PATCH v2 1/1 usbnet cdc_subset: fix issues talking to PXA gadgets

In reply to David Brownell

From: David Brownell <[email protected]>

The host-side CDC subset driver is binding more specifically than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Loosen that restriction to match the gadget driver driver. This will various PXA 27x and PXA 3xx devices happier when talking to Linux hosts, potentially others.

---
Updated: typo fixed.

 drivers/net/usb/cdc_subset.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/usb/cdc_subset.c +4 -3
@@ -307,9 +307,10 @@ static const struct usb_device_id	produc
 	USB_DEVICE (0x1286, 0x8001),    // "blob" bootloader
 	.driver_info =  (unsigned long) &blob_info,
 }, {
-	// Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
-	// e.g. Gumstix, current OpenZaurus, ...
-	USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
+	// Linux Ethernet/RNDIS gadget, mostly on PXA, second config
+	// e.g. Gumstix, current OpenZaurus, ... or anything else
+	// that just enables this gadget option.
+	USB_DEVICE (0x0525, 0xa4a2),
 	.driver_info =	(unsigned long) &linuxdev_info,
 },
 #endif
#3 lore raw
In reply to David Miller
Quoted 1 line · David Miller

David this doesn't even compile:

Sorry, my bad. Fixed in the followup.

Quoted 5 lines

  CC [M]  drivers/net/usb/cdc_subset.o
drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function)

There is absolutely no excuse for this, really.

Sure there is: sent it out too soon, before the compile test!

maintainer Applied
#5 lore raw
In reply to David Brownell

From: David Brownell <[email protected]>
Date: Fri, 19 Jun 2009 03:10:03 -0700

Quoted 11 lines

From: David Brownell <[email protected]>

The host-side CDC subset driver is binding more specifically than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Loosen that restriction to match the gadget driver driver. This will various PXA 27x and PXA 3xx devices happier when talking to Linux hosts, potentially others.

Applied.