Skip to contentSkip to conversation

cr: define CKPT_ARCH_NSIG for s390x

PATCH In review Serge E. Hallyn 2 participants 3 messages Jun 25, 2009 – Jun 26, 2009 2 messages not in the archive s390

lore
Share & tools
lore

Serge E. Hallyn

author
#0 lore raw

PATCH 1/1 cr: define CKPT_ARCH_NSIG for s390x

Else compilation fails on s390x.

Signed-off-by Serge E. Hallyn <serue-r/[email protected]>
---
 arch/s390/include/asm/checkpoint_hdr.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/s390/include/asm/checkpoint_hdr.h +2 -0
index fc0ace8..a5aaa3e 100644
@@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context {
 	unsigned long asce_limit;
 };
 
+#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG
+
 struct ckpt_hdr_header_arch {
 	struct ckpt_hdr h;
 };
Signature · 1 line
1.6.1

A message that is not in the archive (sent off-list or not yet received): 20090625184847.GA11510-r/[email protected]

#2 lore raw
Quoted 12 lines · Serge E. Hallyn

Else compilation fails on s390x.

Signed-off-by Serge E. Hallyn <serue-r/[email protected]>
---
 arch/s390/include/asm/checkpoint_hdr.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/s390/include/asm/checkpoint_hdr.h +0 -0
index fc0ace8..a5aaa3e 100644

arch/s390/include/asm/checkpoint_hdr.h struct ckpt_hdr_mm_context { · line 83

Quoted 5 lines
arch/s390/include/asm/checkpoint_hdr.h +2 -0
@@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context {
 	unsigned long asce_limit;
 };
 
+#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG
+

But _SIGCONTEXT_NSIG is defined within #ifdef __KERNEL__ ?

Oren.

Quoted 3 lines
arch/s390/include/asm/checkpoint_hdr.h +0 -0
 struct ckpt_hdr_header_arch {
 	struct ckpt_hdr h;
 };

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw
Quoted 18 lines · Oren Laadan
Quoted 15 lines · Serge E. Hallyn

Else compilation fails on s390x.

Signed-off-by Serge E. Hallyn <serue-r/[email protected]>
---
 arch/s390/include/asm/checkpoint_hdr.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/s390/include/asm/checkpoint_hdr.h +0 -0
index fc0ace8..a5aaa3e 100644
@@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context {
 	unsigned long asce_limit;
 };
Quoted 4 lines

arch/s390/include/asm/checkpoint_hdr.h struct ckpt_hdr_mm_context { · line 83

Quoted 2 lines
arch/s390/include/asm/checkpoint_hdr.h +2 -0
+#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG
+

But _SIGCONTEXT_NSIG is defined within #ifdef __KERNEL__ ?

hmm? hmm. right, indirectly, failed to notice that...

Well I don't really like to just hard define it to 64 especially without leaving a note at the sigcontext.h NSIG defines...

Should we define both it and the x86 version in <asm/signal.h> not under #ifdef __KERNEL__?

-serge