Skip to contentSkip to conversation

Kirkwood: add Marvell Kirkwood gpio driver

U-Boot Dieter Kiermaier 4 participants 10 messages Jun 29, 2009 – Jul 22, 2009

lore
Share & tools
lore
#0 lore raw

Hi again,

Here is my first out of 2 patches which adds gpio support to arch/kirkwood. Any suggestions?

Cheers,
Dieter

#5 lore raw

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug. Any comments are welcome!

Dieter

#1 lore raw
In reply to Dieter Kiermaier
Quoted 9 lines · Dieter Kiermaier

Hi again,

Here is my first out of 2 patches which adds gpio support to arch/kirkwood. Any suggestions?

Cheers,
Dieter

Quoted 7 lines
Quoted 1 line

From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:22:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver

looks fine
Prafulla & nico for you?

Best Regards,
J.

#6 lore raw

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

In reply to Dieter Kiermaier
Quoted 37 lines · Dieter Kiermaier

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug. Any comments are welcome!

Dieter

Quoted 1 line

From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:29:15 +0200
Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

---
 board/Marvell/sheevaplug/sheevaplug.c |    1 +
 include/configs/sheevaplug.h          |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
board/Marvell/sheevaplug/sheevaplug.c +1 -0
index 547126a..fa28fea 100644
@@ -26,6 +26,7 @@
 #include <miiphy.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
+#include <asm/arch/gpio.h>
 #include "sheevaplug.h"
 
 DECLARE_GLOBAL_DATA_PTR;
include/configs/sheevaplug.h +0 -0
index e62353c..7455c29 100644

include/configs/sheevaplug.h line 48

Quoted 6 lines
include/configs/sheevaplug.h +1 -0
@@ -43,6 +43,7 @@
 #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
 #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
 #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
+#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
 #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
 #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */

why do you need it??

Best Regards,
J.

Tested-by
#2 lore raw
In reply to Jean-Christophe PLAGNIOL-VILLARD

Hello Jean-Christophe,

Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 10 lines · Dieter Kiermaier

Hi again,

Here is my first out of 2 patches which adds gpio support to arch/kirkwood. Any suggestions?

Cheers,
Dieter

Quoted 1 line

From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001

Quoted 8 lines
Quoted 6 lines

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:22:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver

looks fine
Prafulla & nico for you?

I actually tested this driver on the suen3 board with the i2c bitbang driver and it works fine :-), so I do a:

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#7 lore raw

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

In reply to Jean-Christophe PLAGNIOL-VILLARD

Jean,

Quoted 32 lines · Dieter Kiermaier
Quoted 31 lines

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug. Any comments are welcome!

Dieter

Quoted 1 line

From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:29:15 +0200
Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

---
 board/Marvell/sheevaplug/sheevaplug.c |    1 +
 include/configs/sheevaplug.h          |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
board/Marvell/sheevaplug/sheevaplug.c +1 -0
index 547126a..fa28fea 100644
@@ -26,6 +26,7 @@
 #include <miiphy.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
+#include <asm/arch/gpio.h>
 #include "sheevaplug.h"
 
Quoted 13 lines

include/configs/sheevaplug.h line 48

Quoted 12 lines
board/Marvell/sheevaplug/sheevaplug.c +0 -0
 DECLARE_GLOBAL_DATA_PTR;
include/configs/sheevaplug.h +1 -0
index e62353c..7455c29 100644
@@ -43,6 +43,7 @@
 #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
 #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
 #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
+#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
 #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
 #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */

why do you need it??

I fear it is of no need - it seems it is left from some earlier testing :( Should i repost the patch?

Thanks,
Dieter

Quoted 4 lines

Best Regards,
J.

#3 lore raw
In reply to Heiko Schocher
Quoted 11 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Heiko Schocher
Sent: Thursday, July 09, 2009 11:11 AM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Nicolas Pitre; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

Quoted 24 lines

Hello Jean-Christophe,

Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Dieter Kiermaier

Hi again,

Here is my first out of 2 patches which adds gpio support

to arch/kirkwood.

Quoted 16 lines
Quoted 6 lines

Any suggestions?

Cheers,
Dieter

Quoted 8 lines
Quoted 2 lines

From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:22:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver

looks fine
Prafulla & nico for you?

Okay, Ack, mostly code coming from Linux :-)

Regards..
Prafulla . .

Quoted 16 lines

I actually tested this driver on the suen3 board with the i2c bitbang driver and it works fine :-), so I do a:

bye
Heiko

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, 
Germany _______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#8 lore raw

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

In reply to Jean-Christophe PLAGNIOL-VILLARD

Hi Jean, hi Prafulla,

here the corrected version.

Many thanks,
Dieter

Quoted 49 lines · Dieter Kiermaier
Quoted 37 lines

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug. Any comments are welcome!

Dieter

Quoted 1 line

From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:29:15 +0200
Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

---
 board/Marvell/sheevaplug/sheevaplug.c |    1 +
 include/configs/sheevaplug.h          |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
board/Marvell/sheevaplug/sheevaplug.c +1 -0
index 547126a..fa28fea 100644
@@ -26,6 +26,7 @@
 #include <miiphy.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
+#include <asm/arch/gpio.h>
 #include "sheevaplug.h"
 
 DECLARE_GLOBAL_DATA_PTR;
include/configs/sheevaplug.h +0 -0
index e62353c..7455c29 100644

include/configs/sheevaplug.h line 48

Quoted 6 lines
include/configs/sheevaplug.h +1 -0
@@ -43,6 +43,7 @@
 #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
 #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
 #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
+#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
 #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
 #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */

why do you need it??

Best Regards,
J.

#9 lore raw

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

Quoted 10 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Thursday, July 09, 2009 12:25 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: u-boot at lists.denx.de; Prafulla Wadaskar
Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

Quoted 12 lines

Hi Jean, hi Prafulla,

here the corrected version.

Many thanks,
Dieter

Quoted 5 lines · Dieter Kiermaier
Quoted 4 lines

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug. Any comments are welcome!

Hi Dieter
Thanks for your efforts
That's good, gpio driver is supported for Kirkwood but,
Again question remains the same- Why do you need gpio support on Sheevaplug? Whereas you have no evidence to use it.

Regards..
Prafulla . .

#4 lore raw
In reply to Dieter Kiermaier
Quoted 6 lines
Quoted 1 line

From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001

From: Dieter Kiermaier <[email protected]>
Date: Mon, 29 Jun 2009 14:22:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver

Quoted 8 lines
---
 drivers/gpio/Makefile                |    1 +
 drivers/gpio/kw_gpio.c               |  151 ++++++++++++++++++++++++++++++++++
 include/asm-arm/arch-kirkwood/gpio.h |   51 ++++++++++++
 3 files changed, 203 insertions(+), 0 deletions(-)
 create mode 100644 drivers/gpio/kw_gpio.c
 create mode 100644 include/asm-arm/arch-kirkwood/gpio.h

applied to u-boot-arm

Best Regards,
J.