qemu-kvm: fix typo in configure
PATCH 1/1 qemu-kvm: fix typo in configure
Kill extra \). Also escape ! for clarity and bourne shell compatibility.
Signed-off-by Michael S. Tsirkin <[email protected]>
---
This patch fixes configure on next for me
configure | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
configure +3 -3
@@ -2141,10 +2141,10 @@ configure_kvm() { } # Make sure the target and host cpus are compatible -if test ! \( "$target_cpu" = "$cpu" -o \ +if test \! \( "$target_cpu" = "$cpu" -o \ \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \ - \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ - \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) -o \ + \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ + \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) -o \ \( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then target_kvm="no" fi
Signature · 1 line
1.6.2.2
Quoted 2 lines · Michael S. Tsirkin
Kill extra \). Also escape ! for clarity and bourne shell compatibility.
Agreed. Looks like this one was introduced during the last merge from qemu. It bit me too.
:-Dustin
Quoted 26 lines
Signed-off-by Michael S. Tsirkin <[email protected]>---
This patch fixes configure on next for me
configure | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)configure +3
-3@@ -2141,10 +2141,10 @@ configure_kvm() { } # Make sure the target and host cpus are compatible -if test ! \( "$target_cpu" = "$cpu" -o \ +if test \! \( "$target_cpu" = "$cpu" -o \ \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \ - \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ - \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) -o \ + \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \ + \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) -o \\( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then target_kvm="no"
fi
Quoted 4 lines · Michael S. Tsirkin
Kill extra \). Also escape ! for clarity and bourne shell compatibility.
I applied a similar fix from Jan.
configure configure_kvm() { · line 2144
Quoted 5 lines
# Make sure the target and host cpus are compatible
configure +1
-1-if test ! \( "$target_cpu" = "$cpu" -o \ +if test \! \( "$target_cpu" = "$cpu" -o \
This is needed in qemu.git, in several places.
Signature · 1 line
error compiling committee.c: too many arguments to function