Support for Calao USB A9263 board based on AT91SAM9263 CPU
Hello,
Here is a patch that adds the support for the Calao USB A9263 board. This is my first board support contribution to U-Boot, so don't hesitate to comment and suggest improvements.
Thanks,
Thomas
---
Support for the Calao USB A9263 board
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.
MAKEALL | 1 Makefile | 3 board/usb-a9263/Makefile | 56 +++++++++++++ board/usb-a9263/config.mk | 1 board/usb-a9263/led.c | 44 ++++++++++ board/usb-a9263/partition.c | 37 ++++++++ board/usb-a9263/usb-a9263.c | 189 ++++++++++++++++++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 188 +++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 519 insertions(+)
MAKEALL +1 -0
@@ -590,6 +590,7 @@ LIST_at91=" \ mp2usb \ m501sk \ pm9263 \ + usb-a9263 \ " #########################################################################
Makefile +3 -0
@@ -2785,6 +2785,9 @@ at91sam9rlek_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +usb_a9263_config : unconfig + $(MKCONFIG) -a usb-a9263 arm arm926ejs usb-a9263 NULL at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/usb-a9263/Makefile new file +56 -0
56 lines not on this page · raw message
board/usb-a9263/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/usb-a9263/led.c new file +44 -0
44 lines not on this page · raw message
board/usb-a9263/partition.c new file +37 -0
@@ -0,0 +1,37 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x00001FFF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00002000 ,0x00003FFF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00004000 ,0xFFFFFFFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, +};
board/usb-a9263/usb-a9263.c new file +189 -0
189 lines not on this page · raw message
include/configs/usb-a9263.h new file +188 -0
188 lines not on this page · raw message
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 9 lines · Thomas Petazzoni
Hello,
Here is a patch that adds the support for the Calao USB A9263 board. This is my first board support contribution to U-Boot, so don't hesitate to comment and suggest improvements.
Thanks,
Thomas
this need to move after ---
Quoted 2 lines
---
and this before
Quoted 47 lines
Support for the Calao USB A9263 board
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>MAKEALL | 1 Makefile | 3 board/usb-a9263/Makefile | 56 +++++++++++++ board/usb-a9263/config.mk | 1 board/usb-a9263/led.c | 44 ++++++++++ board/usb-a9263/partition.c | 37 ++++++++ board/usb-a9263/usb-a9263.c | 189 ++++++++++++++++++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 188 +++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 519 insertions(+)board/usb-a9263/usb-a9263.c new file +26
-0+ +#ifdef CONFIG_MACB +static void usb_a9263_macb_hw_init (void ) +{ +/* Enable clock */ +at91_sys_write (AT91_PMC_PCER ,1 <<AT91SAM9263_ID_EMAC ); + +/* +* Disable pull-up on: +* RXDV (PC25) => PHY normal mode (not Test mode) +* ERX0 (PE25) => PHY ADDR0 +* ERX1 (PE26) => PHY ADDR1 => PHYADDR = 0x0 +* +* PHY has internal pull-down +*/ +writel (pin_to_mask (AT91_PIN_PC25 ), +pin_to_controller (AT91_PIN_PC0 ) +PIO_PUDR ); +writel (pin_to_mask (AT91_PIN_PE25 ) | +pin_to_mask (AT91_PIN_PE26 ), +pin_to_controller (AT91_PIN_PE0 ) +PIO_PUDR ); + +/* Need to reset PHY -> 500ms reset */ +at91_sys_write (AT91_RSTC_MR ,AT91_RSTC_KEY | + (AT91_RSTC_ERSTL & (0x0D <<8 )) | +AT91_RSTC_URSTEN ); +
board/usb-a9263/usb-a9263.c line 123
Quoted 10 lines
board/usb-a9263/usb-a9263.c new file +10
-0+at91_sys_write (AT91_RSTC_CR ,AT91_RSTC_KEY |AT91_RSTC_EXTRST ); + +/* Wait for end hardware reset */ +while (!(at91_sys_read (AT91_RSTC_SR ) &AT91_RSTC_NRSTL )); + +/* Restore NRST value */ +at91_sys_write (AT91_RSTC_MR ,AT91_RSTC_KEY | + (AT91_RSTC_ERSTL & (0x0 <<8 )) | +AT91_RSTC_URSTEN ); +
please check recent Sedji fix for this at91sam9260/9263: add back up for the rst(reset controller).
Quoted 11 lines
board/usb-a9263/usb-a9263.c new file +11
-0+/* Re-enable pull-up */ +writel (pin_to_mask (AT91_PIN_PC25 ), +pin_to_controller (AT91_PIN_PC0 ) +PIO_PUER ); +writel (pin_to_mask (AT91_PIN_PE25 ) | +pin_to_mask (AT91_PIN_PE26 ), +pin_to_controller (AT91_PIN_PE0 ) +PIO_PUER ); + + at91_macb_hw_init(); +} +#endif +
<snip>
Quoted 25 lines
Quoted 1 line
---
/dev/null+++
b/include/configs/usb-a9263.hinclude/configs/usb-a9263.h new file +22
-0@@ -0,0 +1,188 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* Thomas Petazzoni <[email protected]> +* +* Configuration settings for the Calao USB-A9263 board. +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License
include/configs/usb-a9263.h line 32
Quoted 10 lines
include/configs/usb-a9263.h new file +10
-0+* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#ifndef __CONFIG_H +#define __CONFIG_H + +/* ARM asynchronous clock */ +#define AT91_CPU_NAME "AT91SAM9263"
no-need please remove
Quoted 89 lines
include/configs/usb-a9263.h new file +89
-0+#define AT91_MAIN_CLOCK 12000000/* 12 MHz crystal */ +#define CONFIG_SYS_HZ 1000 + +#define CONFIG_ARM926EJS 1/* This is an ARM926EJS Core */ +#define CONFIG_AT91SAM9263 1/* It's an Atmel AT91SAM9263 SoC*/ +#define CONFIG_CALAO_USB_A9263 1/* on an Calao USB A 9263 Board */ +#define CONFIG_ARCH_CPU_INIT +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff */ + +#define CONFIG_CMDLINE_TAG 1/* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG 1 + +#define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_SKIP_RELOCATE_UBOOT + +/* +* Hardware drivers +*/ +#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */ + +/* LCD */ +#undef CONFIG_LCD + +/* LED */ +#define CONFIG_AT91_LED +#define CONFIG_RED_LED AT91_PIN_PB7/* this is the power led */ +#define CONFIG_GREEN_LED AT91_PIN_PB8/* this is the user1 led */ +#define CONFIG_YELLOW_LED AT91_PIN_PC29/* this is the user2 led */ + +#define CONFIG_BOOTDELAY 3 + +/* +* BOOTP options +*/ +#define CONFIG_BOOTP_BOOTFILESIZE 1 +#define CONFIG_BOOTP_BOOTPATH 1 +#define CONFIG_BOOTP_GATEWAY 1 +#define CONFIG_BOOTP_HOSTNAME 1 + +/* +* Command line configuration. +*/ +#include <config_cmd_default.h> +#undef CONFIG_CMD_BDI +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI +#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_LOADS +#undef CONFIG_CMD_SOURCE + +#define CONFIG_CMD_PING 1 +#define CONFIG_CMD_DHCP 1 +#define CONFIG_CMD_NAND 1 +#define CONFIG_CMD_USB 1 + +/* SDRAM */ +#define CONFIG_NR_DRAM_BANKS 1 +#define PHYS_SDRAM 0x20000000 +#define PHYS_SDRAM_SIZE 0x04000000/* 64 megs */ + +/* DataFlash */ +#define CONFIG_ATMEL_DATAFLASH_SPI +#define CONFIG_HAS_DATAFLASH 1 +#define CONFIG_SYS_SPI_WRITE_TOUT (5*CONFIG_SYS_HZ) +#define CONFIG_SYS_MAX_DATAFLASH_BANKS 1 +#define CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 0xC0000000/* CS0 */ +#define AT91_SPI_CLK 8000000 +#define DATAFLASH_TCSS (0x1c << 16) +#define DATAFLASH_TCHS (0x1 << 24) + +/* no NOR flash */ +#define CONFIG_SYS_NO_FLASH 1 + +/* NAND flash */ +#ifdef CONFIG_CMD_NAND +#define CONFIG_NAND_ATMEL +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define CONFIG_SYS_NAND_BASE 0x40000000 +#define CONFIG_SYS_NAND_DBW_8 1 +/* our ALE is AD21 */ +#define CONFIG_SYS_NAND_MASK_ALE (1 << 21) +/* our CLE is AD22 */ +#define CONFIG_SYS_NAND_MASK_CLE (1 << 22) +#define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIN_PD15
include/configs/usb-a9263.h line 131
Quoted 10 lines
include/configs/usb-a9263.h new file +10
-0+#define CONFIG_SYS_NAND_READY_PIN AT91_PIN_PA22 +#endif + +/* Ethernet */ +#define CONFIG_MACB 1 +#define CONFIG_RMII 1 +#define CONFIG_NET_MULTI 1 +#define CONFIG_NET_RETRY_COUNT 20 +#define CONFIG_RESET_PHY_R 1 +#define CONFIG_MACB_SEARCH_PHY 1
whitespace please fix
include/configs/usb-a9263.h line 132
Quoted 1 line
include/configs/usb-a9263.h new file +1
-0+#define CONFIG_ETHADDR 00:0D:00:0D:00:AB
please remove
Review line 133
Quoted 1 line
(quoted diff) +1
-0+
Best Regards,
J.
Support for the Calao USB A9263 board
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.
---
Changes from previous version:
* Take into account comments from Jean-Christophe Plagniol-Villard (whitespace issues, integration of MABC RST fix, removal of MAC address setting in board configuration file)
* Moved board-specific code from board/usb-a9263/ to board/calao/usb-a9263/, since support for other boards from Calao will follow shortly.
* Rebased and re-tested with latest U-Boot git.
Thanks for the review and feedback!
MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 56 ++++++++ board/calao/usb-a9263/config.mk | 1 board/calao/usb-a9263/led.c | 44 ++++++ board/calao/usb-a9263/partition.c | 37 +++++ board/calao/usb-a9263/usb-a9263.c | 193 ++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 186 ++++++++++++++++++++++++++ 8 files changed, 521 insertions(+)
MAKEALL +1 -0
@@ -599,6 +599,7 @@ LIST_at91=" \ m501sk \ pm9261 \ pm9263 \ + usb9263 \ " #########################################################################
Makefile +3 -0
@@ -2847,6 +2847,9 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +usb_a9263_config : unconfig + $(MKCONFIG) -a usb-a9263 arm arm926ejs usb-a9263 calao at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/calao/usb-a9263/Makefile new file +56 -0
56 lines not on this page · raw message
board/calao/usb-a9263/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/calao/usb-a9263/led.c new file +44 -0
44 lines not on this page · raw message
board/calao/usb-a9263/partition.c new file +37 -0
@@ -0,0 +1,37 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x00001FFF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00002000 ,0x00003FFF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00004000 ,0xFFFFFFFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, +};
board/calao/usb-a9263/usb-a9263.c new file +193 -0
193 lines not on this page · raw message
include/configs/usb-a9263.h new file +186 -0
186 lines not on this page · raw message
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 1 line · Thomas Petazzoni
Support for the Calao USB A9263 board
You can get rid of the line above. It is nearly identical to the patch subject and doesn't add any useful info.
<snip>
Quoted 3 lines
MAKEALL | 1 Makefile | 3
You should add an entry to MAINTAINERS
<snip>
include/configs/usb-a9263.h line 64
Quoted 5 lines
include/configs/usb-a9263.h new file +5
-0+/* LED */ +#define CONFIG_AT91_LED +#define CONFIG_RED_LED AT91_PIN_PB7/* this is the power led */ +#define CONFIG_GREEN_LED AT91_PIN_PB8/* this is the user1 led */ +#define CONFIG_YELLOW_LED AT91_PIN_PC29/* this is the user2 led */
Funky indentation.
<snip>
Quoted 1 line
+#define
ROUND(A, B)(((A) + (B)) & ~((B) - 1))
I'd try and use the round functions already in include/common.h if possible. Maybe its not possible if this file is included prior to common.h though, I'm not sure.
Best,
Peter
Le Wed, 15 Jul 2009 09:51:27 -0500,
Peter Tyser <[email protected]> a ?crit :
Quoted 2 lines
You can get rid of the line above. It is nearly identical to the patch subject and doesn't add any useful info.
Ok.
Quoted 4 lines
Quoted 2 lines
MAKEALL | 1 Makefile | 3You should add an entry to
MAINTAINERS
Done.
Quoted 9 lines
Quoted 7 lines
(quoted diff) +3
-0+/* LED */ +#define CONFIG_AT91_LED +#define CONFIG_RED_LED
AT91_PIN_PB7/* this is the power led */ +#defineCONFIG_GREEN_LEDAT91_PIN_PB8/* this is the user1
led */ +#defineCONFIG_YELLOW_LEDAT91_PIN_PC29/* this is the user2 led */Funky indentation.
Fixed.
Quoted 5 lines
Quoted 1 line
+#define
ROUND(A, B)(((A) + (B)) & ~((B) - 1))I'd try and use the round functions already in
include/common.hif possible. Maybe its not possible if this file is included prior tocommon.hthough, I'm not sure.
Not sure about this one. All at91 boards do it this way, so if a fix needs to be done, I'd suggest to make it separatly. Is this ok ?
Below is an updated version of the patch. Not sure it's the right way to resend it, though.
Thanks for the review!
Thomas
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.
MAINTAINERS | 4 MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 56 ++++++++ board/calao/usb-a9263/config.mk | 1 board/calao/usb-a9263/led.c | 44 ++++++ board/calao/usb-a9263/partition.c | 37 +++++ board/calao/usb-a9263/usb-a9263.c | 193 ++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 186 ++++++++++++++++++++++++++ 9 files changed, 525 insertions(+)
MAINTAINERS +4 -0
@@ -624,6 +624,10 @@ Peter Pearse <[email protected]> versatile ARM926EJ-S versatile ARM926EJ-S +Thomas Petazzoni <[email protected]> + + usb-a9263 ARM926EJS (AT91SAM9263 SoC) + Dave Peverley <[email protected]> omap730p2 ARM926EJS
MAKEALL +1 -0
@@ -599,6 +599,7 @@ LIST_at91=" \ m501sk \ pm9261 \ pm9263 \ + usb9263 \ " #########################################################################
Makefile +3 -0
@@ -2847,6 +2847,9 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +usb_a9263_config : unconfig + $(MKCONFIG) -a usb-a9263 arm arm926ejs usb-a9263 calao at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/calao/usb-a9263/Makefile new file +56 -0
56 lines not on this page · raw message
board/calao/usb-a9263/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/calao/usb-a9263/led.c new file +44 -0
44 lines not on this page · raw message
board/calao/usb-a9263/partition.c new file +37 -0
@@ -0,0 +1,37 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x00001FFF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00002000 ,0x00003FFF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00004000 ,0xFFFFFFFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, +};
board/calao/usb-a9263/usb-a9263.c new file +193 -0
193 lines not on this page · raw message
include/configs/usb-a9263.h new file +186 -0
186 lines not on this page · raw message
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Hi Thomas,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+#define
ROUND(A, B)(((A) + (B)) & ~((B) - 1))I'd try and use the round functions already in
include/common.hif possible. Maybe its not possible if this file is included prior tocommon.hthough, I'm not sure.Not sure about this one. All at91 boards do it this way, so if a fix needs to be done, I'd suggest to make it separatly. Is this ok ?
I don't have the final say here, I'm just giving my opinion. If it was possible to clean up, the best way in my would be to fix your board (ie this patch), then send a separate follow-up patch fixing other boards. I don't think its too big of a deal either way.
Quoted 2 lines
Below is an updated version of the patch. Not sure it's the right way to resend it, though.
Not quite the right way. As is, all your comments above would go into U-Boot's changelog, which you don't want. You should either send your patch and comments in separate emails, or put any comments you don't want in the changelog below the --- mentioned below.
Quoted 7 lines
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>
You need to add a '---' line here. Anything from the --- to the first diff below are only comments and will be discarded when your patch is applied.
Quoted 14 lines
MAINTAINERS | 4 MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 56 ++++++++ board/calao/usb-a9263/config.mk | 1 board/calao/usb-a9263/led.c | 44 ++++++ board/calao/usb-a9263/partition.c | 37 +++++ board/calao/usb-a9263/usb-a9263.c | 193 ++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 186 ++++++++++++++++++++++++++ 9 files changed, 525 insertions(+)MAINTAINERS +0
-1--- a/MAINTAINERS
<snip>
board/calao/usb-a9263/config.mk line 1
Quoted 8 lines
MAINTAINERS +1
-0+#########################################################################board/calao/usb-a9263/config.mk new file +1
-0@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
You should add a copyright header of some sort to config.mk.
Best,
Peter
Dear Thomas Petazzoni,
Quoted 11 lines · In message <20090715163557.08b58415@surf> you wrote:
Support for the Calao USB A9263 board
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>---
...
Quoted 9 lines
MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 56 ++++++++ board/calao/usb-a9263/config.mk | 1 board/calao/usb-a9263/led.c | 44 ++++++ board/calao/usb-a9263/partition.c | 37 +++++ board/calao/usb-a9263/usb-a9263.c | 193 ++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 186 ++++++++++++++++++++++++++ 8 files changed, 521 insertions(+)
Entries to maintainers is missing.
board/calao/usb-a9263/usb-a9263.c line 171
Quoted 6 lines
board/calao/usb-a9263/usb-a9263.c new file +6
-0+int dram_init (void ) +{ + gd->bd->bi_dram[0 ].start =PHYS_SDRAM ; + gd->bd->bi_dram[0 ].size =PHYS_SDRAM_SIZE ; +return 0 ; +}
Any specific reason for not using autosizing and testing via get_ram_size() ?
Quoted 5 lines
include/configs/usb-a9263.h new file +0
-0
...
include/configs/usb-a9263.h line 152
Quoted 5 lines
include/configs/usb-a9263.h new file +5
-0+/* bootstrap + u-boot + env in dataflash on CS0 */ +#define CONFIG_ENV_IS_IN_DATAFLASH 1 +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0) +#define CONFIG_ENV_OFFSET 0x2000 +#define CONFIG_ENV_ADDR (CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 + CONFIG_ENV_OFFSET)
Line too long. Please fix globally.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
[Doctors and Bartenders], We both get the same two kinds of customers
-- the living and the dying.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknownLe Thu, 16 Jul 2009 09:52:43 -0500,
Peter Tyser <[email protected]> a ?crit :
Quoted 4 lines
I don't have the final say here, I'm just giving my opinion. If it was possible to clean up, the best way in my would be to fix your board (ie this patch), then send a separate follow-up patch fixing other boards. I don't think its too big of a deal either way.
Including <common.h> in a include/configs/ configuration file doesn't seem to work, unfortunately.
Quoted 10 lines
board/calao/usb-a9263/config.mk line 1
Quoted 8 lines
(quoted diff) +1
-0+#########################################################################(quoted diff) +0
-0
b/board/calao/usb-a9263/config.mknew file mode 100644 index 0000000..ff2cfd1board/calao/usb-a9263/config.mk new file +1
-0@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000You should add a copyright header of some sort to config.mk.
In a one-line file, which just contains a factual definition ?
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Le Fri, 17 Jul 2009 21:41:43 +0200,
Wolfgang Denk <[email protected]> a ?crit :
Quoted 1 line
Entries to maintainers is missing.
Yes, it was missing in the initial version of my patch, but further versions got it added, thanks to other people review.
Quoted 9 lines
board/calao/usb-a9263/usb-a9263.c line 171
Quoted 6 lines
board/calao/usb-a9263/usb-a9263.c new file +6
-0+int dram_init (void ) +{ + gd->bd->bi_dram[0 ].start =PHYS_SDRAM ; + gd->bd->bi_dram[0 ].size =PHYS_SDRAM_SIZE ; +return 0 ; +}Any specific reason for not using autosizing and testing via
get_ram_size()?
The initial reason is that the code for this board is taken from the Atmel boards code, which doesn't use get_ram_size(). However, my board has a fixed RAM size, so in that case, is it still useful to use get_ram_size() ?
Quoted 1 line
Line too long. Please fix globally.
Thanks, will do.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 10 lines · Thomas Petazzoni
Le Thu, 16 Jul 2009 09:52:43 -0500,
Peter Tyser <[email protected]> a ?crit :Quoted 4 lines
I don't have the final say here, I'm just giving my opinion. If it was possible to clean up, the best way in my would be to fix your board (ie this patch), then send a separate follow-up patch fixing other boards. I don't think its too big of a deal either way.
Including <
common.h> in ainclude/configs/configuration file doesn't seem to work, unfortunately.
There might be other ways, eg it looks like Wolfgang addressed the issue in this patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg17937.html
Does that patch work for you? I'm assuming it will go in the next U-Boot release.
Quoted 12 lines
Quoted 11 lines
board/calao/usb-a9263/config.mk line 1
Quoted 9 lines
(quoted diff) +1
-0+#########################################################################(quoted diff) +0
-0
b/board/calao/usb-a9263/config.mknew file mode 100644 index 0000000..ff2cfd1board/calao/usb-a9263/config.mk new file +1
-0@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000You should add a copyright header of some sort to config.mk.
Quoted 1 line
In a one-line file, which just contains a factual definition ?
In my opinion yes. A copyright will explicitly say how the file may be used, trivial as it may be. Check out doc/feature-removal-schedule.txt:
What: GPL cleanup
When: August 2009
Why: Over time, a couple of files have sneaked in into the U-Boot
source code that are either missing a valid GPL license header or that carry a license that is incompatible with the GPL.
Such files shall be removed from the U-Boot source tree. See
http://www.denx.de/wiki/pub/U-Boot/TaskGplCleanup/u-boot-1.1.2-files
for an old and probably incomplete list of such files.
You're free to use whatever license you'd like, as long as its GPL compatible. There's no harm in adding a license header, right?
Best,
Peter
Dear Thomas Petazzoni,
Quoted 8 lines · In message <20090720174220.1800dcaa@surf> you wrote:
Quoted 3 lines
Any specific reason for not using autosizing and testing via
get_ram_size()?The initial reason is that the code for this board is taken from the Atmel boards code, which doesn't use
get_ram_size(). However, my board has a fixed RAM size, so in that case, is it still useful to useget_ram_size()?
Yes, it is still useful, as it will for example detect most memory errors and as such broken (or dying) hardware.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Often it is fatal to live too long. - Racine
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.
---
This new version includes the following changes :
* Copyright header on config.mk, by suggestion of Peter Tyser
* Updated copyright informations in all new files
* Use get_ram_size(), as suggested by Wolfgang Denk
* Do some cleanup of useless comments, re-indent definitions to avoid long lines, etc.
* Add entry to MAINTAINERS
I'm still including the definition of ROUND() in the board configuration file, since Wolfgang's patch has yet been merged to the Git tree (and I don't think sending a patch that doesn't compile against the current Git tree is useful).
MAINTAINERS | 4 MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 58 +++++++++++ board/calao/usb-a9263/config.mk | 24 ++++ board/calao/usb-a9263/partition.c | 38 +++++++ board/calao/usb-a9263/usb-a9263.c | 194 ++++++++++++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 185 ++++++++++++++++++++++++++++++++++++ 8 files changed, 507 insertions(+)
MAINTAINERS +4 -0
@@ -624,6 +624,10 @@ Peter Pearse <[email protected]> versatile ARM926EJ-S versatile ARM926EJ-S +Thomas Petazzoni <[email protected]> + + usb-a9263 ARM926EJS (AT91SAM9263 SoC) + Dave Peverley <[email protected]> omap730p2 ARM926EJS
MAKEALL +1 -0
@@ -599,6 +599,7 @@ LIST_at91=" \ m501sk \ pm9261 \ pm9263 \ + usb9263 \ " #########################################################################
Makefile +3 -0
@@ -2807,6 +2807,9 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +usb_a9263_config : unconfig + $(MKCONFIG) -a usb-a9263 arm arm926ejs usb-a9263 calao at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/calao/usb-a9263/Makefile new file +58 -0
58 lines not on this page · raw message
board/calao/usb-a9263/config.mk new file +24 -0
@@ -0,0 +1,24 @@ +# +# (C) Copyright 2009 +# Thomas Petazzoni, Free Electrons, <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +TEXT_BASE = 0x23f00000
board/calao/usb-a9263/partition.c new file +38 -0
@@ -0,0 +1,38 @@ +/* +* (C) Copyright 2008-2009 +* Ulf Samuelsson <[email protected]> +* Thomas Petazzoni, Free Electrons, <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x00001FFF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00002000 ,0x00003FFF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00004000 ,0xFFFFFFFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, +};
board/calao/usb-a9263/usb-a9263.c new file +194 -0
194 lines not on this page · raw message
include/configs/usb-a9263.h new file +185 -0
185 lines not on this page · raw message
Hi Thomas,
Just a note, but its nice when you resend patches to include the string [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can tell which email contains the latest iteration of it.
Quoted 11 lines
This new version includes the following changes :
* Copyright header on config.mk, by suggestion of Peter Tyser
* Updated copyright informations in all new files
* Use
get_ram_size(), as suggested by Wolfgang Denk* Do some cleanup of useless comments, re-indent definitions to avoid long lines, etc.
Quoted 6 lines
* Add entry to
MAINTAINERSI'm still including the definition of
ROUND()in the board configuration file, since Wolfgang's patch has yet been merged to the Git tree (and I don't think sending a patch that doesn't compile against the current Git tree is useful).
That's just plain bad luck, Wolfgang just merged the ROUND() commit a few hours ago:)
http://git.denx.de/?p=u-boot.git;a=commit;h=70ebf31633f372a24505e47846b2628e8435ea37
Its up to the ARM maintainer to determine if having the ROUND() defined locally is a show stopper.
Best,
Peter
Hi,
Le Wed, 22 Jul 2009 10:57:09 -0500,
Peter Tyser <[email protected]> a ?crit :
Quoted 5 lines
Hi Thomas,
Just a note, but its nice when you resend patches to include the string [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can tell which email contains the latest iteration of it.
Ok.
Quoted 4 lines
That's just plain bad luck, Wolfgang just merged the
ROUND()commit a few hours ago:)http://git.denx.de/?p=u-boot.git;a=commit;h=70ebf31633f372a24505e47846b2628e8435ea37
Yes, but it also doesn't seem to work (yet):
http://lists.denx.de/pipermail/u-boot/2009-July/057230.html
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 24 lines · Peter Tyser
Hi Thomas,
Just a note, but its nice when you resend patches to include the string [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can tell which email contains the latest iteration of it.
Quoted 11 lines
This new version includes the following changes :
* Copyright header on config.mk, by suggestion of Peter Tyser
* Updated copyright informations in all new files
* Use
get_ram_size(), as suggested by Wolfgang Denk* Do some cleanup of useless comments, re-indent definitions to avoid long lines, etc.
Quoted 6 lines
* Add entry to
MAINTAINERSI'm still including the definition of
ROUND()in the board configuration file, since Wolfgang's patch has yet been merged to the Git tree (and I don't think sending a patch that doesn't compile against the current Git tree is useful).
Quoted 5 lines
That's just plain bad luck, Wolfgang just merged the
ROUND()commit a few hours ago:)http://git.denx.de/?p=u-boot.git;a=commit;h=70ebf31633f372a24505e47846b2628e8435ea37
Which consequently made all those boards fail to compile. See
http://lists.denx.de/pipermail/u-boot/2009-July/057230.html for further details
Cheers,
Signature · 11 lines
Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: Digital signature Url : http://lists.denx.de/pipermail/u-boot/attachments/20090722/6707fdda/attachment.pgp
Quoted 13 lines · Thomas Petazzoni
Hi,
Le Wed, 22 Jul 2009 10:57:09 -0500,
Peter Tyser <[email protected]> a ?crit :Quoted 5 lines
Hi Thomas,
Just a note, but its nice when you resend patches to include the string [PATCH vX] where X=2, 3, etc. That way whoever applies your patch can tell which email contains the latest iteration of it.
Ok.
Quoted 8 lines
Quoted 4 lines
That's just plain bad luck, Wolfgang just merged the
ROUND()commit a few hours ago:)http://git.denx.de/?p=u-boot.git;a=commit;h=70ebf31633f372a24505e47846b2628e8435ea37
Yes, but it also doesn't seem to work (yet):
http://lists.denx.de/pipermail/u-boot/2009-July/057230.html
I see, well I'll gracefully bow out of this conversation now:)
Best,
Peter
Quoted 9 lines · Thomas Petazzoni
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>---
please no RE in the subject
Quoted 44 lines
This new version includes the following changes :
* Copyright header on config.mk, by suggestion of Peter Tyser
* Updated copyright informations in all new files
* Use
get_ram_size(), as suggested by Wolfgang Denk* Do some cleanup of useless comments, re-indent definitions to avoid long lines, etc.
* Add entry to
MAINTAINERSI'm still including the definition of
ROUND()in the board configuration file, since Wolfgang's patch has yet been merged to the Git tree (and I don't think sending a patch that doesn't compile against the current Git tree is useful).MAINTAINERS | 4 MAKEALL | 1 Makefile | 3 board/calao/usb-a9263/Makefile | 58 +++++++++++ board/calao/usb-a9263/config.mk | 24 ++++ board/calao/usb-a9263/partition.c | 38 +++++++ board/calao/usb-a9263/usb-a9263.c | 194 ++++++++++++++++++++++++++++++++++++++ include/configs/usb-a9263.h | 185 ++++++++++++++++++++++++++++++++++++ 8 files changed, 507 insertions(+)MAINTAINERS +4
-0@@ -624,6 +624,10 @@ Peter Pearse <[email protected]> versatile ARM926EJ-S versatile ARM926EJ-S +Thomas Petazzoni <[email protected]> + + usb-a9263 ARM926EJS (AT91SAM9263 SoC) + Dave Peverley <[email protected]> omap730p2 ARM926EJS
<snip>
Quoted 25 lines
board/calao/usb-a9263/usb-a9263.c new file +19
-0@@ -0,0 +1,194 @@ +/* +* (C) Copyright 2007-2009 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* Thomas Petazzoni, Free Electrons, <[email protected]> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*
board/calao/usb-a9263/usb-a9263.c line 29
Quoted 10 lines
board/calao/usb-a9263/usb-a9263.c new file +10
-0+* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/sizes.h> +#include <asm/arch/at91sam9263.h> +#include <asm/arch/at91sam9263_matrix.h>
please
#include <asm/arch/at91sam9_matrix.h>
Quoted 12 lines
board/calao/usb-a9263/usb-a9263.c new file +12
-0+#include <asm/arch/at91sam9_smc.h> +#include <asm/arch/at91_common.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/at91_rstc.h> +#include <asm/arch/clk.h> +#include <asm/arch/gpio.h> +#include <asm/arch/io.h> +#include <asm/arch/hardware.h> +#if defined(CONFIG_RESET_PHY_R ) && defined(CONFIG_MACB ) +#include <net.h> +#endif +#include <netdev.h>
board/calao/usb-a9263/usb-a9263.c
Quoted 10 lines
board/calao/usb-a9263/usb-a9263.c new file +10
-0+ +DECLARE_GLOBAL_DATA_PTR ; + +/* ------------------------------------------------------------------------- */ +/* +* Miscelaneous platform dependent initialisations +*/ + + +#include <asm/arch/at91sam9263.h>
no please do not include it here but in the correctly file need
Quoted 85 lines
board/calao/usb-a9263/usb-a9263.c new file +85
-0+ +/* ARM asynchronous clock */ +#define AT91_MAIN_CLOCK 12000000/* 12 MHz crystal */ +#define CONFIG_SYS_HZ 1000 + +#define CONFIG_ARM926EJS 1/* This is an ARM926EJS Core */ +#define CONFIG_AT91SAM9263 1/* It's an Atmel AT91SAM9263 SoC*/ +#define CONFIG_CALAO_USB_A9263 1/* on an Calao USB A 9263 Board */ +#define CONFIG_ARCH_CPU_INIT +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff */ + +#define CONFIG_CMDLINE_TAG 1/* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG 1 + +#define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_SKIP_RELOCATE_UBOOT + +/* +* Hardware drivers +*/ +#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */ + +/* LCD */ +#undef CONFIG_LCD + +#define CONFIG_BOOTDELAY 3 + +/* +* BOOTP options +*/ +#define CONFIG_BOOTP_BOOTFILESIZE 1 +#define CONFIG_BOOTP_BOOTPATH 1 +#define CONFIG_BOOTP_GATEWAY 1 +#define CONFIG_BOOTP_HOSTNAME 1 + +/* +* Command line configuration. +*/ +#include <config_cmd_default.h> +#undef CONFIG_CMD_BDI +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI +#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_LOADS +#undef CONFIG_CMD_SOURCE + +#define CONFIG_CMD_PING 1 +#define CONFIG_CMD_DHCP 1 +#define CONFIG_CMD_NAND 1 +#define CONFIG_CMD_USB 1 + +/* SDRAM */ +#define CONFIG_NR_DRAM_BANKS 1 +#define PHYS_SDRAM 0x20000000 +#define PHYS_SDRAM_SIZE 0x04000000 + +/* DataFlash */ +#define CONFIG_ATMEL_DATAFLASH_SPI +#define CONFIG_HAS_DATAFLASH 1 +#define CONFIG_SYS_SPI_WRITE_TOUT (5*CONFIG_SYS_HZ) +#define CONFIG_SYS_MAX_DATAFLASH_BANKS 1 +#define CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 0xC0000000 +#define AT91_SPI_CLK 8000000 +#define DATAFLASH_TCSS (0x1c << 16) +#define DATAFLASH_TCHS (0x1 << 24) + +/* no NOR flash */ +#define CONFIG_SYS_NO_FLASH 1 + +/* NAND flash */ +#ifdef CONFIG_CMD_NAND +#define CONFIG_NAND_ATMEL +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define CONFIG_SYS_NAND_BASE 0x40000000 +#define CONFIG_SYS_NAND_DBW_8 1 +/* our ALE is AD21 */ +#define CONFIG_SYS_NAND_MASK_ALE (1 << 21) +/* our CLE is AD22 */ +#define CONFIG_SYS_NAND_MASK_CLE (1 << 22) +#define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIN_PD15
board/calao/usb-a9263/usb-a9263.c line 146
Quoted 10 lines
board/calao/usb-a9263/usb-a9263.c new file +10
-0+#define CONFIG_SYS_NAND_READY_PIN AT91_PIN_PA22 +#endif + +/* Ethernet */ +#define CONFIG_MACB 1 +#define CONFIG_RMII 1 +#define CONFIG_NET_MULTI 1 +#define CONFIG_NET_RETRY_COUNT 20 +#define CONFIG_RESET_PHY_R 1 +#define CONFIG_MACB_SEARCH_PHY 1
do you have multiple phy?
board/calao/usb-a9263/usb-a9263.c
Quoted 8 lines
board/calao/usb-a9263/usb-a9263.c new file +7
-0+ +#define CONFIG_CMDLINE_EDITING 1 +#define CONFIG_AUTO_COMPLETE +#define CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " + +#define ROUND (A ,B ) (((A) + (B)) & ~((B) - 1))
no need please remove
Quoted 1 line
+/*
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 9 lines · Thomas Petazzoni
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>---
please no RE in the subject
Oops??? Why not?? It is strictly RFC-conformant to add a (single) "Re: " in front of the Subject on replies.
What exactly do you mean????
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good aphorism is too hard for the tooth of time, and is not worn
away by all the centuries, although it serves as food for every
epoch. - Friedrich Wilhelm Nietzsche
_Miscellaneous Maxims and Opinions_ no. 168Quoted 12 lines · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 8 lines · Thomas Petazzoni
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.Signed-off-by Thomas Petazzoni <[email protected]>
Quoted 7 lines
Quoted 2 lines
Quoted 1 line
---
please no RE in the subject
Oops??? Why not?? It is strictly RFC-conformant to add a (single) "Re: " in front of the Subject on replies.
What exactly do you mean????
git am does not like it
and v2 will be better
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 7 lines
Quoted 2 lines
please no RE in the subject
Oops??? Why not?? It is strictly RFC-conformant to add a (single) "Re: " in front of the Subject on replies.
What exactly do you mean????
git am does not like it
and v2 will be better
What are you talking about?
"git am" on the patch with "Subject: Re: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU" results in:
-> git-am -3 -i -u --whitespace=strip ~/Mail/U-Boot/8418 Commit Body is:
--------------------------
Support for Calao USB A9263 board based on AT91SAM9263 CPU
The Calao USB A9263 board is a board manufactured and sold by Calao Systems <http://www.calao-systems.com>. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences:
different clocks, no LCD, etc.
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all n
As you can see there is zero problem with the "Re: " (and I'd be seriously surprised if there was).
So please explain what exactly you are talking about.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de He is truly wise who gains wisdom from another's mishap.