Skip to contentSkip to conversation

cciss: Ignore stale commands after reboot

PATCH Miller, Mike (OS Dev) 2 participants 3 messages Jul 2, 2009 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Miller, Mike (OS Dev)

author Acked-by
#1 lore raw
Quoted 31 lines

-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Thursday, July 02, 2009 2:51 PM
To: Miller, Mike (OS Dev)
Subject: Fw: Re: [PATCH] cciss: Ignore stale commands after reboot

oh, Jens already did it.

Begin forwarded message:

Date: Thu, 2 Jul 2009 21:00:49 +0200
From: Jens Axboe <[email protected]>
To: Hannes Reinecke <[email protected]>
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] cciss: Ignore stale commands after reboot

Quoted 2 lines · Hannes Reinecke

When doing an unexpected shutdown like kexec the cciss

firmware might

Quoted 2 lines

still have some commands in flight, which it is trying to complete. The driver is doing it's best on resetting the HBA, but

sadly there's

Quoted 3 lines

a firmware issue causing the firmware _not_ to abort or drop old commands.
So the firmware will send us commands which we haven't

Quoted 8 lines

accounted for,

Quoted 3 lines

causing the driver to panic.

With this patch we're just ignoring these commands as there

is nothing

Quoted 1 line

we could be doing with them anyway.

Looks good to me. Mike, Stephen?

Sorry I haven't seen this before. The beardog addresses are no longer valid. We moved into a dungeon and into a new domain. The good folks in IT have yet to assign another IP address/domain name or an MX record for the mail servers. I hope that by next week that will be corrected. Until then all Steve and I have to use is some form of OutHouse mail client.

Acked-by Mike Miller <[email protected]>
Quoted 70 lines

drivers/block/cciss.c static inline void addQ(struct

Quoted 13 lines
Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/block/cciss.c     |   15 +++++++++++++--
 drivers/block/cciss_cmd.h |    1 +
 2 files changed, 14 insertions(+), 2 deletions(-)
drivers/block/cciss.c index renamed from drivers/block/cciss.c +0 -0

c7a527c..65a0655 100644

drivers/block/cciss.c +0 -0
@@ -226,8 +226,18 @@ static inline void addQ(struct

hlist_head *list,

Quoted 20 lines
drivers/block/cciss.c +11 -1
 CommandList_struct *c)
 
 static inline void removeQ(CommandList_struct *c)  {
-	if (WARN_ON(hlist_unhashed(&c->list)))
+	/*
+	 * After kexec/dump some commands might still
+	 * be in flight, which the firmware will try
+	 * to complete. Resetting the firmware doesn't work
+	 * with old fw revisions, so we have to mark
+	 * them off as 'stale' to prevent the driver from
+	 * falling over.
+	 */
+	if (WARN_ON(hlist_unhashed(&c->list))) {
+		c->cmd_type = CMD_MSG_STALE;
 		return;
+	}
 
 	hlist_del_init(&c->list);
 }

drivers/block/cciss.c static void fail_all_cmds(unsigned long ctlr) · line 4257

Quoted 2 lines
drivers/block/cciss.c +0 -0
@@ -4246,7 +4256,8 @@ static void fail_all_cmds(unsigned long ctlr)
 	while (!hlist_empty(&h->cmpQ)) {
 		c = hlist_entry(h->cmpQ.first,

CommandList_struct, list);

Quoted 22 lines
drivers/block/cciss.c +2 -1
 		removeQ(c);
-		c->err_info->CommandStatus = CMD_HARDWARE_ERR;
+		if (c->cmd_type != CMD_MSG_STALE)
+			c->err_info->CommandStatus = CMD_HARDWARE_ERR;
 		if (c->cmd_type == CMD_RWREQ) {
 			complete_command(h, c, 0);
 		} else if (c->cmd_type == CMD_IOCTL_PEND) diff --git

a/drivers/block/cciss_cmd.h b/drivers/block/cciss_cmd.h index cd665b0..dbaed1e 100644

drivers/block/cciss_cmd.h +1 -1
@@ -274,6 +274,7 @@ typedef struct _ErrorInfo_struct {
 #define CMD_SCSI	0x03
 #define CMD_MSG_DONE	0x04
 #define CMD_MSG_TIMEOUT 0x05
+#define CMD_MSG_STALE	0xff
 
 /* This structure needs to be divisible by 8 for new
  * indexing method.
--

1.5.3.2

Signature · 8 lines
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe 
linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
Quoted 40 lines · Mike (OS Dev)
Quoted 31 lines

-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Thursday, July 02, 2009 2:51 PM
To: Miller, Mike (OS Dev)
Subject: Fw: Re: [PATCH] cciss: Ignore stale commands after reboot

oh, Jens already did it.

Begin forwarded message:

Date: Thu, 2 Jul 2009 21:00:49 +0200
From: Jens Axboe <[email protected]>
To: Hannes Reinecke <[email protected]>
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] cciss: Ignore stale commands after reboot

Quoted 2 lines · Hannes Reinecke

When doing an unexpected shutdown like kexec the cciss

firmware might

Quoted 2 lines

still have some commands in flight, which it is trying to complete. The driver is doing it's best on resetting the HBA, but

sadly there's

Quoted 3 lines

a firmware issue causing the firmware _not_ to abort or drop old commands.
So the firmware will send us commands which we haven't

Quoted 8 lines

accounted for,

Quoted 3 lines

causing the driver to panic.

With this patch we're just ignoring these commands as there

is nothing

Quoted 1 line

we could be doing with them anyway.

Looks good to me. Mike, Stephen?

Quoted 8 lines

Sorry I haven't seen this before. The beardog addresses are no longer valid. We moved into a dungeon and into a new domain. The good folks in IT have yet to assign another IP address/domain name or an MX record for the mail servers. I hope that by next week that will be corrected. Until then all Steve and I have to use is some form of OutHouse mail client.

Acked-by Mike Miller <[email protected]>

OK, I'll add the patch with your ack.

Signature · 1 line
Jens Axboe