Skip to contentSkip to conversation

PM / irq: Fix comment describing suspend_device_irqs()

PATCH In review Rafael J. Wysocki 1 participant 2 messages Jul 4, 2009 – Jul 5, 2009 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PM / irq: Fix comment describing suspend_device_irqs()

From: Rafael J. Wysocki <[email protected]>

The kerneldoc comment describing suspend_device_irqs() is currently misleading, because generally the function doesn't really disable interrupt lines at the chip level. Replace it with a more accurate one.

---
 kernel/irq/pm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/irq/pm.c +4 -4
Index: linux-2.6/kernel/irq/pm.c
===================================================================
@@ -15,10 +15,10 @@
 /**
  * suspend_device_irqs - disable all currently enabled interrupt lines
  *
- * During system-wide suspend or hibernation device interrupts need to be
- * disabled at the chip level and this function is provided for this purpose.
- * It disables all interrupt lines that are enabled at the moment and sets the
- * IRQ_SUSPENDED flag for them.
+ * During system-wide suspend or hibernation device drivers need to be prevented
+ * from receiving interrupts and this function is provided for this purpose.
+ * It marks all interrupt lines in use, except for the timer ones, as disabled
+ * and sets the IRQ_SUSPENDED flag for each of them.
  */
 void suspend_device_irqs(void)
 {
#1 lore raw

[tip:irq/core] genirq: Fix comment describing suspend_device_irqs()

Commit-ID:  c71320d0c445e01555a86fa6523609db47eeaef6
Gitweb:     http://git.kernel.org/tip/c71320d0c445e01555a86fa6523609db47eeaef6
Author:     Rafael J. Wysocki <[email protected]>
AuthorDate: Sun, 5 Jul 2009 00:22:34 +0200
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sun, 5 Jul 2009 13:07:00 +0200

genirq: Fix comment describing suspend_device_irqs()

The kerneldoc comment describing suspend_device_irqs() is currently misleading, because generally the function doesn't really disable interrupt lines at the chip level. Replace it with a more accurate one.

LKML-Reference: <[email protected]>

---
 kernel/irq/pm.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
kernel/irq/pm.c +4 -4
index 638d8be..a0bb09e 100644
@@ -15,10 +15,10 @@
 /**
  * suspend_device_irqs - disable all currently enabled interrupt lines
  *
- * During system-wide suspend or hibernation device interrupts need to be
- * disabled at the chip level and this function is provided for this purpose.
- * It disables all interrupt lines that are enabled at the moment and sets the
- * IRQ_SUSPENDED flag for them.
+ * During system-wide suspend or hibernation device drivers need to be prevented
+ * from receiving interrupts and this function is provided for this purpose.
+ * It marks all interrupt lines in use, except for the timer ones, as disabled
+ * and sets the IRQ_SUSPENDED flag for each of them.
  */
 void suspend_device_irqs(void)
 {