Skip to contentSkip to conversation

xfstests: add tests to check log size scaling

PATCH In review Christoph Hellwig 2 participants 4 messages Jul 5, 2009 – Jul 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: add tests to check log size scaling

XFS-QA test to check that log size scaling works correctly for old and new maximum log sizes.

[hch: split into two testcases for old "small" log scaling and the
large logs that require recent xfsprogs, and reduce the maximum size by 1GB to make it possible to run the test on 32 bit platforms]

216 new file +79 -0
Index: xfstests-dev/216
===================================================================
@@ -0,0 +1,79 @@
+#! /bin/sh
+# FS QA Test No. 216
+#
+# log size mkfs test - ensure the log size scaling works for small filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2008 Silicon Graphics, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
[email protected]
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+    _cleanup_testdir
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+_setup_testdir
+_require_scratch
+_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mount
+
+_require_loop
+LOOP_DEV=$SCRATCH_MNT/test_fs
+LOOP_MNT=$SCRATCH_MNT/test_fs_dir
+
+_do_mkfs()
+{
+	for i in $*; do
+		echo -n "fssize=${i}g "
+		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
+			-d name=$LOOP_DEV,size=${i}g |grep log
+		mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
+		echo "test write" > $LOOP_MNT/test
+		umount $LOOP_MNT
+	done
+}
+# make large holey file
+$XFS_IO_PROG -f -c "truncate 256g" $LOOP_DEV
+
+#make loopback mount dir
+mkdir $LOOP_MNT
+
+# walk over standard sizes (up to 256GB)
+_do_mkfs 1 2 4 8 16 32 64 128 256
+
+status=0
+exit
216.out new file +10 -0
Index: xfstests-dev/216.out
===================================================================
@@ -0,0 +1,10 @@
+QA output created by 216
+fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
+fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
+fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
+fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2
group +2 -0
Index: xfstests-dev/group
===================================================================
@@ -324,3 +324,5 @@
 213 rw auto prealloc quick
 214 rw auto prealloc quick
 215 auto metadata quick
+216 log metadata auto quick
+217 log metadata auto
217 new file +89 -0

89 lines not on this page · raw message

217.out new file +7 -0
Index: xfstests-dev/217.out
===================================================================
@@ -0,0 +1,7 @@
+QA output created by 217
+fssize=512g log      =internal log           bsize=4096   blocks=65536, version=2
+fssize=1024g log      =internal log           bsize=4096   blocks=131072, version=2
+fssize=2048g log      =internal log           bsize=4096   blocks=262144, version=2
+fssize=4096g log      =internal log           bsize=4096   blocks=521728, version=2
+fssize=8192g log      =internal log           bsize=4096   blocks=521728, version=2
+fssize=16383g log      =internal log           bsize=4096   blocks=521728, version=2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 9 lines · Christoph Hellwig

XFS-QA test to check that log size scaling works correctly for old and new maximum log sizes.

[hch: split into two testcases for old "small" log scaling and the
large logs that require recent xfsprogs, and reduce the maximum size by 1GB to make it possible to run the test on 32 bit platforms]

minor question below

Quoted 48 lines

Index: xfstests-dev/216
===================================================================

216 new file +42 -0
@@ -0,0 +1,79 @@
+#! /bin/sh
+# FS QA Test No. 216
+#
+# log size mkfs test - ensure the log size scaling works for small filesystems
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2008 Silicon Graphics, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
[email protected]
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+    _cleanup_testdir
+}
+
+# get standard environment, filters and checks
+. ./common.rc

216 line 52

Quoted 10 lines
216 new file +10 -0
+. ./common.filter
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+_setup_testdir
+_require_scratch
+_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mount

Any reason to do this on the scratch dir vs. the test dir? (Since scratch dir became optional, I figure stuff that can go on the test dev instead, probably should?)

not a big deal, it looks fine otherwise.

-Eric

Quoted 158 lines
216 new file +26 -0
+_require_loop
+LOOP_DEV=$SCRATCH_MNT/test_fs
+LOOP_MNT=$SCRATCH_MNT/test_fs_dir
+
+_do_mkfs()
+{
+	for i in $*; do
+		echo -n "fssize=${i}g "
+		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
+			-d name=$LOOP_DEV,size=${i}g |grep log
+		mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
+		echo "test write" > $LOOP_MNT/test
+		umount $LOOP_MNT
+	done
+}
+# make large holey file
+$XFS_IO_PROG -f -c "truncate 256g" $LOOP_DEV
+
+#make loopback mount dir
+mkdir $LOOP_MNT
+
+# walk over standard sizes (up to 256GB)
+_do_mkfs 1 2 4 8 16 32 64 128 256
+
+status=0
+exit

Index: xfstests-dev/216.out
===================================================================

216.out new file +10 -0
@@ -0,0 +1,10 @@
+QA output created by 216
+fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
+fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
+fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
+fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
+fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2

Index: xfstests-dev/group
===================================================================

group +2 -0
@@ -324,3 +324,5 @@
 213 rw auto prealloc quick
 214 rw auto prealloc quick
 215 auto metadata quick
+216 log metadata auto quick
+217 log metadata auto

Index: xfstests-dev/217
===================================================================

217 new file +89 -0
@@ -0,0 +1,89 @@
+#! /bin/sh
+# FS QA Test No. 217
+#
+# large log size mkfs test - ensure the log size scaling works
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2008 Silicon Graphics, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
[email protected]
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+    _cleanup_testdir
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+_setup_testdir
+_require_scratch
+_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mount
+
+_require_loop
+LOOP_DEV=$SCRATCH_MNT/test_fs
+LOOP_MNT=$SCRATCH_MNT/test_fs_dir
+
+_do_mkfs()
+{
+	for i in $*; do
+		echo -n "fssize=${i}g "
+		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
+			-d name=$LOOP_DEV,size=${i}g |grep log
+		mount -o loop -t xfs $LOOP_DEV $LOOP_MNT
+		echo "test write" > $LOOP_MNT/test
+		umount $LOOP_MNT
+	done
+}
+# make large holey file
+$XFS_IO_PROG -f -c "truncate 16383g" $LOOP_DEV
+
+#make loopback mount dir
+mkdir $LOOP_MNT
+
+# test if large logs are supported
+$MKFS_XFS_PROG -f -l size=256m -d name=$LOOP_DEV,size=10g > /dev/null 2>&1
+if [ $? -ne 0 ]; then
+	_notrun "large log sizes not supported by mkfs"
+fi
+
+#
+# walk over "new" sizes supported by recent xfsprogs.
+# Note that the last test is for 16TB-1GB as 32bit platforms only support
+# device slightly smaller than 16TB.
+#
+_do_mkfs 512 1024 2048 4096 8192 16383
+
+status=0
+exit

Index: xfstests-dev/217.out
===================================================================

217.out new file +7 -0
@@ -0,0 +1,7 @@
+QA output created by 217
+fssize=512g log      =internal log           bsize=4096   blocks=65536, version=2
+fssize=1024g log      =internal log           bsize=4096   blocks=131072, version=2
+fssize=2048g log      =internal log           bsize=4096   blocks=262144, version=2
+fssize=4096g log      =internal log           bsize=4096   blocks=521728, version=2
+fssize=8192g log      =internal log           bsize=4096   blocks=521728, version=2
+fssize=16383g log      =internal log           bsize=4096   blocks=521728, version=2
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 5 lines · Eric Sandeen

Any reason to do this on the scratch dir vs. the test dir? (Since scratch dir became optional, I figure stuff that can go on the test dev instead, probably should?)

not a big deal, it looks fine otherwise.

The test should work just fine using the test dir, and given that these bits all cam from Dave I can't speak for his reason to use the scratch dir. But given that even creating an empty 16TB filesystem uses up a lot of space I'd rather have as much as possible free space available instead of sharing it with an aged filesystem.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Eric Sandeen

Any reason to do this on the scratch dir vs. the test dir? (Since scratch dir became optional, I figure stuff that can go on the test dev instead, probably should?)

Quoted 7 lines
Quoted 1 line

not a big deal, it looks fine otherwise.

The test should work just fine using the test dir, and given that these bits all cam from Dave I can't speak for his reason to use the scratch dir. But given that even creating an empty 16TB filesystem uses up a lot of space I'd rather have as much as possible free space available instead of sharing it with an aged filesystem.

Ok, it's fine by me as posted then, consider it reviewed.

-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs