Skip to contentSkip to conversation

pipe: use file_update_time() when hold i_mutex

PATCH In review Amerigo Wang 3 participants 6 messages Jul 6, 2009 – Aug 3, 2009 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pipe: use file_update_time() when hold i_mutex

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Cc Al Viro <[email protected]>
Cc Heiko Carstens <[email protected]>
Cc Miklos Szeredi <[email protected]>

---

fs/pipe.c +3 -2
index f7dd21a..724b035 100644
@@ -602,13 +602,14 @@ redo2:
 		pipe->waiting_writers--;
 	}
 out:
+	if (ret > 0)
+		file_update_time(filp);
+
 	mutex_unlock(&inode->i_mutex);
 	if (do_wakeup) {
 		wake_up_interruptible_sync(&pipe->wait);
 		kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
 	}
-	if (ret > 0)
-		file_update_time(filp);
 	return ret;
 }
 
#1 lore raw
Quoted 4 lines · On Mon, 6 Jul 2009 01:35:30 -0400 Amerigo Wang <[email protected]> wrote:

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Why do you believe that file_update_time() needs i_mutex?

#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 4 lines · On Mon, 6 Jul 2009 01:35:30 -0400 Amerigo Wang <[email protected]> wrote:

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Why do you believe that file_update_time() needs i_mutex?

file_update_time() modifies inode, no? :)

#3 lore raw
Quoted 5 lines · Amerigo Wang
Quoted 4 lines · Andrew Morton

On Mon, 6 Jul 2009 01:35:30 -0400
Amerigo Wang <[email protected]> wrote:

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Why do you believe that file_update_time() needs i_mutex?

file_update_time() modifies inode, no? :)

So does touch_atime(), yet neither needs i_mutex.

But calling file_update_time() within the locked region in pipe_write() might make sense regardless: that way a task waiting for data would be guaranteed to see the time change after receiving a POLLIN event for example.

Thanks,
Miklos

#4 lore raw
Quoted 14 lines · Miklos Szeredi
Quoted 12 lines · Amerigo Wang
Quoted 10 lines · Andrew Morton
Quoted 5 lines · On Mon, 6 Jul 2009 01:35:30 -0400 Amerigo Wang <[email protected]> wrote:

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Why do you believe that file_update_time() needs i_mutex?

file_update_time() modifies inode, no? :)

So does touch_atime(), yet neither needs i_mutex.

Yes?

Then how the inode is protected when file_update_time() modifies it?

Thanks.

#5 lore raw
Quoted 21 lines · Amerigo Wang
Quoted 20 lines · Miklos Szeredi
Quoted 17 lines · Amerigo Wang
Quoted 5 lines · Andrew Morton

On Mon, 6 Jul 2009 01:35:30 -0400
Amerigo Wang <[email protected]> wrote:

Quoted 8 lines
Quoted 5 lines

file_update_time() should be called with i_mutex held, move it before mutex_unlock().

Why do you believe that file_update_time() needs i_mutex?

file_update_time() modifies inode, no? :)

Quoted 6 lines
Quoted 2 lines

So does touch_atime(), yet neither needs i_mutex.

Yes?

Then how the inode is protected when file_update_time() modifies it?

Protected against what?

For example the inode isn't protected against concurrent access by stat(2), since that doesn't take i_mutex.

And indeed it looks like there are races there, since set/get operations are not atomic on the timestamp, so stat could return a garbled value if it races with file_update_time() or touch_atime().

Possibly worth fixing, but I'm not sure how to do that without affecting the scalability of stat and friends and without adding too much complexity.

Thanks,
Miklos