Skip to contentSkip to conversation

ppc4xx: Set default PCI device ID for 405EP boards

PATCH New Matthias Fuchs 2 participants 2 messages Jul 8, 2009 – Jul 10, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Set default PCI device ID for 405EP boards

Current code only sets the PCI vendor id to 0x1014 and leaved device id to 0x0000.

Ths patch ....
a) uses the correct PCI_VENDOR_ID_IBM macro for this
b) sets the default device ID as stated in the UM to 0x0156 by using PCI_DEVICE_ID_IBM_405GP for this.

---
 cpu/ppc4xx/4xx_pci.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
cpu/ppc4xx/4xx_pci.c +9 -2
index 33dd743..4b5d636 100644
@@ -337,8 +337,15 @@ void pci_405gp_init(struct pci_controller *hose)
 	}
 #endif
 
-#if defined(CONFIG_405EP) /* on ppc405ep vendor id is not set */
-	pci_write_config_word(PCIDEVID_405GP, PCI_VENDOR_ID, 0x1014); /* IBM */
+#if defined(CONFIG_405EP)
+	/*
+	 * on ppc405ep vendor/device id is not set
+	 * The user manual says 0x1014 (IBM) / 0x0156 (405GP!)
+	 * are the correct values.
+	 */
+	pci_write_config_word(PCIDEVID_405GP, PCI_VENDOR_ID, PCI_VENDOR_ID_IBM);
+	pci_write_config_word(PCIDEVID_405GP,
+			      PCI_DEVICE_ID, PCI_DEVICE_ID_IBM_405GP);
 #endif
 
 	/*
Signature · 1 line
1.6.1
#1 lore raw

PATCH 1/1 ppc4xx: Set default PCI device ID for 405EP boards

Quoted 9 lines · On Wednesday 08 July 2009 15:31:57 Matthias Fuchs wrote:

Current code only sets the PCI vendor id to 0x1014 and leaved device id to 0x0000.

Ths patch ....
a) uses the correct PCI_VENDOR_ID_IBM macro for this
b) sets the default device ID as stated in the UM to 0x0156 by using PCI_DEVICE_ID_IBM_405GP for this.

Applied to u-boot-ppc4xx. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================