Skip to contentSkip to conversation

HTC Dream: qdsp support for staging

DISCUSSION Pavel Machek 3 participants 16 messages Jul 10, 2009 – Jul 18, 2009

lore
Share & tools
lore
#0 lore raw

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

You don't want to break it up into multiple patches? I'll do it if you don't want too ..

Daniel

#2 lore raw
Quoted 11 lines · Daniel Walker
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

You don't want to break it up into multiple patches? I'll do it if you don't want too ..

I don't know how much sense it makes to split it further... yes, I could probably split it per file or something but...

(Notice that this is going to be rewriten in staging, anyway, before merging into kernel proper...)
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
Quoted 10 lines · Pavel Machek
Quoted 9 lines · Daniel Walker
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Quoted 8 lines
Quoted 2 lines

You don't want to break it up into multiple patches? I'll do it if you don't want too ..

I don't know how much sense it makes to split it further... yes, I could probably split it per file or something but...

(Notice that this is going to be rewriten in staging, anyway, before merging into kernel proper...)

Your expecting a full re-write? From a quick look this stuff just looks like it needs some TLC ..

Daniel

#4 lore raw
Quoted 14 lines · Daniel Walker
Quoted 13 lines · Pavel Machek
Quoted 11 lines · Daniel Walker
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

You don't want to break it up into multiple patches? I'll do it if you don't want too ..

Quoted 8 lines
Quoted 5 lines

I don't know how much sense it makes to split it further... yes, I could probably split it per file or something but...

(Notice that this is going to be rewriten in staging, anyway, before merging into kernel proper...)

Your expecting a full re-write? From a quick look this stuff just looks like it needs some TLC ..

I don't know what TLC means.

I expect a lot of changes; I did not study it in great enough detail; but I suspect that the ammount of changes neccessary will drown any initial changesets, so I guess it is simpler to just merge it in one piece.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw
In reply to Pavel Machek
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Please don't compress patches :(

Your patch didn't have any way to actually build the code, care to respin it and add the proper Kconfig and Makefile hooks?

thanks,

greg k-h

#6 lore raw
Quoted 10 lines · Greg KH
Quoted 7 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Please don't compress patches :(

I had to -- in order to fit to lkml maillist limits.

Quoted 2 lines

Your patch didn't have any way to actually build the code, care to respin it and add the proper Kconfig and Makefile hooks?

Well, resending 100K+ patch to get 3 missing lines is somewhat "interesting"... and the problem is that proper Kconfig/Makefile hooks actually depend on order in which you apply the patches.

Would it be possible to just apply the 3 patches, with me supplying Kconfig/Makefile hooks in patch #4? That's sometimes used to aid bisectability, and it would save me quite a lot of work (and possible mistakes) that way.

[I'd hate to set up quilt just to get 3 lines in Makefile into the right series of 3 patches, and if I do it by hand there's chance of mistakes...]

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#7 lore raw
Quoted 8 lines · Pavel Machek
Quoted 7 lines · Greg KH
Quoted 6 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Please don't compress patches :(

I had to -- in order to fit to lkml maillist limits.

I have no such limits :)

Quoted 11 lines
Quoted 2 lines

Your patch didn't have any way to actually build the code, care to respin it and add the proper Kconfig and Makefile hooks?

Well, resending 100K+ patch to get 3 missing lines is somewhat "interesting"... and the problem is that proper Kconfig/Makefile hooks actually depend on order in which you apply the patches.

Would it be possible to just apply the 3 patches, with me supplying Kconfig/Makefile hooks in patch #4? That's sometimes used to aid bisectability, and it would save me quite a lot of work (and possible mistakes) that way.

Yes, that would be fine. Care to send all 4, I've purged the old ones from my queue.

thanks,

greg k-h

#8 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines · Pavel Machek
Quoted 7 lines · Greg KH
Quoted 6 lines · Pavel Machek

From: Iliyan Malchev <[email protected]>

QDSP code is neccessarry for communication with some hardware components on HTC Dream, including camera hardware. It also drives DSP coproccessor.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Please don't compress patches :(

I had to -- in order to fit to lkml maillist limits.

I have no such limits :)

Ok, first 3 patches of resend should be on the way. One of them is 300K, so I hope it gets through.

Quoted 7 lines
Quoted 4 lines

Would it be possible to just apply the 3 patches, with me supplying Kconfig/Makefile hooks in patch #4? That's sometimes used to aid bisectability, and it would save me quite a lot of work (and possible mistakes) that way.

Yes, that would be fine. Care to send all 4, I've purged the old ones from my queue.

Thanks!
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#11 lore raw

Re: HTC Dream for staging

Quoted 9 lines · Greg KH
Quoted 6 lines · Pavel Machek

Hi!

I guess I'm confused. I seem to recall that HTC Dream camera support was marged into staging, but I can't see it in
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
. Is my memory wrong am I looking at wrong tree?

I never merged it.

Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue for all that. They should be all in your inbox now.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#12 lore raw

Re: HTC Dream for staging

Quoted 9 lines · Pavel Machek
Quoted 8 lines · Greg KH
Quoted 6 lines · Pavel Machek

Hi!

I guess I'm confused. I seem to recall that HTC Dream camera support was marged into staging, but I can't see it in
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
. Is my memory wrong am I looking at wrong tree?

Quoted 4 lines
Quoted 1 line

I never merged it.

Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue for all that. They should be all in your inbox now.

I see 5 patches, but in the future, please number them to ensure that they are applied in the correct order.

thanks,

greg k-h

#13 lore raw

Re: HTC Dream for staging

Quoted 10 lines · Greg KH
Quoted 9 lines · Pavel Machek
Quoted 8 lines · Greg KH
Quoted 6 lines · Pavel Machek

Hi!

I guess I'm confused. I seem to recall that HTC Dream camera support was marged into staging, but I can't see it in
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=summary
. Is my memory wrong am I looking at wrong tree?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

I never merged it.

Ok, I guessed so. I sent it as patch #4, patch #5 adds makefile glue for all that. They should be all in your inbox now.

I see 5 patches, but in the future, please number them to ensure that they are applied in the correct order.

Ok... And, sorry for all the trouble.

(BTW: I do not see the patches in the git tree, yet, and the tree is labeled as "junk tree, please ignore". Should I just wait a bit? Or is staging maintained outside of git? Or should the description be updated?)

Thanks!
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#14 lore raw

Re: HTC Dream for staging

Quoted 4 lines · Pavel Machek

(BTW: I do not see the patches in the git tree, yet, and the tree is labeled as "junk tree, please ignore". Should I just wait a bit? Or is staging maintained outside of git? Or should the description be updated?)

Staging is a quilt tree .. In Linux-next Next/Trees has it listed as,

staging quilt http://kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-05-staging/

I guess it was once a git tree, but was changed over at some point.

Daniel

#15 lore raw

Re: HTC Dream for staging

Quoted 7 lines · Daniel Walker
Quoted 4 lines · Pavel Machek

(BTW: I do not see the patches in the git tree, yet, and the tree is labeled as "junk tree, please ignore". Should I just wait a bit? Or is staging maintained outside of git? Or should the description be updated?)

Quoted 5 lines

Staging is a quilt tree .. In Linux-next Next/Trees has it listed as,

staging quilt http://kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-05-staging/

I guess it was once a git tree, but was changed over at some point.

The "junk tree" you see is what I used to send stuff to Linus.

Use the quilt tree above, or linux-next, it has the stuff in it as well.

thanks,

greg k-h