Skip to contentSkip to conversation

Add missing memory barriers for correct operation of amon_cpu_start

PATCH New Raghu Gandham 1 participant 1 message Jul 10, 2009 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add missing memory barriers for correct operation of amon_cpu_start

From: Chris Dearman <[email protected]>

---

 arch/mips/mti-malta/malta-amon.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
arch/mips/mti-malta/malta-amon.c +4 -3
index df9e526..469d9b0 100644
@@ -70,11 +70,12 @@ void amon_cpu_start(int cpu,
 	launch->sp = sp;
 	launch->a0 = a0;
 
-	/* Make sure target sees parameters before the go bit */
-	smp_mb();
-
+	smp_wmb();              /* Target must see parameters before go */
 	launch->flags |= LAUNCH_FGO;
+	smp_wmb();              /* Target must see go before we poll  */
+
 	while ((launch->flags & LAUNCH_FGONE) == 0)
 		;
+	smp_rmb();      /* Target will be updating flags soon */
 	pr_debug("launch: cpu%d gone!\n", cpu);
 }