Skip to contentSkip to conversation

cfg80211: update misleading comment

PATCH In review Helmut Schaa 2 participants 2 messages Jul 10, 2009 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfg80211: update misleading comment

In cfg80211_scan_request n_channels refers to the total number of channels to scan. Update the misleading comment accordingly.

---

Maybe the comment is correct and it is just me who thinks it is misleading ;) but I just stumbled over that.

include/net/cfg80211.h +1 -1
index dba7874..d458972 100644
@@ -538,7 +538,7 @@ struct cfg80211_ssid {
  * @ssids: SSIDs to scan for (active scan only)
  * @n_ssids: number of SSIDs
  * @channels: channels to scan on.
- * @n_channels: number of channels for each band
+ * @n_channels: total number of channels to scan
  * @ie: optional information element(s) to add into Probe Request or %NULL
  * @ie_len: length of ie in octets
  * @wiphy: the wiphy this was for
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Helmut Schaa

In cfg80211_scan_request n_channels refers to the total number of channels to scan. Update the misleading comment accordingly.

---

Maybe the comment is correct and it is just me who thinks it is misleading ;) but I just stumbled over that.

Heh, not sure what I was thinking when writing that :)

Quoted 14 lines
include/net/cfg80211.h +1 -1
index dba7874..d458972 100644
@@ -538,7 +538,7 @@ struct cfg80211_ssid {
  * @ssids: SSIDs to scan for (active scan only)
  * @n_ssids: number of SSIDs
  * @channels: channels to scan on.
- * @n_channels: number of channels for each band
+ * @n_channels: total number of channels to scan
  * @ie: optional information element(s) to add into Probe Request or %NULL
  * @ie_len: length of ie in octets
  * @wiphy: the wiphy this was for