Skip to contentSkip to conversation

OneNAND IPL: Move u-boot-onenand linker script to common use

PATCH New Kyungmin Park 4 participants 11 messages Jul 11, 2009 – Jul 22, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

Use the common OneNAND linker script.

---

onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds
#8 lore raw

PATCH 1/1 Apollon board use common OneNAND IPL linker

Use common OneNAND IPL linker script.

---

onenand_ipl/board/apollon/Makefile +1 -1
index 49a8e90..f0744f6 100644
@@ -2,7 +2,7 @@
 include $(TOPDIR)/config.mk
 include $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/config.mk
 
-LDSCRIPT= $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/u-boot.onenand.lds
+LDSCRIPT= $(TOPDIR)/onenand_ipl/u-boot-onenand.lds
 LDFLAGS	= -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) $(PLATFORM_LDFLAGS)
 AFLAGS	+= -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL
 CFLAGS	+= -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL
#1 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Kyungmin Park

onenand_ipl/u-boot-onenand.lds

Quoted 8 lines · Kyungmin Park

Use the common OneNAND linker script.

---

onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds

this is arch specific
please move it to lib_arm/

Best Regards,
J.

#2 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Jean-Christophe PLAGNIOL-VILLARD

Hi,

Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD

onenand_ipl/u-boot-onenand.lds

Quoted 8 lines · Kyungmin Park

Use the common OneNAND linker script.

---

onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds

this is arch specific
please move it to lib_arm/

Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.

I think until other arch uses it, I want to place it at onenand_ipl directory. How do you think?

Thank you,
Kyungmin Park

#3 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

Quoted 2 lines · Kyungmin Park

Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.

There was nothing but powerpc in nand_spl at first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.

-Scott

#4 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Scott Wood
Quoted 7 lines · Scott Wood
Quoted 2 lines · Kyungmin Park

Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.

There was nothing but powerpc in nand_spl at first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.

Heh, we're already using onenand_ipl on our MIPS machines ;-)

Signature · 2 lines
Shinya Kuribayashi
NEC Electronics
#6 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Jean-Christophe PLAGNIOL-VILLARD

Hi,

Quoted 12 lines · Jean-Christophe PLAGNIOL-VILLARD

onenand_ipl/u-boot-onenand.lds

Quoted 8 lines · Kyungmin Park

Use the common OneNAND linker script.

---

onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds

this is arch specific
please move it to lib_arm/

I want to make a conclusion. Don't you change your mind? Please give
your opinion.

Thank you,
Kyungmin Park

#5 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Shinya Kuribayashi
Quoted 10 lines · Shinya Kuribayashi
Quoted 7 lines · Scott Wood
Quoted 2 lines · Kyungmin Park

Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.

There was nothing but powerpc in nand_spl at first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.

Heh, we're already using onenand_ipl on our MIPS machines ;-)

maybe mainline soon. ;-)

Best Regards,
J.

#7 lore raw

PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use

In reply to Kyungmin Park
Quoted 17 lines · Kyungmin Park

Hi,

Quoted 12 lines · Jean-Christophe PLAGNIOL-VILLARD

onenand_ipl/u-boot-onenand.lds

Quoted 8 lines · Kyungmin Park

Use the common OneNAND linker script.

---

onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds

this is arch specific
please move it to lib_arm/

Quoted 2 lines

I want to make a conclusion. Don't you change your mind? Please give
your opinion.

as point out by Shinya-san & Scott too other can use it and use it today so please make it generic

Best Regards,
J.