OneNAND IPL: Move u-boot-onenand linker script to common use
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
Use the common OneNAND linker script.
---
onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0 -0
PATCH 1/1 Apollon board use common OneNAND IPL linker
Use common OneNAND IPL linker script.
---
onenand_ipl/board/apollon/Makefile +1 -1
@@ -2,7 +2,7 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/config.mk -LDSCRIPT= $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/u-boot.onenand.lds +LDSCRIPT= $(TOPDIR)/onenand_ipl/u-boot-onenand.lds LDFLAGS = -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) $(PLATFORM_LDFLAGS) AFLAGS += -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL CFLAGS += -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Kyungmin Parkonenand_ipl/u-boot-onenand.lds
Quoted 8 lines · Kyungmin Park
Use the common OneNAND linker script.
Signed-off-by Kyungmin Park <[email protected]>---
onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0
-0
this is arch specific
please move it to lib_arm/
Best Regards,
J.
PATCH 1/1 Apollon board use common OneNAND IPL linker
In reply to Kyungmin ParkQuoted 3 lines · Kyungmin Park
Use common OneNAND IPL linker script.
Signed-off-by Kyungmin Park <[email protected]>
please number the patch to known the apply order
Best Regards,
J.
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Jean-Christophe PLAGNIOL-VILLARDHi,
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
onenand_ipl/u-boot-onenand.lds
Quoted 8 lines · Kyungmin Park
Use the common OneNAND linker script.
Signed-off-by Kyungmin Park <[email protected]>---
onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0
-0this is arch specific
please move it to lib_arm/
Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.
I think until other arch uses it, I want to place it at onenand_ipl directory. How do you think?
Thank you,
Kyungmin Park
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
Quoted 2 lines · Kyungmin Park
Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.
There was nothing but powerpc in nand_spl at first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.
-Scott
PATCH 1/1 Apollon board use common OneNAND IPL linker
In reply to Jean-Christophe PLAGNIOL-VILLARDQuoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Kyungmin Park
Use common OneNAND IPL linker script.
Signed-off-by Kyungmin Park <[email protected]>please number the patch to known the apply order
Numbering won't help here -- they have to go in the same patch atomically, or else bisect will break.
-Scott
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Scott WoodQuoted 7 lines · Scott Wood
Quoted 2 lines · Kyungmin Park
Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.
There was nothing but powerpc in
nand_splat first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.
Heh, we're already using onenand_ipl on our MIPS machines ;-)
Signature · 2 lines
Shinya Kuribayashi NEC Electronics
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Jean-Christophe PLAGNIOL-VILLARDHi,
Quoted 12 lines · Jean-Christophe PLAGNIOL-VILLARD
onenand_ipl/u-boot-onenand.lds
Quoted 8 lines · Kyungmin Park
Use the common OneNAND linker script.
Signed-off-by Kyungmin Park <[email protected]>---
onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0
-0this is arch specific
please move it to lib_arm/
I want to make a conclusion. Don't you change your mind? Please give
your opinion.
Thank you,
Kyungmin Park
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Shinya KuribayashiQuoted 10 lines · Shinya Kuribayashi
Quoted 7 lines · Scott Wood
Quoted 2 lines · Kyungmin Park
Basically I agree your opinion, however do see the other arch OneNAND usage? I mean I can't see the other arch patches.
There was nothing but powerpc in
nand_splat first, but I don't think ARM developers would have appreciated finding hardcoded powerpc assumptions when they tried to add their boards.Heh, we're already using
onenand_iplon our MIPS machines ;-)
maybe mainline soon. ;-)
Best Regards,
J.
PATCH 1/1 OneNAND IPL: Move u-boot-onenand linker script to common use
In reply to Kyungmin ParkQuoted 17 lines · Kyungmin Park
Hi,
Quoted 12 lines · Jean-Christophe PLAGNIOL-VILLARD
onenand_ipl/u-boot-onenand.lds
Quoted 8 lines · Kyungmin Park
Use the common OneNAND linker script.
Signed-off-by Kyungmin Park <[email protected]>---
onenand_ipl/u-boot-onenand.lds renamed from onenand_ipl/board/apollon/u-boot.onenand.lds +0
-0this is arch specific
please move it to lib_arm/
Quoted 2 lines
I want to make a conclusion. Don't you change your mind? Please give
your opinion.
as point out by Shinya-san & Scott too other can use it and use it today so please make it generic
Best Regards,
J.