Skip to contentSkip to conversation

stubdom: use TARGET_PAGE_SIZE

PATCH In review Christoph Egger 3 participants 3 messages Jul 20, 2009 – Jul 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stubdom: use TARGET_PAGE_SIZE

Hi!

Attached patch makes xenfbfront using TARGET_PAGE_SIZE instead of PAGE_SIZE. Found by build error on NetBSD (PAGE_SIZE isn't defined, but TARGET_PAGE_SIZE is).

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xenfbfront.c +5 -0
index 32761a5..743c065 100644
@@ -28,6 +28,11 @@ static DisplayChangeListener *dcl;
 
 extern uint32_t vga_ram_size;
 
+#ifdef CONFIG_STUBDOM
+#undef PAGE_SIZE
+#define PAGE_SIZE TARGET_PAGE_SIZE
+#endif
+
 int xenfb_connect_vkbd(const char *path)
 {
     kbd_path = strdup(path);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 17 lines
xenfbfront.c +5 -0
index 32761a5..743c065 100644
@@ -28,6 +28,11 @@ static DisplayChangeListener *dcl;
 
 extern uint32_t vga_ram_size;
 
+#ifdef CONFIG_STUBDOM
+#undef PAGE_SIZE
+#define PAGE_SIZE TARGET_PAGE_SIZE
+#endif
+
 int xenfb_connect_vkbd(const char *path)
 {
     kbd_path = strdup(path);
Quoted 2 lines

On Mon, 20 Jul 2009, Christoph Egger wrote:

I think the correct way to fix this is to substitute all the occurrences of PAGE_SIZE with XC_PAGE_SIZE in xenfbfront.c.

#2 lore raw

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] stubdom: use TARGET_PAGE_SIZE"):

Quoted 7 lines

[Christoph Egger]

xenfbfront.c static DisplayChangeListener *dcl; · line 34

Quoted 3 lines
xenfbfront.c +3 -0
+#undef PAGE_SIZE
+#define PAGE_SIZE TARGET_PAGE_SIZE
+#endif

I think the correct way to fix this is to substitute all the occurrences of PAGE_SIZE with XC_PAGE_SIZE in xenfbfront.c.

Thanks for the suggestion. I agree so I've done that.

Ian.