Skip to contentSkip to conversation

lcd.h: define extern vidinfo_t for all cases

PATCH New Alessandro Rubini 3 participants 3 messages Jul 21, 2009 – Jul 26, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lcd.h: define extern vidinfo_t for all cases

From: Alessandro Rubini <[email protected]>

include/lcd.h has different vidinfo for different platforms, and several extern declaration, but one for the default case was missing. This makes them a single extern declaration for everyone.

---
 include/lcd.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
include/lcd.h +2 -6
index f054cac..8048419 100644
@@ -75,8 +75,6 @@ typedef struct vidinfo {
 	u_char	vl_wbf;		/* Wait between frames */
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #elif defined CONFIG_PXA250
 /*
  * PXA LCD DMA descriptor
@@ -146,8 +144,6 @@ typedef struct vidinfo {
 	struct	pxafb_info pxa;
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #elif defined(CONFIG_ATMEL_LCD)
 
 typedef struct vidinfo {
@@ -173,8 +169,6 @@ typedef struct vidinfo {
 	u_long	mmio;		/* Memory mapped registers */
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #else
 
 typedef struct vidinfo {
@@ -190,6 +184,8 @@ typedef struct vidinfo {
 
 #endif /* CONFIG_MPC823, CONFIG_PXA250 or CONFIG_MCC200 or CONFIG_ATMEL_LCD */
 
+extern vidinfo_t panel_info;
+
 /* Video functions */
 
 #if defined(CONFIG_RBC823)
Signature · 1 line
1.6.0.2
#1 lore raw

PATCH 1/1 lcd.h: define extern vidinfo_t for all cases

Quoted 10 lines · Alessandro Rubini

From: Alessandro Rubini <[email protected]>

include/lcd.h has different vidinfo for different platforms, and several extern declaration, but one for the default case was missing. This makes them a single extern declaration for everyone.

---
 include/lcd.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

Best Regards,
J.

#2 lore raw

PATCH 1/1 lcd.h: define extern vidinfo_t for all cases

In reply to Alessandro Rubini
Quoted 10 lines · Alessandro Rubini

From: Alessandro Rubini <[email protected]>

include/lcd.h has different vidinfo for different platforms, and several extern declaration, but one for the default case was missing. This makes them a single extern declaration for everyone.

---
 include/lcd.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

Applied to u-boot-video. Thanks!

Best regards,
Anatolij