Skip to contentSkip to conversation

GART_IOMMU without AGP

PATCH Pavel Vasilyev 4 participants 9 messages Jul 22, 2009 x86

lore
Share & tools
lore
#0 lore raw

In the kernel configuration, if I choose x86_64 and PCI, then choose the item "Garth IOMMU support", which, in turn, chooses not to switch off, support for AGP. But many IOMMU system does not have AGP bus.

arch/x86/Kconfig +0 -1
index 738bdc6..410369d 100644
@@ -585,7 +585,6 @@ config GART_IOMMU
 	bool "GART IOMMU support" if EMBEDDED
 	default y
 	select SWIOTLB
-	select AGP
 	depends on X86_64 && PCI
 	---help---
 	  Support for full DMA access of devices with 32bit memory access only
#1 lore raw
Quoted 3 lines · Pavel Vasilyev

In the kernel configuration, if I choose x86_64 and PCI, then choose the item "Garth IOMMU support", which, in turn, chooses not to switch off, support for AGP. But many IOMMU system does not have AGP bus.

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

Dave

#2 lore raw
Quoted 2 lines · On Thursday 23 July 2009 01:37:46 Dave Jones wrote:

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

Fine. But if I do not have AGP-card, why do I need the support of bus AGP? :) It may allow the user to the toggle on or off when needed.

#5 lore raw
In reply to Dave Jones
Quoted 7 lines · On Wed, 22 Jul 2009 17:37:46 -0400 Dave Jones <[email protected]> wrote:
Quoted 3 lines · Pavel Vasilyev

In the kernel configuration, if I choose x86_64 and PCI, then choose the item "Garth IOMMU support", which, in turn, chooses not to switch off, support for AGP. But many IOMMU system does not have AGP bus.

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

And the user is selecting CONFIG_AGP to select AGP devices rather than to demonstrate their deep guru grade knowledge of K8 northbridges. Not only that but CONFIG_AGP controls the display of AGP video card options so it is a selection for offered devices not really an internal detail.

So I think Pavel is right here.

#3 lore raw
In reply to Pavel Vasilyev
Quoted 6 lines · Pavel Vasilyev
Quoted 2 lines · On Thursday 23 July 2009 01:37:46 Dave Jones wrote:

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

Fine. But if I do not have AGP-card, why do I need the support of bus AGP? :) It may allow the user to the toggle on or off when needed.

For those that _do_ have an AGP bus, it's mandatory, as the aperture needs to be shared between IOMMU and video.

Removing the select creates a potential for people to load video drivers that don't come with the kernel to corrupt data as soon as something writes using the IOMMU.

For those that don't have an agp bus, it costs about 20k of code. Is this really that big a concern ?

Dave

#6 lore raw
In reply to Alan Cox
Quoted 8 lines · Alan Cox
Quoted 5 lines · On Wed, 22 Jul 2009 17:37:46 -0400 Dave Jones <[email protected]> wrote:
Quoted 3 lines · Pavel Vasilyev

In the kernel configuration, if I choose x86_64 and PCI, then choose the item "Garth IOMMU support", which, in turn, chooses not to switch off, support for AGP. But many IOMMU system does not have AGP bus.

Quoted 5 lines
Quoted 2 lines

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

And the user is selecting CONFIG_AGP to select AGP devices rather than to demonstrate their deep guru grade knowledge of K8 northbridges.

The user isn't selecting it at all. IOMMU is because it knows better than the user. "I'll turn this on for you, so that I don't corrupt your hard disk when you load a video driver" seems eminently sensible to me.

Quoted 3 lines

Not only
that but CONFIG_AGP controls the display of AGP video card options so it is a selection for offered devices not really an internal detail.

CONFIG_AGP has _nothing_ to do with video card options. It's entirely about the aperture.

Dave

#8 lore raw
In reply to Dave Jones
Quoted 7 lines · Dave Jones
Quoted 3 lines · Pavel Vasilyev

In the kernel configuration, if I choose x86_64 and PCI, then choose the item "Garth IOMMU support", which, in turn, chooses not to switch off, support for AGP. But many IOMMU system does not have AGP bus.

The lack of AGP slots doesn't mean a lack of AGP bus. It's part of the K8 on-CPU northbridge.

Right.

One thing that could be done today is to remove the "if EMBEDDED" for GART_IOMMU though. I don't think it's still deserved, as long as SWIOTLB is enabled.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#4 lore raw
In reply to Dave Jones
Quoted 3 lines

Removing the select creates a potential for people to load video drivers that don't come with the kernel to corrupt data as soon as something writes using the IOMMU.

"Video drivers that don't come with the kernel"

How about some specifics ?

#7 lore raw
In reply to Dave Jones

On Thursday 23 July 2009 02:28:07 Dave Jones wrote:
[cut]

Quoted 5 lines
Quoted 3 lines

Not only
that but CONFIG_AGP controls the display of AGP video card options so it is a selection for offered devices not really an internal detail.

CONFIG_AGP has _nothing_ to do with video card options.

For example, proprietary nvidia driver needed struct agp_bridges, exported from drivers/char/agp/backend.c

After loading the nvidia, load agpgart (if CONFIG_AGP set as module)