ARM Pull Request
Hi Wolfgang,
this pull request need that ben send it's pull request for net first as multiple patch depend on it
Ben do you plan to send it soon?
Please pull
The following changes since commit 462b1038738dd86f8dd70595f250ce792e90d244:
Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians
are available in the git repository at:
git://git.denx.de/u-boot-arm.git master
Dieter Kiermaier (1):
Kirkwood: add Marvell Kirkwood gpio driver
Heiko Schocher (2):
arm, kirkwood: added KW_TWSI_BASE in kirkwood.h arm, kirkwood: added kw_gpio_set_valid() in gpio.h
Minkyu Kang (1):
ARM Cortex A8: Move OMAP3 specific reset handler
Piotr Ziecik (1):
api: Fix broken build on ARM.
Prafulla Wadaskar (3):
Marvell Sheevaplug Board support
Marvell MV88F6281GTW_GE Board support
Marvell RD6281A Board support
Simon Kagstrom (1):
Add unaligned.h for arm
Wolfgang Denk (1):
at91cap9adk: fix #ifdef/#endif pairing
MAINTAINERS | 6 + MAKEALL | 3 + Makefile | 10 +- api/api_platform-arm.c | 2 - board/Marvell/mv88f6281gtw_ge/Makefile | 51 ++++++ board/Marvell/mv88f6281gtw_ge/config.mk | 25 +++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 141 ++++++++++++++++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h | 36 ++++ board/Marvell/rd6281a/Makefile | 51 ++++++ board/Marvell/rd6281a/config.mk | 25 +++ board/Marvell/rd6281a/rd6281a.c | 179 ++++++++++++++++++++ board/Marvell/rd6281a/rd6281a.h | 41 +++++ board/Marvell/sheevaplug/Makefile | 51 ++++++ board/Marvell/sheevaplug/config.mk | 25 +++ board/Marvell/sheevaplug/sheevaplug.c | 155 ++++++++++++++++++ board/Marvell/sheevaplug/sheevaplug.h | 41 +++++ cpu/arm_cortexa8/omap3/Makefile | 1 + cpu/arm_cortexa8/omap3/reset.S | 36 ++++ cpu/arm_cortexa8/start.S | 14 -- drivers/gpio/Makefile | 1 + drivers/gpio/kw_gpio.c | 151 +++++++++++++++++ include/asm-arm/arch-kirkwood/gpio.h | 53 ++++++ include/asm-arm/arch-kirkwood/kirkwood.h | 1 + include/asm-arm/unaligned.h | 18 ++ include/configs/at91cap9adk.h | 2 +- include/configs/mv88f6281gtw_ge.h | 200 +++++++++++++++++++++++ include/configs/rd6281a.h | 198 ++++++++++++++++++++++ include/configs/sheevaplug.h | 195 ++++++++++++++++++++++ 28 files changed, 1694 insertions(+), 18 deletions(-) create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h create mode 100644 board/Marvell/rd6281a/Makefile create mode 100644 board/Marvell/rd6281a/config.mk create mode 100644 board/Marvell/rd6281a/rd6281a.c create mode 100644 board/Marvell/rd6281a/rd6281a.h create mode 100644 board/Marvell/sheevaplug/Makefile create mode 100644 board/Marvell/sheevaplug/config.mk create mode 100644 board/Marvell/sheevaplug/sheevaplug.c create mode 100644 board/Marvell/sheevaplug/sheevaplug.h create mode 100644 cpu/arm_cortexa8/omap3/reset.S create mode 100644 drivers/gpio/kw_gpio.c create mode 100644 include/asm-arm/arch-kirkwood/gpio.h create mode 100644 include/asm-arm/unaligned.h create mode 100644 include/configs/mv88f6281gtw_ge.h create mode 100644 include/configs/rd6281a.h create mode 100644 include/configs/sheevaplug.h
Best Regards,
J.
Wolfgang Denk
AppliedDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 80 lines · In message <[email protected]> you wrote:
Hi Wolfgang,
this pull request need that ben send it's pull request for net first as multiple patch depend on it
Ben do you plan to send it soon?
Please pull
The following changes since commit462b1038738dd86f8dd70595f250ce792e90d244:
Wolfgang Denk (1):
Merge branch 'master' of/home/wd/git/u-boot/custodiansare available in the git repository at:
git://git.denx.de/u-boot-arm.gitmasterDieter Kiermaier (1):
Kirkwood: add Marvell Kirkwood gpio driverHeiko Schocher (2):
arm, kirkwood: addedKW_TWSI_BASEinkirkwood.harm, kirkwood: addedkw_gpio_set_valid()ingpio.hMinkyu Kang (1):
ARM Cortex A8: Move OMAP3 specific reset handlerPiotr Ziecik (1):
api: Fix broken build on ARM.Prafulla Wadaskar (3):
Marvell Sheevaplug Board support
MarvellMV88F6281GTW_GEBoard support
Marvell RD6281A Board supportSimon Kagstrom (1):
Addunaligned.hfor armWolfgang Denk (1):
at91cap9adk: fix #ifdef/#endif pairingMAINTAINERS | 6 + MAKEALL | 3 + Makefile | 10 +- api/api_platform-arm.c | 2 - board/Marvell/mv88f6281gtw_ge/Makefile | 51 ++++++ board/Marvell/mv88f6281gtw_ge/config.mk | 25 +++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 141 ++++++++++++++++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h | 36 ++++ board/Marvell/rd6281a/Makefile | 51 ++++++ board/Marvell/rd6281a/config.mk | 25 +++ board/Marvell/rd6281a/rd6281a.c | 179 ++++++++++++++++++++ board/Marvell/rd6281a/rd6281a.h | 41 +++++ board/Marvell/sheevaplug/Makefile | 51 ++++++ board/Marvell/sheevaplug/config.mk | 25 +++ board/Marvell/sheevaplug/sheevaplug.c | 155 ++++++++++++++++++ board/Marvell/sheevaplug/sheevaplug.h | 41 +++++ cpu/arm_cortexa8/omap3/Makefile | 1 + cpu/arm_cortexa8/omap3/reset.S | 36 ++++ cpu/arm_cortexa8/start.S | 14 -- drivers/gpio/Makefile | 1 + drivers/gpio/kw_gpio.c | 151 +++++++++++++++++ include/asm-arm/arch-kirkwood/gpio.h | 53 ++++++ include/asm-arm/arch-kirkwood/kirkwood.h | 1 + include/asm-arm/unaligned.h | 18 ++ include/configs/at91cap9adk.h | 2 +- include/configs/mv88f6281gtw_ge.h | 200 +++++++++++++++++++++++ include/configs/rd6281a.h | 198 ++++++++++++++++++++++ include/configs/sheevaplug.h | 195 ++++++++++++++++++++++ 28 files changed, 1694 insertions(+), 18 deletions(-) create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h create mode 100644 board/Marvell/rd6281a/Makefile create mode 100644 board/Marvell/rd6281a/config.mk create mode 100644 board/Marvell/rd6281a/rd6281a.c create mode 100644 board/Marvell/rd6281a/rd6281a.h create mode 100644 board/Marvell/sheevaplug/Makefile create mode 100644 board/Marvell/sheevaplug/config.mk create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
Quoted 8 lines
create mode 100644 board/Marvell/sheevaplug/sheevaplug.h create mode 100644 cpu/arm_cortexa8/omap3/reset.S create mode 100644 drivers/gpio/kw_gpio.c create mode 100644 include/asm-arm/arch-kirkwood/gpio.h create mode 100644 include/asm-arm/unaligned.h create mode 100644 include/configs/mv88f6281gtw_ge.h create mode 100644 include/configs/rd6281a.h create mode 100644 include/configs/sheevaplug.h
Applied, thanks.
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have mnore stuff queued? If so, when will it be ready for pulling?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.
Quoted 7 lines
Applied, thanks.
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have mnore stuff queued? If so, when will it be ready for pulling?
Ilya Yanok patch which need ack from Scoot and Ben
a at91rm9200 cleanup which cant wait a after rc1 as I want to test it on rm9200ek this WE
and maybe few other fix patch we can be handle later
but I would like we include Alessandro patch and Prafulla kwimage for this release not necessarely before rc1
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 3 lines
Or do you have mnore stuff queued? If so, when will it be ready for pulling?
Ilya Yanok patch which need ack from Scoot and Ben
a at91rm9200 cleanup which cant wait a after rc1 as I want to test it on rm9200ek this WE
and maybe few other fix patch we can be handle later
Um... nothing else? What about all the pending OMAP3 patches?
Quoted 2 lines
but I would like we include Alessandro patch and Prafulla kwimage for this release not necessarely before rc1
Please leave the kwimage patch for me; this is not ARM related, but affects pretty much global code only.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A conservative is a man who believes that nothing should be done for the first time. - Alfred E. Wiggam
Quoted 25 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Denk
Sent: Thursday, July 23, 2009 10:49 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: U-Boot; Ben Warren
Subject: Re: [U-Boot] ARM Pull RequestDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Or do you have mnore stuff queued? If so, when will it be
ready for
Quoted 4 lines
Quoted 1 line
pulling?
Ilya Yanok patch which need ack from Scoot and Ben
a at91rm9200 cleanup which cant wait a after rc1 as I want
to test it
Quoted 3 lines
on rm9200ek this WE
and maybe few other fix patch we can be handle later
Quoted 8 lines
Um... nothing else? What about all the pending OMAP3 patches?
Quoted 1 line
but I would like we include Alessandro patch and Prafulla
kwimage for
Quoted 1 line
this release not necessarely before rc1
Please leave the kwimage patch for me; this is not ARM related, but affects pretty much global code only.
Dear Jean,
As suggested by wolfgang,
I am re-structuring mkimage for code cleanup and to use function pointers, so that kwbimage and any other similar support can be added seamlessly. Hopefully I will send patches early next week.
Thanks and regards...
Prafulla . .
Quoted 17 lines
Best regards,
Wolfgang Denk
Signature · 10 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A conservative is a man who believes that nothing should be done for the first time. - Alfred E. Wiggam _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Quoted 25 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Denk
Sent: Thursday, July 23, 2009 10:49 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: U-Boot; Ben Warren
Subject: Re: [U-Boot] ARM Pull RequestDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Or do you have mnore stuff queued? If so, when will it be
ready for
Quoted 4 lines
Quoted 1 line
pulling?
Ilya Yanok patch which need ack from Scoot and Ben
a at91rm9200 cleanup which cant wait a after rc1 as I want
to test it
Quoted 3 lines
on rm9200ek this WE
and maybe few other fix patch we can be handle later
Quoted 8 lines
Um... nothing else? What about all the pending OMAP3 patches?
Quoted 1 line
but I would like we include Alessandro patch and Prafulla
kwimage for
Quoted 1 line
this release not necessarely before rc1
Please leave the kwimage patch for me; this is not ARM related, but affects pretty much global code only.
Dear Wolfgang
Hopefully you might have received my new patch series (posted 30 hours back)
I know it's very busy time for you.
But that's my wish to see this stuff in.
Please let me know your valued feedback so that I can help to get this stuff IN this release.
FYI: I tried to fulfill all points raised by you in earlier feedback.
Also some code reused from image.c/h for kwbimage in clean way
Though the entire resulting code will look different since there are lot changes, I tired to maintain smaller patches for easy understanding and acceptance
Regards..
Prafulla . .
Quoted 17 lines
Best regards,
Wolfgang Denk
Signature · 10 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A conservative is a man who believes that nothing should be done for the first time. - Alfred E. Wiggam _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Dear Prafulla Wadaskar,
Quoted 3 lines · In message <[email protected]>…
Hopefully you might have received my new patch series (posted 30 hours back) I know it's very busy time for you.
I received it, but did not have time for a thorough review yet. Sorry.
Quoted 2 lines
But that's my wish to see this stuff in.
Please let me know your valued feedback so that I can help to get this stuff IN this release.
That hould work out well. We still have sufficient time.
Quoted 3 lines
FYI: I tried to fulfill all points raised by you in earlier feedback.
Also some code reused from image.c/h for kwbimage in clean way
Though the entire resulting code will look different since there are lot changes, I tired to maintain smaller patches for easy understanding and acceptance
Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...and the fully armed nuclear warheads, are, of course, merely a courtesy detail."
Quoted 20 lines
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Thursday, July 30, 2009 4:02 AM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot; Ben Warren; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] ARM Pull RequestDear Prafulla Wadaskar,
In message <[email protected].
Quoted 2 lines · com> you wrote:
Hopefully you might have received my new patch series
(posted 30 hours
Quoted 1 line
back) I know it's very busy time for you.
Quoted 7 lines
I received it, but did not have time for a thorough review yet. Sorry.
Quoted 2 lines
But that's my wish to see this stuff in.
Please let me know your valued feedback so that I can helpto get this stuff IN this release.
That should work out well. We still have sufficient time.
Dear Wolfgang
Ping :-)
I do have some more updates for these patches,
I was waiting for your feedback so that I can reduce number of spins :-)
Regards..
Prafulla . .
Quoted 22 lines
Quoted 2 lines
FYI: I tried to fulfill all points raised by you in earlier
feedback.
Quoted 1 line
Also some code reused from image.c/h for kwbimage in clean
way Though
Quoted 3 lines
the entire resulting code will look different since there are lot changes, I tired to maintain smaller patches for easy understanding and acceptance
Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...and the fully armed nuclear warheads, are, of course, merely a courtesy detail."
Quoted 113 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Denk
Sent: Thursday, July 23, 2009 4:35 AM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: U-Boot; Ben Warren
Subject: Re: [U-Boot] ARM Pull RequestDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 3 lines · In message <[email protected]> you wrote:
Hi Wolfgang,
this pull request need that ben send it's pull request for
net first
Quoted 6 lines
as multiple patch depend on it
Ben do you plan to send it soon?
Please pull
The following changes since commit
462b1038738dd86f8dd70595f250ce792e90d244:Quoted 31 lines
Wolfgang Denk (1):
Merge branch 'master' of/home/wd/git/u-boot/custodiansare available in the git repository at:
git://git.denx.de/u-boot-arm.gitmasterDieter Kiermaier (1):
Kirkwood: add Marvell Kirkwood gpio driverHeiko Schocher (2):
arm, kirkwood: addedKW_TWSI_BASEinkirkwood.harm, kirkwood: addedkw_gpio_set_valid()ingpio.hMinkyu Kang (1):
ARM Cortex A8: Move OMAP3 specific reset handlerPiotr Ziecik (1):
api: Fix broken build on ARM.Prafulla Wadaskar (3):
Marvell Sheevaplug Board support MarvellMV88F6281GTW_GEBoard support Marvell RD6281A Board supportSimon Kagstrom (1):
Addunaligned.hfor armWolfgang Denk (1):
at91cap9adk: fix #ifdef/#endif pairingQuoted 7 lines
MAINTAINERS | 6 + MAKEALL | 3 + Makefile | 10 +- api/api_platform-arm.c | 2 - board/Marvell/mv88f6281gtw_ge/Makefile | 51 ++++++ board/Marvell/mv88f6281gtw_ge/config.mk | 25 +++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 141++++++++++++++++
Quoted 4 lines
board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h | 36 ++++ board/Marvell/rd6281a/Makefile | 51 ++++++ board/Marvell/rd6281a/config.mk | 25 +++ board/Marvell/rd6281a/rd6281a.c | 179++++++++++++++++++++
Quoted 4 lines
board/Marvell/rd6281a/rd6281a.h | 41 +++++ board/Marvell/sheevaplug/Makefile | 51 ++++++ board/Marvell/sheevaplug/config.mk | 25 +++ board/Marvell/sheevaplug/sheevaplug.c | 155++++++++++++++++++
Quoted 6 lines
board/Marvell/sheevaplug/sheevaplug.h | 41 +++++ cpu/arm_cortexa8/omap3/Makefile | 1 + cpu/arm_cortexa8/omap3/reset.S | 36 ++++ cpu/arm_cortexa8/start.S | 14 -- drivers/gpio/Makefile | 1 + drivers/gpio/kw_gpio.c | 151+++++++++++++++++
Quoted 5 lines
include/asm-arm/arch-kirkwood/gpio.h | 53 ++++++ include/asm-arm/arch-kirkwood/kirkwood.h | 1 + include/asm-arm/unaligned.h | 18 ++ include/configs/at91cap9adk.h | 2 +- include/configs/mv88f6281gtw_ge.h | 200+++++++++++++++++++++++
Quoted 1 line
include/configs/rd6281a.h | 198++++++++++++++++++++++
Quoted 1 line
include/configs/sheevaplug.h | 195++++++++++++++++++++++
Quoted 6 lines
28 files changed, 1694 insertions(+), 18 deletions(-) create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h create mode 100644 board/Marvell/rd6281a/Makefile createmode 100644
Quoted 8 lines
board/Marvell/rd6281a/config.mk create mode 100644 board/Marvell/rd6281a/rd6281a.c create mode 100644 board/Marvell/rd6281a/rd6281a.h create mode 100644 board/Marvell/sheevaplug/Makefile create mode 100644 board/Marvell/sheevaplug/config.mk create mode 100644 board/Marvell/sheevaplug/sheevaplug.c create mode 100644 board/Marvell/sheevaplug/sheevaplug.h create mode 100644 cpu/arm_cortexa8/omap3/reset.S createmode 100644
Quoted 6 lines
drivers/gpio/kw_gpio.ccreate mode 100644include/asm-arm/arch-kirkwood/gpio.hcreate mode 100644 include/asm-arm/unaligned.h create mode 100644
include/configs/mv88f6281gtw_ge.hcreate mode 100644include/configs/rd6281a.hcreate mode 100644include/configs/sheevaplug.h
Quoted 7 lines
Applied, thanks.
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have mnore stuff queued? If so, when will it be ready for pulling?
Dear Wolfgang
The arm build is broken at this moment on u-boot.git/master
I have tested for kirkwood boards using nand (i.e. Sheevaplug and RD6281A) same should be the case for other ARM boards using NAND flash.
The following patches from jean needed for successful build. But those cannot be applied cleanly.
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=5b30fe639c3ca0141d78820be74ce26120056116
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=009130ac00f4679516c6bb5a20f9a97eec98e6bc
Hi Jean,
Can you please rework and include those in this release?
More references:
http://lists.denx.de/pipermail/u-boot/2009-July/055591.html
http://lists.denx.de/pipermail/u-boot/2009-June/055064.html
http://lists.denx.de/pipermail/u-boot/2009-July/055469.html
http://lists.denx.de/pipermail/u-boot/2009-July/056085.html
Regards..
Prafulla . .
Quoted 15 lines
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Prafulla Wadaskar,
Quoted 9 lines · In message <[email protected]>…
The arm build is broken at this moment on u-boot.git/master
I have tested for kirkwood boards using nand (i.e. Sheevaplug and RD6281A) same should be the case for other ARM boards using NAND flash.The following patches from jean needed for successful build. But those cannot be applied cleanly.
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=5b30fe639c3ca0141d78820be74ce26120056116
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=009130ac00f4679516c6bb5a20f9a97eec98e6bc
These have been rejected and will NOT make it into mainline.
I will post a different solution soon.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The optimum committee has no members.
- Norman AugustineQuoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.html
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.html
3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt v7_flush_dcache_all
http://lists.denx.de/pipermail/u-boot/2009-July/055543.html
http://lists.denx.de/pipermail/u-boot/2009-July/055544.html
-> Older patch applied, but this is still expected to be applied
4. PATCH: (Updated) Fix examples for OMAP3 boards...
http://lists.denx.de/pipermail/u-boot/2009-July/056270.html
Best regards
Dirk
Quoted 9 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
Quoted 7 lines
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.html
NACK I've already explain why I'll not change my mind
Quoted 8 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.html
this will no go through arm but i2c tree
Quoted 4 lines
3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt
v7_flush_dcache_all
http://lists.denx.de/pipermail/u-boot/2009-July/055543.html
http://lists.denx.de/pipermail/u-boot/2009-July/055544.html
change requested
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 8 lines
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.htmlNACK I've already explain why I'll not change my mind
Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables?
We don't have any such requirements on local names; I just re-read "Chapter 4: Naming" of the "CodingStyle", and cannot find any such restrictions or even hints either.
So if this is the only reason for your reject, I would like to ask you to reconsider.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de 8 Catfish = 1 Octo-puss
Quoted 11 lines · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 8 lines
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.html
Quoted 5 lines
Quoted 1 line
NACK I've already explain why I'll not change my mind
Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables?
not because I do not like it because there are not safe and must be omap3 specific and not generic for soc specific struct
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables?
not because I do not like it because there are not safe and must be omap3 specific and not generic for soc specific struct
We don't make any such restrictions in other, similar header files. Adding (artifical) prefixes like omap3_ as you requested just makes it more likely thatthe some declarations and code will be repeated elsewhere, just with a different name.
If you have a specific example, where you see existing or even likely name conflicts, then please show it. Otherwise I suggest we just leave the code as is.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to one instruction which doesn't work.
Quoted 10 lines · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Sorry if I have to ask, but I mostly lost track of the discussion. It seems you reject these patches just because you dislike the naming of some file-local data structures and variables?
not because I do not like it because there are not safe and must be omap3 specific and not generic for soc specific struct
Quoted 8 lines
We don't make any such restrictions in other, similar header files. Adding (artifical) prefixes like
omap3_as you requested just makes it more likely thatthe some declarations and code will be repeated elsewhere, just with a different name.If you have a specific example, where you see existing or even likely name conflicts, then please show it. Otherwise I suggest we just leave the code as is.
yes I have as we prepapre a gpio generic api for our need, which we will push Mainline we must not make omap3 so generic
we face the same problem with last stdio cleanup
so for this patch series is not an improvment but a regression
Best Regards,
J.
Dear Jean-Christophe,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 4 lines
If you have a specific example, where you see existing or even likely name conflicts, then please show it. Otherwise I suggest we just leave the code as is.
yes I have as we prepapre a gpio generic api for our need, which we will push Mainline we must not make omap3 so generic
we face the same problem with last stdio cleanup
Well, the simple rule is The early bird catches the worm.
You are referring to some code that nobody of us has ever seen yet, and which therefor is of absolutely no relevance here. We don't even know when it might be posted - next release? next year? - or if it has any chances of being accepted for mainline.
On the other hand, we have a patch that has been posted while the merge window was open, and that does not violate any of the rules we normally apply when reviewing patches.
The argument that it might cause naming conflicts with a potential patch that might be posted at some indeterminate future point of time is definitely not a reason for rejecting the patch.
Please clearly separate your roles as a developer and a custodian: the custodian Jean-Christophe is supposed to work based on real, existing patches. The custodian Jean-Christophe knows about the work of the developer Jean-Christophe only as much as anybody else - what has been posted on the mailing list.
I understand your situation - it's a pain if you have to rework a patch and if it's amount is growing, but that's the same fate any other developer is facing who doesn't get his stuff ready for the next merge window.
If this is your only concern about this patch I ask you to accept it. The poster is not supposed to suffer from this situation. Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A meeting is an event at which the minutes are kept and the hours are lost.
[U-Boot] Pending OMAP3 patches, was: ARM Pull Request
In reply to Jean-Christophe PLAGNIOL-VILLARDQuoted 9 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
Quoted 8 lines
Quoted 7 lines
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.htmlNACK I've already explain why I'll not change my mind
Thanks to Wolfgang helping with this!
Quoted 8 lines
Quoted 7 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.htmlthis will no go through arm but i2c tree
http://lists.denx.de/pipermail/u-boot/2009-July/056947.html
sounds different.
Heiko and Jean-Christophe: Could you please clarify on this?
Quoted 4 lines
Quoted 3 lines
3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt
v7_flush_dcache_all
http://lists.denx.de/pipermail/u-boot/2009-July/055543.html
http://lists.denx.de/pipermail/u-boot/2009-July/055544.htmlchange requested
If I understand the archives correctly, you requested a change only on the first patch, not on the second one?
Tom: Any news on this?
Please note that it is still expected to be applied:
http://lists.denx.de/pipermail/u-boot/2009-July/056859.html
Jean-Christophe: Seems you missed to comment on the fourth pending patch (?):
4. PATCH: (Updated) Fix examples for OMAP3 boards...
http://lists.denx.de/pipermail/u-boot/2009-July/056270.html
Best regards
Dirk
[U-Boot] Pending OMAP3 patches, was: ARM Pull Request
Quoted 40 lines · Dirk Behme
Quoted 9 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
Quoted 8 lines
Quoted 7 lines
My list of pending OMAP3 patches:
1. [PATCHv3 2-5/5] clean up omap3 configuration structs
http://lists.denx.de/pipermail/u-boot/2009-May/052943.html
http://lists.denx.de/pipermail/u-boot/2009-May/052945.html
http://lists.denx.de/pipermail/u-boot/2009-May/052944.html
http://lists.denx.de/pipermail/u-boot/2009-May/052946.htmlNACK I've already explain why I'll not change my mind
Thanks to Wolfgang helping with this!
Quoted 8 lines
Quoted 7 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.htmlthis will no go through arm but i2c tree
http://lists.denx.de/pipermail/u-boot/2009-July/056947.html
sounds different.
Heiko and Jean-Christophe: Could you please clarify on this?
Quoted 4 lines
Quoted 4 lines
3. [PATCH 1-2/2] V2 remove omap3 compiler warning wrt
v7_flush_dcache_all
http://lists.denx.de/pipermail/u-boot/2009-July/055543.html
http://lists.denx.de/pipermail/u-boot/2009-July/055544.html
Quoted 7 lines
Quoted 1 line
change requested
If I understand the archives correctly, you requested a change only on the first patch, not on the second one?
Tom: Any news on this?
I spent some time yesterday starting the cache.S file.
To verify I am going to compare, statically, the assembly produced by the c and S functions.
Tom
Hello Jean-Christophe,
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
My list of pending OMAP3 patches:
[...]
Quoted 8 lines
Quoted 7 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.htmlthis will no go through arm but i2c tree
Hmm.. only patch one changes i2c relevant source code files. The rest is more arm relevant ... see, also:
http://lists.denx.de/pipermail/u-boot/2009-July/056947.html
but if you give your Acked-by, I can pickup these patches.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 21 lines · Heiko Schocher
Hello Jean-Christophe,
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
My list of pending OMAP3 patches:
[...]
Quoted 7 lines
Quoted 7 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.html
Quoted 8 lines
Quoted 1 line
this will no go through arm but i2c tree
Hmm.. only patch one changes i2c relevant source code files. The rest is more arm relevant ... see, also:
http://lists.denx.de/pipermail/u-boot/2009-July/056947.html
but if you give your Acked-by, I can pickup these patches.
I've reply here
http://lists.denx.de/pipermail/u-boot/2009-July/057285.html
Acked-by but please add a note about the OMAP2 test plan
Best Regards,
J.
Hello Jean-Christophe, Tom,
Quoted 26 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 25 lines · Heiko Schocher
Hello Jean-Christophe,
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines · Dirk Behme
Quoted 1 line · Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD,
....
Quoted 5 lines
Umm... is this all for ARM for this merge window? I mean, could we release -rc1 from ARM's point of view now?
Or do you have more stuff queued? If so, when will it be ready for pulling?
My list of pending OMAP3 patches:
[...]
Quoted 8 lines
Quoted 7 lines
2. [PATCH 1-6/6]OMAP i2c and twl4030
http://lists.denx.de/pipermail/u-boot/2009-June/055072.html
http://lists.denx.de/pipermail/u-boot/2009-June/055073.html
http://lists.denx.de/pipermail/u-boot/2009-June/055074.html
http://lists.denx.de/pipermail/u-boot/2009-June/055075.html
http://lists.denx.de/pipermail/u-boot/2009-June/055076.html
http://lists.denx.de/pipermail/u-boot/2009-June/055077.htmlthis will no go through arm but i2c tree
Hmm.. only patch one changes i2c relevant source code files. The rest is more arm relevant ... see, also:
Quoted 7 lines
Quoted 3 lines
http://lists.denx.de/pipermail/u-boot/2009-July/056947.html
but if you give your Acked-by, I can pickup these patches.
I've reply here
http://lists.denx.de/pipermail/u-boot/2009-July/057285.htmlAcked-by but please add a note about the OMAP2 test plan
Applied this patchset to u-boot-i2c.git
Thanks.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany