x86: minor Makefile simplification through use of cc-ifversion
PATCH 1/1 x86: minor Makefile simplification through use of cc-ifversion
Signed-off-by Frans Pop <[email protected]>
---
Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
Tested to work correctly.
arch/x86/Makefile +2 -2
@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y) # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots: - KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); fi ;) + KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \ + $(call cc-option,-fno-unit-at-a-time)) # CPU-specific tuning. Anything which can be shared with UML should go here. include $(srctree)/arch/x86/Makefile_32.cpu
Quoted 1 line · Frans Pop
Signed-off-by Frans Pop <[email protected]>
Acked-by Sam Ravnborg <[email protected]>
Quoted 5 lines · Frans Pop
Signed-off-by Frans Pop <[email protected]>---
Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
Tested to work correctly.
Reviewed-by WANG Cong <[email protected]>
Quoted 21 lines
arch/x86/Makefile +2
-3@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y) # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots: - KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); fi ;) + KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \ + $(call cc-option,-fno-unit-at-a-time)) # CPU-specific tuning. Anything which can be shared with UML should go here. include $(srctree)/arch/x86/Makefile_32.cpu --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[tip:x86/kbuild] x86: Simplify the Makefile in a minor way through use of cc-ifversion
In reply to Frans PopCommit-ID: c7bd0414d681706a32105895cae20fb9090db52e Gitweb: http://git.kernel.org/tip/c7bd0414d681706a32105895cae20fb9090db52e Author: Frans Pop <[email protected]> AuthorDate: Thu, 23 Jul 2009 20:56:27 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 4 Aug 2009 14:32:24 +0200
x86: Simplify the Makefile in a minor way through use of cc-ifversion
Signed-off-by Frans Pop <[email protected]>
Acked-by Sam Ravnborg <[email protected]>
Reviewed-by WANG Cong <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- arch/x86/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/Makefile +2 -2
@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y) # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots: - KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); fi ;) + KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \ + $(call cc-option,-fno-unit-at-a-time)) # CPU-specific tuning. Anything which can be shared with UML should go here. include $(srctree)/arch/x86/Makefile_32.cpu