um: minor Makefile simplification through use of cc-ifversion
Subsystems (2)
PATCH 1/1 um: minor Makefile simplification through use of cc-ifversion
Signed-off-by Frans Pop <[email protected]>
---
Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
Untested, but a similar patch for x86 was tested to work.
arch/um/Makefile-i386 +4 -3
@@ -35,8 +35,9 @@ cflags-y += -ffreestanding # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots. Also, gcc # 4.3.0 needs -funit-at-a-time for extern inline functions. -KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); \ - else echo $(call cc-option,-funit-at-a-time); fi ;) +KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \ + $(call cc-option,-fno-unit-at-a-time)) +KBUILD_CFLAGS += $(call cc-ifversion, -ge, 0400, \ + $(call cc-option,-funit-at-a-time)) KBUILD_CFLAGS += $(cflags-y)
Quoted 1 line · Frans Pop
Signed-off-by Frans Pop <[email protected]>
Acked-by Sam Ravnborg <[email protected]>
If this patch is not pisked up by anyone else I will take it in kbuild.git.
Sam
Amerigo Wang
Acked-byQuoted 3 lines · Sam Ravnborg
Quoted 1 line · Frans Pop
Signed-off-by Frans Pop <[email protected]>Acked-by Sam Ravnborg <[email protected]>
Acked-by WANG Cong <[email protected]>
Quoted 2 lines
If this patch is not pisked up by anyone else I will take it in kbuild.git.
Thanks.
Hi Sam,
You planned to take any of these patches not picked up by arch maintainers in kbuild.git. This looks to be the only one not yet included in mainline.
Cheers,
FJP
Quoted 24 lines · Frans Pop
Signed-off-by Frans Pop <[email protected]>---
Change was suggested by Sam Ravnborg; see
http://lkml.org/lkml/2009/7/18/15. Untested, but a similar patch for x86 was tested to work.arch/um/Makefile-i386 +0
-0@@ -35,8 +35,9 @@ cflags-y += -ffreestanding # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots. Also,gcc # 4.3.0 needs -funit-at-a-time for extern inline functions.
arch/um/Makefile-i386 +4
-3-KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); \ - else echo $(call cc-option,-funit-at-a-time); fi ;) +KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \ + $(call cc-option,-fno-unit-at-a-time)) +KBUILD_CFLAGS += $(call cc-ifversion, -ge, 0400, \ + $(call cc-option,-funit-at-a-time)) KBUILD_CFLAGS += $(cflags-y)