nfs: remove superfluous BUG_ON()s
Subsystems (2)
PATCH 1/1 nfs: remove superfluous BUG_ON()s
From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] nfs: remove superfluous BUG_ON()s
Remove duplicated BUG_ON()s from nfs[4]_create_server() (we make the same checks earlier in both functions).
This takes care of the following entries from Dan's list:
fs/nfs/client.c +1078 nfs_create_server(47) warning: variable derefenced before check 'server->nfs_client' fs/nfs/client.c +1079 nfs_create_server(48) warning: variable derefenced before check 'server->nfs_client->rpc_ops' fs/nfs/client.c +1363 nfs4_create_server(43) warning: variable derefenced before check 'server->nfs_client' fs/nfs/client.c +1364 nfs4_create_server(44) warning: variable derefenced before check 'server->nfs_
--- fs/nfs/client.c | 8 -------- 1 file changed, 8 deletions(-)
fs/nfs/client.c +0 -8
@@ -1075,10 +1075,6 @@ struct nfs_server *nfs_create_server(con (unsigned long long ) server->fsid.major, (unsigned long long) server->fsid.minor); -BUG_ON (!server->nfs_client); -BUG_ON (!server->nfs_client->rpc_ops); -BUG_ON (!server->nfs_client->rpc_ops->file_inode_ops); -spin_lock (&nfs_client_lock);list_add_tail (&server->client_link, &server->nfs_client->cl_superblocks);list_add_tail (&server->master_link, &nfs_volume_list);
@@ -1360,10 +1356,6 @@ struct nfs_server *nfs4_create_server(coif (server->namelen ==0 || server->namelen >NFS4_MAXNAMLEN ) server->namelen =NFS4_MAXNAMLEN ; -BUG_ON (!server->nfs_client); -BUG_ON (!server->nfs_client->rpc_ops); -BUG_ON (!server->nfs_client->rpc_ops->file_inode_ops); -spin_lock (&nfs_client_lock);list_add_tail (&server->client_link, &server->nfs_client->cl_superblocks);list_add_tail (&server->master_link, &nfs_volume_list);
Quoted 13 lines · Bartlomiej Zolnierkiewicz
From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] nfs: remove superfluous BUG_ON()sRemove duplicated BUG_ON()s from nfs[4]_create_server() (we make the same checks earlier in both functions).
This takes care of the following entries from Dan's list:
fs/nfs/client.c+1078nfs_create_server(47)warning: variable derefenced before check 'server->nfs_client'fs/nfs/client.c+1079nfs_create_server(48)warning: variable derefenced before check 'server->nfs_client->rpc_ops'fs/nfs/client.c+1363nfs4_create_server(43)warning: variable derefenced before check 'server->nfs_client'fs/nfs/client.c+1364nfs4_create_server(44)warning: variable derefenced before check 'server->nfs_
Quoted 5 lines
Reported-by Dan Carpenter <[email protected]>Cc Julia Lawall <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Thanks! I will apply...
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com