x86: remove superfluous NULL pointer check in destroy_irq()
PATCH 1/1 x86: remove superfluous NULL pointer check in destroy_irq()
From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] x86: remove superfluous NULL pointer check in destroy_irq()
This takes care of the following entry from Dan's list:
arch/x86/kernel/apic/io_apic.c +3241 destroy_irq(11) warning: variable derefenced before check 'desc'
Reported-by Dan Carpenter <[email protected]>
Cc Julia Lawall <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
--- arch/x86/kernel/apic/io_apic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/x86/kernel/apic/io_apic.c +1 -2
@@ -3238,8 +3238,7 @@ void destroy_irq(unsigned int irq) cfg = desc->chip_data;dynamic_irq_cleanup (irq);/* connect back irq_cfg */ -if (desc) - desc->chip_data = cfg; + desc->chip_data = cfg;free_irte (irq);spin_lock_irqsave (&vector_lock, flags);
[tip:x86/apic] x86: Remove superfluous NULL pointer check in destroy_irq()
Commit-ID: 25f6e89bedd29cc49bfa0d55497e91a671b9ae6e Gitweb: http://git.kernel.org/tip/25f6e89bedd29cc49bfa0d55497e91a671b9ae6e Author: Bartlomiej Zolnierkiewicz <[email protected]> AuthorDate: Thu, 30 Jul 2009 23:21:18 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Sun, 2 Aug 2009 21:37:00 +0200
x86: Remove superfluous NULL pointer check in destroy_irq()
This takes care of the following entry from Dan's list:
arch/x86/kernel/apic/io_apic.c +3241 destroy_irq(11) warning: variable derefenced before check 'desc'
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Cc Julia Lawall <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- arch/x86/kernel/apic/io_apic.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86/kernel/apic/io_apic.c +1 -2
@@ -3185,8 +3185,7 @@ void destroy_irq(unsigned int irq) cfg = desc->chip_data;dynamic_irq_cleanup (irq);/* connect back irq_cfg */ -if (desc) - desc->chip_data = cfg; + desc->chip_data = cfg;free_irte (irq);spin_lock_irqsave (&vector_lock, flags);