microblaze: convert to asm-generic/hardirq.h

PATCH In review Christoph Hellwig 2 participants 4 messages Aug 4, 2009 – Aug 7, 2009 Microblaze architecture

lore

Share & tools

lore

Christoph Hellwig

author

2009-08-04 14:53 UTC #0 lore raw

PATCH 1/1 microblaze: convert to asm-generic/hardirq.h

Signed-off-by Christoph Hellwig <[email protected]>

arch/microblaze/include/asm/hardirq.h +0 -2

Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */

arch/microblaze/kernel/irq.c +0 -9

Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)

Michal Simek

maintainer

2009-08-06 14:55 UTC #1 lore raw

Hi Christoph,

Can you please change your patch title?
You are removing ack_bad_irq not convert to hardirq.h

But anyway will be worth to remove it from other archs too.

Thanks,
Michal

Quoted 42 lines · Christoph Hellwig

Signed-off-by Christoph Hellwig <[email protected]>
Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
arch/microblaze/include/asm/hardirq.h +0 -2
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
arch/microblaze/kernel/irq.c +0 -9
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)
___________________________
microblaze-uclinux mailing list
[email protected]
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/

Signature · 4 lines

Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Christoph Hellwig

author

2009-08-06 21:00 UTC #2 lore raw

Quoted 6 lines · Michal Simek

Hi Christoph,
Can you please change your patch title?
You are removing ack_bad_irq not convert to hardirq.h
But anyway will be worth to remove it from other archs too.

Oh sorry, I copied the patch from various other architectures I touched at the same time. I have been wading throug all architectures to convert them to asm-generic/hardirq.h and the generic ack_bad_irq and sent out lots of patches for it. A couple of architectures do count bad irqs instead of just printing a message, but even those counters could be unified. The only genirq architectecture that does something weird in ack_bad_irq is mips.

Subject: microblaze: use the generic ack_bad_irq implementation
From: Christoph Hellwig <[email protected]>

Signed-off-by Christoph Hellwig <[email protected]>

arch/microblaze/include/asm/hardirq.h +0 -2

Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */

arch/microblaze/kernel/irq.c +0 -9

Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)

Michal Simek

maintainer

2009-08-07 11:51 UTC #3 lore raw

Quoted 8 lines · Christoph Hellwig

Quoted 6 lines · Michal Simek
Hi Christoph,
Can you please change your patch title?
You are removing ack_bad_irq not convert to hardirq.h
But anyway will be worth to remove it from other archs too.

Quoted 7 lines

Oh sorry, I copied the patch from various other architectures I touched at the same time. I have been wading throug all architectures to convert them to asm-generic/hardirq.h and the generic ack_bad_irq and sent out lots of patches for it. A couple of architectures do count bad irqs instead of just printing a message, but even those counters could be unified. The only genirq architectecture that does something weird in ack_bad_irq is mips.

No worries. Added to next branch.

Thanks,
Michal

Quoted 49 lines

--
Subject: microblaze: use the generic ack_bad_irq implementation
From: Christoph Hellwig <[email protected]>
Signed-off-by Christoph Hellwig <[email protected]>
Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
arch/microblaze/include/asm/hardirq.h +0 -2
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
arch/microblaze/kernel/irq.c +0 -9
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)
___________________________
microblaze-uclinux mailing list
[email protected]
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/

Signature · 4 lines

Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian