Skip to contentSkip to conversation

chunkd: use port xxx82 to build

PATCH In review Pete Zaitcev 2 participants 6 messages Aug 5, 2009

lore
Share & tools
lore

Pete Zaitcev

author
#0 lore raw

PATCH 1/1 chunkd: use port xxx82 to build

Let's change build ports to xxx82 to deconflict with tabled.

Signed-off-by Pete Zaitcev <[email protected]>
test/server-test.cfg +2 -2
index 38fcc43..02c39d4 100644
@@ -5,11 +5,11 @@
 </SSL>
 
 <Listen>
-	<Port>18080</Port>
+	<Port>18082</Port>
 </Listen>
 
 <Listen>
-	<Port>28080</Port>
+	<Port>28082</Port>
 	<Encrypt>true</Encrypt>
 </Listen>
test/test.h +2 -2
index 46667aa..d5407d4 100644
@@ -9,8 +9,8 @@
 #define TEST_HOST "localhost"
 #define TEST_USER "testuser"
 #define TEST_USER_KEY "testuser"
-#define TEST_PORT 18080
-#define TEST_SSL_PORT 28080
+#define TEST_PORT 18082
+#define TEST_SSL_PORT 28082
 
 #define OK(expr)				\
 	do {					\
#1 lore raw
Quoted 27 lines · Pete Zaitcev

Let's change build ports to xxx82 to deconflict with tabled.

Signed-off-by Pete Zaitcev <[email protected]>
test/server-test.cfg +2 -2
index 38fcc43..02c39d4 100644
@@ -5,11 +5,11 @@
 </SSL>
 
 <Listen>
-	<Port>18080</Port>
+	<Port>18082</Port>
 </Listen>
 
 <Listen>
-	<Port>28080</Port>
+	<Port>28082</Port>
 	<Encrypt>true</Encrypt>
 </Listen>
test/test.h +0 -0
index 46667aa..d5407d4 100644

test/test.h line 13

Quoted 7 lines
test/test.h +2 -2
@@ -9,8 +9,8 @@
 #define TEST_HOST "localhost"
 #define TEST_USER "testuser"
 #define TEST_USER_KEY "testuser"
-#define TEST_PORT 18080
-#define TEST_SSL_PORT 28080
+#define TEST_PORT 18082
+#define TEST_SSL_PORT 28082

Speaking of conflicts... this patch does not apply to current upstream chunkd.

I manually fixed it up and applied it, working around recent changes in test/test.h

Jeff

#2 lore raw

Speaking of chunkd...

I don't think I will have time this week to fix chunkd's failure on big endian machines. If you (or anyone else listening...) have an opportunity to look into that, that would be most helpful.

Jeff

author
#5 lore raw
In reply to Jeff Garzik
Quoted 2 lines · Jeff Garzik

Speaking of conflicts... this patch does not apply to current upstream chunkd.

This is quite strange, but indeed I just pulled and testuser2 appeared. Sorry, this slipped somehow.

-- Pete

author
#3 lore raw
In reply to Jeff Garzik
Quoted 5 lines · Jeff Garzik

Speaking of chunkd...

I don't think I will have time this week to fix chunkd's failure on big endian machines. If you (or anyone else listening...) have an opportunity to look into that, that would be most helpful.

This looks like an ideal opportunity for Rick to read the code with a specific goal in mind, if he doesn't mind me saying so.

Do we have a bug number for it?

-- Pete

#4 lore raw
Quoted 8 lines · Pete Zaitcev
Quoted 3 lines · Jeff Garzik

Speaking of chunkd...

I don't think I will have time this week to fix chunkd's failure on big endian machines. If you (or anyone else listening...) have an opportunity to look into that, that would be most helpful.

This looks like an ideal opportunity for Rick to read the code with a specific goal in mind, if he doesn't mind me saying so.

CC'd :)

Quoted 1 line

Do we have a bug number for it?

https://bugzilla.redhat.com/show_bug.cgi?id=514651

Jeff