Skip to contentSkip to conversation

mac80211 TX frame alignment

DISCUSSION Ivo van Doorn 2 participants 3 messages Aug 4, 2009 – Aug 5, 2009

lore
Share & tools
lore
#0 lore raw

Hi Johannes,

Do you know if for outgoing frames the header should always be 4-byte aligned?
I have a bugreport from users claiming that master mode is failing for rt2500pci because the beacons passed to the driver are not 4-byte aligned which causes the device not to send out the beacons correctly.

I'm just wondering if this is something that should be fixed in the driver or in mac80211.

Thanks,

Ivo

#1 lore raw

Hi Ivo,

Quoted 2 lines

Do you know if for outgoing frames the header should always be 4-byte aligned?

I know that there's no alignment guarantee.

Quoted 7 lines

I have a bugreport from users claiming that master mode is failing for rt2500pci because the beacons passed to the driver are not 4-byte aligned which causes the device not to send out the beacons correctly.

I'm just wondering if this is something that should be fixed in the driver or in mac80211.

I don't think we can fix that in mac80211, since we don't know whether or not any alignment is required. We could align beacon frames, I suppose, since those are created on the fly, but not data frames.

johannes

#2 lore raw

Hi,

Quoted 10 lines
Quoted 2 lines

Do you know if for outgoing frames the header should always be 4-byte aligned?

I know that there's no alignment guarantee.

Quoted 5 lines

I have a bugreport from users claiming that master mode is failing for rt2500pci because the beacons passed to the driver are not 4-byte aligned which causes the device not to send out the beacons correctly.

Quoted 6 lines
Quoted 2 lines

I'm just wondering if this is something that should be fixed in the driver or in mac80211.

I don't think we can fix that in mac80211, since we don't know whether or not any alignment is required. We could align beacon frames, I suppose, since those are created on the fly, but not data frames.

Ok, I'll look into a patch for making sure rt2x00 aligns all frames correctly before mapping the DMA.

Thanks,

Ivo