Skip to contentSkip to conversation

pulse: immediately trigger EIO when connection is dropped

PATCH In review Lennart Poettering 2 participants 2 messages Aug 4, 2009

lore
Share & tools
lore

Lennart Poettering

author
#0 lore raw

PATCH 6/6 pulse: immediately trigger EIO when connection is dropped

When the connection is dropped notify the application immediately instead of waiting until the applications calls into us the next time.

This makes "aplay" handle connections shutdown similar to hardware
unplugs: an immediate EIO is thrown.

---
 pulse/pulse.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
pulse/pulse.c +8 -1
index 9c05171..a94caaf 100644
@@ -77,10 +77,17 @@ int pulse_wait_operation(snd_pulse_t * p, pa_operation * o)
 
 static void context_state_cb(pa_context * c, void *userdata)
 {
+	pa_context_state_t state;
 	snd_pulse_t *p = userdata;
 	assert(c);
 
-	switch (pa_context_get_state(c)) {
+	state = pa_context_get_state(c);
+
+	/* When we get disconnected, tell the process */x
+	if (!PA_CONTEXT_IS_GOOD(state))
+		pulse_poll_activate(p);
+
+	switch (state) {
 	case PA_CONTEXT_READY:
 	case PA_CONTEXT_TERMINATED:
 	case PA_CONTEXT_FAILED:
Signature · 10 lines
1.6.4



Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4
#1 lore raw

At Tue, 4 Aug 2009 23:56:00 +0200,

Quoted 7 lines · Lennart Poettering
pulse/pulse.c +0 -0
index 9c05171..a94caaf 100644
@@ -77,10 +77,17 @@ int pulse_wait_operation(snd_pulse_t * p, pa_operation * o)

pulse/pulse.c int pulse_wait_operation(snd_pulse_t * p, pa_operation * o) · line 86

Quoted 10 lines
pulse/pulse.c +4 -1
 static void context_state_cb(pa_context * c, void *userdata)
 {
+	pa_context_state_t state;
 	snd_pulse_t *p = userdata;
 	assert(c);
 
-	switch (pa_context_get_state(c)) {
+	state = pa_context_get_state(c);
+
+	/* When we get disconnected, tell the process */x

                                                        ^

This causes compile errors (already fixed manually :)

Takashi