bcm63xx: prepare for on-board watchdog support
PATCH 8/8 bcm63xx: prepare for on-board watchdog support
This patch registers the watchdog platform_device that we are going to use in the watchdog platform_driver in a subsequent patch.
---
arch/mips/bcm63xx/Makefile +1 -0
@@ -5,6 +5,7 @@ obj-y += dev-usb-ohci.o obj-y += dev-usb-ehci.o obj-y += dev-enet.o obj-y += dev-dsp.o +obj-y += dev-wdt.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += boards/
arch/mips/bcm63xx/boards/board_bcm963xx.c +2 -0
@@ -28,6 +28,7 @@#include <bcm63xx_dev_usb_ohci.h> #include <bcm63xx_dev_usb_ehci.h> #include <bcm63xx_dev_dsp.h> +#include <bcm63xx_dev_wdt.h> #include <board_bcm963xx.h> #define PFX "board_bcm963xx: "
@@ -798,6 +799,7 @@ int __init board_register_devices(void)u32 val;bcm63xx_uart_register (); +bcm63xx_wdt_register ();if (board.has_pccard)bcm63xx_pcmcia_register ();
arch/mips/bcm63xx/dev-wdt.c new file +36 -0
@@ -0,0 +1,36 @@ +/* +* This file is subject to the terms and conditions of the GNU General Public +* License. See the file "COPYING" in the main directory of this archive +* for more details. +* +* Copyright (C) 2008 Florian Fainelli <[email protected]> +*/ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> +#include <bcm63xx_cpu.h> + +static struct resource wdt_resources[] = { + { + .start =-1 ,/* filled at runtime */ + .end =-1 ,/* filled at runtime */ + .flags =IORESOURCE_MEM , + }, +}; + +static struct platform_device bcm63xx_wdt_device = { + .name ="bcm63xx-wdt" , + .id =0 , + .num_resources =ARRAY_SIZE (wdt_resources), + .resource = wdt_resources, +}; + +int __init bcm63xx_wdt_register (void ) +{ + wdt_resources[0 ].start =bcm63xx_regset_address (RSET_WDT ); + wdt_resources[0 ].end = wdt_resources[0 ].start; + wdt_resources[0 ].end +=RSET_WDT_SIZE -1 ; + +return platform_device_register (&bcm63xx_wdt_device); +}
arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h new file +6 -0
@@ -0,0 +1,6 @@ +#ifndef BCM63XX_DEV_WDT_H_ +#define BCM63XX_DEV_WDT_H_ + +int bcm63xx_wdt_register (void ); + +#endif /* BCM63XX_DEV_WDT_H_ */
Quoted 86 lines · Florian Fainelli
This patch registers the watchdog
platform_devicethat we are going to use in the watchdogplatform_driverin a subsequent patch.Signed-off-by Florian Fainelli <[email protected]>---
arch/mips/bcm63xx/Makefile +1
-0@@ -5,6 +5,7 @@ obj-y += dev-usb-ohci.o obj-y += dev-usb-ehci.o obj-y += dev-enet.o obj-y += dev-dsp.o +obj-y += dev-wdt.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += boards/arch/mips/bcm63xx/boards/board_bcm963xx.c +2
-0@@ -28,6 +28,7 @@#include <bcm63xx_dev_usb_ohci.h> #include <bcm63xx_dev_usb_ehci.h> #include <bcm63xx_dev_dsp.h> +#include <bcm63xx_dev_wdt.h> #include <board_bcm963xx.h> #define PFX "board_bcm963xx: "@@ -798,6 +799,7 @@ int __init board_register_devices(void)u32 val;bcm63xx_uart_register (); +bcm63xx_wdt_register ();if (board.has_pccard)bcm63xx_pcmcia_register ();arch/mips/bcm63xx/dev-wdt.c new file +36
-0@@ -0,0 +1,36 @@ +/* +* This file is subject to the terms and conditions of the GNU General Public +* License. See the file "COPYING" in the main directory of this archive +* for more details. +* +* Copyright (C) 2008 Florian Fainelli <[email protected]> +*/ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> +#include <bcm63xx_cpu.h> + +static struct resource wdt_resources[] = { + { + .start =-1 ,/* filled at runtime */ + .end =-1 ,/* filled at runtime */ + .flags =IORESOURCE_MEM , + }, +}; + +static struct platform_device bcm63xx_wdt_device = { + .name ="bcm63xx-wdt" , + .id =0 , + .num_resources =ARRAY_SIZE (wdt_resources), + .resource = wdt_resources, +}; + +int __init bcm63xx_wdt_register (void ) +{ + wdt_resources[0 ].start =bcm63xx_regset_address (RSET_WDT ); + wdt_resources[0 ].end = wdt_resources[0 ].start; + wdt_resources[0 ].end +=RSET_WDT_SIZE -1 ; + +return platform_device_register (&bcm63xx_wdt_device); +}arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h new file +0
-0
arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h line 6
Quoted 6 lines
arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h new file +6
-0@@ -0,0 +1,6 @@ +#ifndef BCM63XX_DEV_WDT_H_ +#define BCM63XX_DEV_WDT_H_ + +int bcm63xx_wdt_register (void ); + +#endif /* BCM63XX_DEV_WDT_H_ */
bcm63xx_dev_wdt.h only really exists to keep checpatch.pl happy - not a terribly good reason. I suggest to remove the explicit call to bcm63xx_wdt_register, make the function static and use some initfunc magic to call it and bcm63xx_dev_wdt.h can go.
Ralf
Le Saturday 08 August 2009 21:40:33 Ralf Baechle, vous avez écrit :
Quoted 91 lines · Florian Fainelli
Quoted 90 lines
This patch registers the watchdog
platform_devicethat we are going to use in the watchdogplatform_driverin a subsequent patch.Signed-off-by Florian Fainelli <[email protected]>---
arch/mips/bcm63xx/Makefile +1
-0@@ -5,6 +5,7 @@ obj-y += dev-usb-ohci.o obj-y += dev-usb-ehci.o obj-y += dev-enet.o obj-y += dev-dsp.o +obj-y += dev-wdt.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += boards/(quoted diff) +0
-0
b/arch/mips/bcm63xx/boards/board_bcm963xx.cindex 17a8636..e6a7b4f 100644arch/mips/bcm63xx/boards/board_bcm963xx.c +2
-0@@ -28,6 +28,7 @@#include <bcm63xx_dev_usb_ohci.h> #include <bcm63xx_dev_usb_ehci.h> #include <bcm63xx_dev_dsp.h> +#include <bcm63xx_dev_wdt.h> #include <board_bcm963xx.h> #define PFX "board_bcm963xx: "@@ -798,6 +799,7 @@ int __init board_register_devices(void)u32 val;bcm63xx_uart_register (); +bcm63xx_wdt_register ();if (board.has_pccard)bcm63xx_pcmcia_register ();arch/mips/bcm63xx/dev-wdt.c new file +2
-0@@ -0,0 +1,36 @@ +/* +* This file is subject to the terms and conditions of the GNU General Public + * License. See the file "COPYING" in the main directory of this archive + * for more details.
+ *
+ * Copyright (C) 2008 Florian Fainelli <[email protected]>
+ */arch/mips/bcm63xx/dev-wdt.c new file +29
-0+ +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> +#include <bcm63xx_cpu.h> + +static struct resource wdt_resources[] = { + { + .start =-1 ,/* filled at runtime */ + .end =-1 ,/* filled at runtime */ + .flags =IORESOURCE_MEM , + }, +}; + +static struct platform_device bcm63xx_wdt_device = { + .name ="bcm63xx-wdt" , + .id =0 , + .num_resources =ARRAY_SIZE (wdt_resources), + .resource = wdt_resources, +}; + +int __init bcm63xx_wdt_register (void ) +{ + wdt_resources[0 ].start =bcm63xx_regset_address (RSET_WDT ); + wdt_resources[0 ].end = wdt_resources[0 ].start; + wdt_resources[0 ].end +=RSET_WDT_SIZE -1 ; + +return platform_device_register (&bcm63xx_wdt_device); +}(quoted diff) +0
-0
b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.hnew file mode 100644
index 0000000..4aae2c7arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h new file +3
-0@@ -0,0 +1,6 @@ +#ifndef BCM63XX_DEV_WDT_H_ +#define BCM63XX_DEV_WDT_H_ +
Quoted 8 lines
arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h line 6
Quoted 3 lines
arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_wdt.h new file +3
-0+int bcm63xx_wdt_register (void ); + +#endif /* BCM63XX_DEV_WDT_H_ */
bcm63xx_dev_wdt.honly really exists to keep checpatch.pl happy - not a terribly good reason. I suggest to remove the explicit call tobcm63xx_wdt_register, make the function static and use some initfunc magic to call it andbcm63xx_dev_wdt.hcan go.
Thanks for your comment, I just sent two follow-up patches against patch 7/8 which addresses that for the uart and watchdog registration.
Signature · 5 lines
Best regards, Florian Fainelli Email: [email protected] Web: http://openwrt.org IRC: [florian] on irc.freenode.net -------------------------------