x86 : omit duplicate processing at pte_pgprot()
Thank you for your genial response, and I'm sorry that I neglected to read Documentation/SubmittingPatches carefully. And I understood DCO.
Quoted 12 lines
Quoted 4 lines
I suggest following PATCH that omit duplicate processing of mask.
pte_pgprot()macro [arch/x86/include/asm/pgtable.h] callpte_flags()[arch/x86/include/asm/pgtable_types.h] that return value is masked byPTE_FLAGS_MASKinpte_flags()function, and this macro also masks the returned value byPTE_FLAGS_MASK.It probably won't make any difference in practice, because gcc will do a common subexpression elimination for the "&
PTE_FLAGS_MASK" between the inline function and its caller. But it does tidy things up a bit.Quoted 3 lines
I guess that we don't have to do the mask processing at
pte_pgprot()macro because it has already been masked atpte_flags(). So, how about the following PATCH ?
Quoted 8 lines
Quoted 2 lines
<Hiroyasu OHYAMA>
Please add a proper Signed-off-by: line.
J
Quoted 20 lines
Quoted 19 lines
arch/x86/include/asm/pgtable.h +0
-1@@ -265,7 +265,7 @@ static inline pgprot_t pgprot_modify(pgprot_t oldprot, pgprot_t newprot)return __pgprot (preservebits | addbits); } -#define pte_pgprot(x) __pgprot(pte_flags(x) & PTE_FLAGS_MASK) +#define pte_pgprot(x) __pgprot(pte_flags(x))#define canon_pgprot (p) __pgprot(massage_pgprot(p)) --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/