Skip to contentSkip to conversation

PATCH [2.6.31-rc6] fix warning in traps.c line 535

PATCH Grant Grundler 1 participant 1 message Aug 19, 2009 2 messages not in the archive PA-RISC architecture

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

On Tue, Aug 18, 2009 at 01:45:17PM -0400, John David Anglin wrote:
...

Quoted 8 lines

There's one new parisc warning that I noticed:

CC arch/parisc/kernel/traps.o
arch/parisc/kernel/traps.c: In function 'handle_interruption':
arch/parisc/kernel/traps.c:535:18: warning: operation on 'regs->iasq[0]' may be undefined

Looks like a typo.

Yes - Line 535 should use both [0] and [1].

----

arch/parisc/kernel/traps.c +1 -1
index 528f0ff..8b58bf0 100644
@@ -532,7 +532,7 @@ void notrace handle_interruption(int code, struct pt_regs *regs)
 	  	/* Kill the user process later */
 	  	regs->iaoq[0] = 0 | 3;
 		regs->iaoq[1] = regs->iaoq[0] + 4;
-	 	regs->iasq[0] = regs->iasq[0] = regs->sr[7];
+	 	regs->iasq[0] = regs->iasq[1] = regs->sr[7];
 		regs->gr[0] &= ~PSW_B;
 		return;
 	}