Skip to contentSkip to conversation

Please pull u-boot-mpc83xx

U-Boot Applied Kim Phillips 3 participants 6 messages Aug 21, 2009 – Aug 24, 2009

lore
Share & tools
lore
#0 lore raw

Wolfgang Denk,

Please pull:

The following changes since commit 1aada9cd643567d351667138851e9231ccfa245a:
Wolfgang Denk (1):
Fix all linker scripts for older binutils versions (pre-2.16)

are available in the git repository at:

git://git.denx.de/u-boot-mpc83xx.git master

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Kim Phillips (3):
mpc83xx: tqm8349 - remove pci & flash window conflict
mpc83xx: mpc8377erdb - change DDR settings to those from latest bsp
mpc83xx: accommodate larger kernel sizes by default

Paul Gortmaker (2):
mpc83xx: sbc8349 - make enabling PCI more user friendly
mpc83xx: mpc8349 - delete unused SYS_MID_FLASH_JUMP

 Makefile                      |   19 ++++++++++++++-
 doc/README.sbc8349            |   50 +++++++++++++++++++++++++++-------------
 include/configs/MPC8313ERDB.h |    4 +-
 include/configs/MPC8315ERDB.h |    4 +-
 include/configs/MPC8323ERDB.h |    4 +-
 include/configs/MPC832XEMDS.h |    4 +-
 include/configs/MPC8349EMDS.h |    5 +--
 include/configs/MPC8360EMDS.h |    4 +-
 include/configs/MPC837XEMDS.h |    4 +-
 include/configs/MPC837XERDB.h |   10 ++++----
 include/configs/TQM834x.h     |    2 +-
 include/configs/sbc8349.h     |   27 ++++++++++++---------
 include/configs/vme8349.h     |    5 +--
 include/mpc83xx.h             |    3 ++
 14 files changed, 91 insertions(+), 54 deletions(-)

Thanks,

Kim

#1 lore raw

Dear Kim Phillips,

Quoted 8 lines · In message <[email protected]> you wrote:

Wolfgang Denk,

Please pull:

The following changes since commit 1aada9cd643567d351667138851e9231ccfa245a:
Wolfgang Denk (1):
Fix all linker scripts for older binutils versions (pre-2.16)

Quoted 6 lines

are available in the git repository at:

git://git.denx.de/u-boot-mpc83xx.git master

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Umm.... please do not edit the Subject line of the commit messages. At least, please tell me explicitly if you do. The reason is that I cannot find any such patch anywhere - because the real Subject was "83xx: add..."

Quoted 9 lines

Kim Phillips (3):
mpc83xx: tqm8349 - remove pci & flash window conflict
mpc83xx: mpc8377erdb - change DDR settings to those from latest bsp
mpc83xx: accommodate larger kernel sizes by default

Paul Gortmaker (2):
mpc83xx: sbc8349 - make enabling PCI more user friendly
mpc83xx: mpc8349 - delete unused SYS_MID_FLASH_JUMP

Quoted 15 lines
 Makefile                      |   19 ++++++++++++++-
 doc/README.sbc8349            |   50 +++++++++++++++++++++++++++-------------
 include/configs/MPC8313ERDB.h |    4 +-
 include/configs/MPC8315ERDB.h |    4 +-
 include/configs/MPC8323ERDB.h |    4 +-
 include/configs/MPC832XEMDS.h |    4 +-
 include/configs/MPC8349EMDS.h |    5 +--
 include/configs/MPC8360EMDS.h |    4 +-
 include/configs/MPC837XEMDS.h |    4 +-
 include/configs/MPC837XERDB.h |   10 ++++----
 include/configs/TQM834x.h     |    2 +-
 include/configs/sbc8349.h     |   27 ++++++++++++---------
 include/configs/vme8349.h     |    5 +--
 include/mpc83xx.h             |    3 ++
 14 files changed, 91 insertions(+), 54 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Comparing information  and  knowledge  is  like  asking  whether  the
fatness  of  a  pig  is more or less green than the designated hitter
rule."                                               - David Guaspari
#2 lore raw
Quoted 7 lines · On Sat, 22 Aug 2009 00:26:57 +0200 Wolfgang Denk <[email protected]> wrote:
Quoted 2 lines

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Umm.... please do not edit the Subject line of the commit messages. At least, please tell me explicitly if you do. The reason is that I cannot find any such patch anywhere - because the real Subject was "83xx: add..."

sounds like I shouldn't be prefixing mpc83xx patch subjects with mpc83xx for consistency. I'd rather keep that habit myself, but if that's what you prefer..

Kim

#3 lore raw

Dear Kim Phillips,

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 3 lines

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Quoted 8 lines
Quoted 4 lines

Umm.... please do not edit the Subject line of the commit messages. At least, please tell me explicitly if you do. The reason is that I cannot find any such patch anywhere - because the real Subject was "83xx: add..."

sounds like I shouldn't be prefixing mpc83xx patch subjects with mpc83xx for consistency. I'd rather keep that habit myself, but if that's what you prefer..

I like consistency, too. But for me it's also important to be able to associate commits to the actual postings on the mailing list. The best solution would be if the sumbitters could already use such
Subject: lines.

Maybe we should formulate such a rule / requirement / wish ?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
At the source of every error which is blamed on the computer you will
find at least two human errors, including the error of blaming it  on
the computer.
#4 lore raw
Quoted 16 lines · On Sat, 22 Aug 2009 10:00:36 +0200 Wolfgang Denk <[email protected]> wrote:

Dear Kim Phillips,

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 3 lines

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Quoted 8 lines
Quoted 4 lines

Umm.... please do not edit the Subject line of the commit messages. At least, please tell me explicitly if you do. The reason is that I cannot find any such patch anywhere - because the real Subject was "83xx: add..."

sounds like I shouldn't be prefixing mpc83xx patch subjects with mpc83xx for consistency. I'd rather keep that habit myself, but if that's what you prefer..

Quoted 6 lines

I like consistency, too. But for me it's also important to be able to associate commits to the actual postings on the mailing list. The best solution would be if the sumbitters could already use such
Subject: lines.

Maybe we should formulate such a rule / requirement / wish ?

you can try, but most of the patches that come in for 83xx are fine, just without that 'mpc83xx: ' up front (esp. the 'mpc' part).

Personally, I'm in favour of dynamic learning and adapting of our contributors, rather than establishing hard rules - I don't want to have to reject a patch for something so easy to fix.

Might I suggest we use a more sophisticated patch tracking tool than sorting inboxes, such as patchworks?

Kim

#5 lore raw
Quoted 30 lines · Kim Phillips
Quoted 17 lines · On Sat, 22 Aug 2009 10:00:36 +0200 Wolfgang Denk <[email protected]> wrote:

Dear Kim Phillips,

In message <[email protected]> you

Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 3 lines

Heiko Schocher (1):
mpc83xx: add missing CSCONFIG_ODT_WR_CFG for 832x CPUs

Quoted 8 lines
Quoted 4 lines

Umm.... please do not edit the Subject line of the commit messages. At least, please tell me explicitly if you do. The reason is that I cannot find any such patch anywhere - because the real Subject was "83xx: add..."

sounds like I shouldn't be prefixing mpc83xx patch subjects with mpc83xx for consistency. I'd rather keep that habit myself, but if that's what you prefer..

Quoted 6 lines

I like consistency, too. But for me it's also important to be able to associate commits to the actual postings on the mailing list. The best solution would be if the sumbitters could already use such
Subject: lines.

Maybe we should formulate such a rule / requirement / wish ?

you can try, but most of the patches that come in for 83xx are fine, just without that 'mpc83xx: ' up front (esp. the 'mpc' part).

Quoted 6 lines

Personally, I'm in favour of dynamic learning and adapting of our contributors, rather than establishing hard rules - I don't want to have to reject a patch for something so easy to fix.

Might I suggest we use a more sophisticated patch tracking tool than sorting inboxes, such as patchworks?

I'm in agreement w/Kim on this. I've been doing similar commit header editing and I've been doing on the kernel side for sometime. It seems easier to look at using patchworks (we can probably use the setup that the ozlabs.org guys have already if we want).

- k