Skip to contentSkip to conversation

netns: don't run sysfsview testcase

PATCH In review Serge E. Hallyn 2 participants 2 messages Aug 26, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netns: don't run sysfsview testcase

It can't pass right now, and leaves the system in a bad state on its inevitable failure.

Leave the testcase there though since one day we will hopefully support it.

---
 testcases/kernel/containers/netns/runnetnstest.sh |   25 ++++++++++++--------
 1 files changed, 15 insertions(+), 10 deletions(-)
testcases/kernel/containers/netns/runnetnstest.sh +15 -10
index 8a52e7b..e5ae694 100755
@@ -90,16 +90,21 @@ else
 fi
 echo
 
-sysfsview
-rc=$?
-if [ $rc -ne 0 ]; then
-    exit_code=$rc
-    errmesg="$errmesg sysfsview: return code is $exit_code ; "
-    echo $errmesg
-else
-   echo "sysfsview: PASS"
-fi
-echo
+# sysfs tagging does not exist, so this test can't pass.  In
+# fact at the moment it fails when mount -t sysfs none /sys is
+# refused, fails in a bad state, leaving the system hard to
+# reboot.  Revisit enabling this test when per-container sysfs
+# views are supported.
+#sysfsview
+#rc=$?
+#if [ $rc -ne 0 ]; then
+#    exit_code=$rc
+#    errmesg="$errmesg sysfsview: return code is $exit_code ; "
+#    echo $errmesg
+#else
+#   echo "sysfsview: PASS"
+#fi
+#echo
 
 par_chld_ftp
 rc=$?
Signature · 12 lines
1.6.0.4


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw
Quoted 7 lines · Serge E. Hallyn

It can't pass right now, and leaves the system in a bad state on its inevitable failure.

Leave the testcase there though since one day we will hopefully support it.

Ok. Merged.

Regards--
Subrata

Quoted 30 lines
---
 testcases/kernel/containers/netns/runnetnstest.sh |   25 ++++++++++++--------
 1 files changed, 15 insertions(+), 10 deletions(-)
testcases/kernel/containers/netns/runnetnstest.sh +8 -10
index 8a52e7b..e5ae694 100755
@@ -90,16 +90,21 @@ else
 fi
 echo
 
-sysfsview
-rc=$?
-if [ $rc -ne 0 ]; then
-    exit_code=$rc
-    errmesg="$errmesg sysfsview: return code is $exit_code ; "
-    echo $errmesg
-else
-   echo "sysfsview: PASS"
-fi
-echo
+# sysfs tagging does not exist, so this test can't pass.  In
+# fact at the moment it fails when mount -t sysfs none /sys is
+# refused, fails in a bad state, leaving the system hard to
+# reboot.  Revisit enabling this test when per-container sysfs
+# views are supported.
+#sysfsview
+#rc=$?
+#if [ $rc -ne 0 ]; then

testcases/kernel/containers/netns/runnetnstest.sh else · line 110

Quoted 10 lines
testcases/kernel/containers/netns/runnetnstest.sh +7 -0
+#    exit_code=$rc
+#    errmesg="$errmesg sysfsview: return code is $exit_code ; "
+#    echo $errmesg
+#else
+#   echo "sysfsview: PASS"
+#fi
+#echo
 
 par_chld_ftp
 rc=$?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list